21517: ProcEstablishConnection (dispatch.c:3685)
====by 0x26CEB: Dispatch (dispatch.c:432)
====by 0x205E7: main (main.c:291)
==== Uninitialised value was created by a stack allocation
====at 0xCA4E0: rrGetScreenResources (rrscreen.c:313)
Signed-off-by: Oliver McFadden
---
randr/rrscr
On Mon, 2011-03-07 at 12:04 -0500, ext Peter Harris wrote:
> On 2011-03-07 11:28, Oliver McFadden wrote:
> > I am not sure whether this is a known issue, but anyway, I am seeing
> > xbindkeys crashing after a few button presses. Perhaps this should go to
> > the xbindkey
Hi,
I am not sure whether this is a known issue, but anyway, I am seeing
xbindkeys crashing after a few button presses. Perhaps this should go to
the xbindkeys developers, but I'm reasonably sure this is a bug in xcb.
You can reproduce it as follows:
1. Start xbindkeys in non-daemon mode so you
On Mon, 2011-02-14 at 19:23 +0100, ext Julien Cristau wrote:
> On Mon, Feb 14, 2011 at 20:05:45 +0200, Oliver McFadden wrote:
>
> > On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote:
> > > I don't think this has been merged into master yet (and we should app
On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote:
> I don't think this has been merged into master yet (and we should apply
> it to the 1.9.xxx branches too), so I've added my Reviewed-by below.
> Good catch!
Sorry for the bump again. I was asked to add the Reported-by
xisting behavior, which may be relied upon.
>
> Reviewed-by: Rami Ylimäki
> Signed-off-by: Erkki Seppälä
Reviewed-by: Oliver McFadden
> ---
> record/record.c |6 +-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/record/record.c b/record/reco
ut I
> made it this way so that there wouldn't be huge commit messages.
You can add this for the entire series:
Reviewed-by: Oliver McFadden
> Ander Conselvan de Oliveira (4):
> ProcRRQueryVersion: fix use of uninitialized bytes valgrind error.
> ProcRRCreateMode: fix use o
: GetPointerEvents (getevents.c:1074)
Signed-off-by: Oliver McFadden
---
I'm not sure anyone actually cares about this patch anymore, since this code has
changed completely due to the valuator rework. If someone wants to apply it to
the 1.9.2(.xxx) branches, then please be my guest.
dix/geteve
On Fri, 2010-10-29 at 15:37 +1000, ext Peter Hutterer wrote:
> On Sun, Oct 24, 2010 at 01:45:03PM +0200, Paolo D'Apice wrote:
> > The evdev driver does not allow to set a custom axes rotation
> > as the mousedrv driver does with the option "AngleOffset".
> > This option is necessary for some trackb
On Fri, 2010-07-16 at 01:28 +0200, ext Peter Hutterer wrote:
> On Wed, Jul 14, 2010 at 11:26:43AM +0300, Oliver McFadden wrote:
> > This is very similar to the RunFromSmartParent (implicit) option, except
> > we do not send the signal to our parent process, but our own process
&
, send us SIGCONT and move our job
status from SPAWNED to RUNNING.
Signed-off-by: Oliver McFadden
---
include/opaque.h |1 +
os/connection.c |5 +
os/utils.c |5 +
3 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/include/opaque.h b/include/opaque.h
index
job status from SPAWNED to RUNNING.
Signed-off-by: Oliver McFadden
---
v3: resend patch because it seems to have been idle for some time...
- changed kill(getpid()) to raise().
include/opaque.h |1 +
os/connection.c |5 +
os/utils.c |5 +
3 files changed, 11
the buffer,
> we must be be careful and trim oversized fills.
>
> Signed-off-by: Chris Wilson
> Tested-by: Michael Stapelberg
Reviewed-by: Oliver McFadden
> ---
> fb/fbfill.c| 38 --
> include/misc.h |1 +
> 2 files changed
On Fri, 2010-07-02 at 10:43 +0200, ext Chris Wilson wrote:
> Fixes:
>
> Bug 27313 - random X11 crash (SIGSEGV) when rendering firefox in
> pixman/intel
> https://bugs.freedesktop.org/show_bug.cgi?id=27313
>
> As pixman does not guard against a fill request outside of the buffer,
> we must be
On Fri, 2010-05-28 at 07:09 +0200, ext Alan Coopersmith wrote:
> Oliver McFadden wrote:
> > Right, that's true. I would suggest switching over to MediaWiki at some
> > point though. This could of course be after cleaning up the docs.
>
> I like MediaWiki too, at least
On Fri, 2010-05-28 at 06:34 +0200, ext Peter Hutterer wrote:
> On Fri, May 28, 2010 at 03:23:32AM +0300, Oliver McFadden wrote:
> > On Fri, 2010-05-28 at 01:55 +0200, ext Tiago Vignatti wrote:
> > > Matt,
> > >
> > > On 05/26/2010 04:12 PM, Matt Dew wrote:
&g
On Fri, 2010-05-28 at 01:55 +0200, ext Tiago Vignatti wrote:
> Matt,
>
> On 05/26/2010 04:12 PM, Matt Dew wrote:
> > Ok here's a summary of current changes:
> >
> > 1) I used kernelnewbies.org as the template, so this page doesn't look
> > like the xorg wiki. (probably least important diff),
>
>
reed, which didn't happen if the invisible cursor was never used in
> a server generation. So this fixes a segfault in Xnest as well.
>
> Signed-off-by: Jamey Sharp
Signed-off-by: Oliver McFadden
Tested-by: Oliver McFadden
> ---
> I think this is working as intended. Olive
Oops; forgot to reply-to-all.
On Tue, 2010-05-25 at 07:17 +0300, Oliver McFadden wrote:
> On Tue, 2010-05-25 at 05:00 +0200, ext Jamey Sharp wrote:
> > Hi Oliver!
> >
> > On Mon, May 24, 2010 at 7:45 PM, Oliver McFadden
> > wrote:
> > > I'll check t
des.
-- Oliver.
On Mon, 2010-05-24 at 20:45 +0200, ext Jamey Sharp wrote:
> Oliver McFadden reports that the invisible cursor sprite caused damage
> events and thus unnecessary redrawing, so removing it improves
> performance when using software cursor sprites, especially on those
&g
cursor sprites, primarily on
> > devices where you do not want a visible cursor (touchscreen tablets,
> > embedded devices, etc.)
> >
> > Signed-off-by: Oliver McFadden
> > ---
> > v2 of [PATCH] mi: removed the invisible cursor sprite; use NullCursor
> &
efineCursor) or has been
> hidden (via XFixesHideCursor.)
>
> Improves performance when using software cursor sprites, primarily on
> devices where you do not want a visible cursor (touchscreen tablets,
> embedded devices, etc.)
>
> Signed-off-by: Oliver McFadden
> ---
> v2
software cursor sprites, primarily on
devices where you do not want a visible cursor (touchscreen tablets,
embedded devices, etc.)
Signed-off-by: Oliver McFadden
---
v2 of [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.
xfixes/cursor.c | 46 --
On Thu, 2010-05-20 at 23:43 +0200, ext Keith Packard wrote:
> On Thu, 20 May 2010 13:14:34 +0300, Oliver McFadden
> wrote:
>
> > Alright, I'll roll another patch and check it.
>
> I'm waiting to see the updated version of this patch.
Unfortunately I haven&#
On Tue, 2010-05-18 at 22:38 +0200, ext Jamey Sharp wrote:
> For the xfree86 DDX, if hardware cursors are used, the driver is
> required to provide a HideCursor function, which will be called
> instead of trying to set a null cursor. I think software cursors are
> already safe. The other DDXes also
On Tue, 2010-05-18 at 15:16 +0200, Vignatti Tiago (Nokia-D/Helsinki)
wrote:
> On Tue, May 18, 2010 at 08:34:39AM +0200, ext Keith Packard wrote:
> > On Tue, 18 May 2010 08:44:27 +0300, Oliver McFadden
> > wrote:
> >
> > > I suppose for HW cursor it doesn't r
On Tue, 2010-05-18 at 14:54 +0200, Vignatti Tiago (Nokia-D/Helsinki)
wrote:
> On Mon, May 17, 2010 at 06:43:54PM +0200, ext Keith Packard wrote:
> > On Mon, 17 May 2010 07:50:25 +0300, Oliver McFadden
> > wrote:
> > > Previously the cursor code would be called eve
On Tue, 2010-05-18 at 08:34 +0200, ext Keith Packard wrote:
> On Tue, 18 May 2010 08:44:27 +0300, Oliver McFadden
> wrote:
>
> > I suppose for HW cursor it doesn't really matter since we wouldn't take
> > damage on that, right? We just draw everything normally,
On Mon, 2010-05-17 at 18:43 +0200, ext Keith Packard wrote:
> On Mon, 17 May 2010 07:50:25 +0300, Oliver McFadden
> wrote:
> > Previously the cursor code would be called even with a "hidden" cursor.
> > This was because the X server used an invisible 1x1 cursor sp
ill help performance when XDefineCursor() is never called, and
> also when the cursor is hidden via XFixesHideCursor() as there are no
> damage events generated via the MI functions.
>
> Note that this only applies for software cursors.
>
> Signed-off-by: Oliver McFadden
> ---
Note the e
) as there are no
damage events generated via the MI functions.
Note that this only applies for software cursors.
Signed-off-by: Oliver McFadden
---
mi/mipointer.c | 16
xfixes/cursor.c | 40 ++--
2 files changed, 14 insertions(+), 42
The following changes since commit 795432d4a92ed5b9fa4d9163e73c8e4fe4c74534:
Keith Packard (1):
Merge remote branch 'jamey/cleanups'
are available in the git repository at:
git://gitorious.org/omcfadde/xserver.git master
Oliver McFadden (2):
mi: remo
On Fri, 2010-05-14 at 07:19 +0200, ext Keith Packard wrote:
> On Fri, 14 May 2010 07:58:40 +0300, Oliver McFadden
> wrote:
>
> > Please note this patch breaks the ABI.
> >
> > Signed-off-by: Oliver McFadden
> > ---
> > hw/dmx/doc/dmx.sgml |
Please note this patch breaks the ABI.
Signed-off-by: Oliver McFadden
---
hw/dmx/doc/dmx.sgml |3 +--
hw/xquartz/quartz.c |1 -
include/scrnintstr.h | 10 --
mi/miexpose.c|2 --
4 files changed, 1 insertions(+), 15 deletions(-)
diff --git a/hw/dmx/doc/dmx.sgml b
On Thu, 2010-05-13 at 21:07 +0200, ext Adam Jackson wrote:
> On Thu, 2010-05-13 at 09:58 -0700, Keith Packard wrote:
> > On Thu, 13 May 2010 17:24:06 +0300, Oliver McFadden
> > wrote:
> >
> > > Wouldn't this break the ScreenRec ABI? I noticed this structure a
On Fri, 2010-05-14 at 06:54 +0200, Mcfadden Oliver (Nokia-D/Helsinki)
wrote:
> Please note this patch breaks the ABI.
>
> Signed-off-by: Oliver McFadden
> ---
> hw/dmx/doc/dmx.sgml |3 +--
> hw/xquartz/quartz.c |1 -
> include/scrnintstr.h |5 -
> mi/
Please note this patch breaks the ABI.
Signed-off-by: Oliver McFadden
---
hw/dmx/doc/dmx.sgml |3 +--
hw/xquartz/quartz.c |1 -
include/scrnintstr.h |5 -
mi/miexpose.c|2 --
4 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/hw/dmx/doc/dmx.sgml b/hw
Please note this patch breaks the ABI.
Signed-off-by: Oliver McFadden
Reviewed-by: Keith Packard
---
v2: completely remove the unused function pointer from the ScreenRec struct in
scrnintstr.h. Added note regarding ABI breakage.
hw/xnest/Screen.c|1 -
include/scrnintstr.h |6
On Thu, 2010-05-13 at 13:23 +0200, ext Keith Packard wrote:
> On Thu, 13 May 2010 11:45:02 +0300, Oliver McFadden
> wrote:
>
>
> > -PointerNonInterestBoxProcPtr PointerNonInterestBox;
> > +PointerNonInterestBoxProcPtr PointerNonInterestBox; /** unused */
&g
Signed-off-by: Oliver McFadden
---
hw/xnest/Screen.c|1 -
include/scrnintstr.h |2 +-
mi/mipointer.c | 12
mi/miscrinit.c |1 -
4 files changed, 1 insertions(+), 15 deletions(-)
diff --git a/hw/xnest/Screen.c b/hw/xnest/Screen.c
index ca903d7..1604a4c
Signed-off-by: Oliver McFadden
---
hw/xquartz/xpr/x-list.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/xquartz/xpr/x-list.c b/hw/xquartz/xpr/x-list.c
index 3596dd3..77c9309 100644
--- a/hw/xquartz/xpr/x-list.c
+++ b/hw/xquartz/xpr/x-list.c
@@ -97,6 +97,7 @@ X_PFX
On Wed, 2010-04-21 at 08:30 +0200, ext Peter Korsgaard wrote:
> >>>>> "Oliver" == Oliver McFadden writes:
>
> Hi,
>
> Oliver> Everything else looks fine; just the leaked storage issue.
>
> Great, can I add your Acked-by
On Wed, 2010-04-21 at 07:56 +0200, ext Peter Korsgaard wrote:
> >>>>> "Oliver" == Oliver McFadden writes:
>
> Oliver> Hi Peter,
>
> Oliver> There is one minor bug in this patch, you forgot to xfree()
> Oliver> "str" from xf86Che
Hi Peter,
There is one minor bug in this patch, you forgot to xfree() "str" from
xf86CheckStrOption when you're done with it; see my recent patch to
evdev.
I'll apply the patch locally and do a full analysis after my coffee. :-)
-- Oliver.
On Tue, 2010-04-20 at 17:36 +0200, ext Peter Korsgaard
The following changes since commit aaf65e7bfacd9501c4475a579d92c3bc60409893:
Paulo Ricardo Zanoni (1):
Don't set pEvdev->rel for mouse wheel events
are available in the git repository at:
git://gitorious.org/omcfadde/xf86-input-evdev.git master
Oliver McFadden (3):
On Tue, 2010-04-20 at 07:27 +0200, ext Peter Hutterer wrote:
> On Tue, Apr 20, 2010 at 07:11:15AM +0300, Oliver McFadden wrote:
> > Hi Peter,
> >
> > Most of these fixes are quite minor and related to memory leaks from
> > xf86...StrOption. They fix all Coverity err
Signed-off-by: Oliver McFadden
---
src/emuWheel.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/emuWheel.c b/src/emuWheel.c
index 3f0dfd4..afafff7 100644
--- a/src/emuWheel.c
+++ b/src/emuWheel.c
@@ -232,8 +232,8 @@ EvdevWheelEmuHandleButtonMap(InputInfoPtr pInfo
Called function "ioctl" whose return value should be checked (checked 10
out of 11 times)
Signed-off-by: Oliver McFadden
---
src/evdev.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 6992c68..ccea90d 100644
--- a/src/evd
Signed-off-by: Oliver McFadden
---
src/evdev.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index aae9b23..9fe952e 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1631,8 +1631,7 @@ static int
EvdevCacheCompare(InputInfoPtr pInfo, BOOL
Signed-off-by: Oliver McFadden
---
src/evdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index d133870..c3b44bb 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -2071,6 +2071,7 @@ EvdevPreInit(InputDriverPtr drv, IDevPtr dev, int flags
Signed-off-by: Oliver McFadden
---
src/evdev.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 9fe952e..6992c68 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1371,15 +1371,16 @@ EvdevInitButtonMapping(InputInfoPtr pInfo
Signed-off-by: Oliver McFadden
---
src/draglock.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/draglock.c b/src/draglock.c
index 6157cae..a7ad974 100644
--- a/src/draglock.c
+++ b/src/draglock.c
@@ -145,6 +145,8 @@ EvdevDragLockPreInit(InputInfoPtr pInfo
Signed-off-by: Oliver McFadden
---
src/evdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index c3b44bb..aae9b23 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1235,6 +1235,7 @@ EvdevAddAbsClass(DeviceIntPtr device)
pEvdev
Hi Peter,
Most of these fixes are quite minor and related to memory leaks from
xf86...StrOption. They fix all Coverity errors in evdev apart from one dead-code
error in EvdevUtilButtonEventToButtonNumber which I have intentionally left
unmodified (in case that code changes in the future.)
Event d
Signed-off-by: Oliver McFadden
---
exa/exa.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/exa/exa.c b/exa/exa.c
index c5ac7de..590d9a5 100644
--- a/exa/exa.c
+++ b/exa/exa.c
@@ -417,8 +417,8 @@ exaFinishAccess(DrawablePtr pDrawable, int index)
/* Catch
Hi,
This is the same as the pull request, but in easier to review patch format. I
have added Matt Turner's Reviewed-by lines to the patches he checked as OK.
[PATCH 1/5] exa: exaFinishAccess: Overrun of static array "pExaScr->access" of
size 6 at position 6 with index variable "i"
[PATCH 2/5] fb
Signed-off-by: Oliver McFadden
---
Xext/sync.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/Xext/sync.c b/Xext/sync.c
index ce65314..cf78cdc 100644
--- a/Xext/sync.c
+++ b/Xext/sync.c
@@ -2329,10 +2329,8 @@ IdleTimeBlockHandler(pointer env, struct timeval **wt
Signed-off-by: Oliver McFadden
Reviewed-by: Matt Turner
---
fb/fbscreen.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fb/fbscreen.c b/fb/fbscreen.c
index 24eadde..53e2ada 100644
--- a/fb/fbscreen.c
+++ b/fb/fbscreen.c
@@ -228,7 +228,11 @@ fbFinishScreenInit
to storage allocated by
"realloc(ptr->mon_comment, len + strlen(displaySize_string))"
Signed-off-by: Oliver McFadden
Reviewed-by: Matt Turner
---
hw/xfree86/common/xf86Configure.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86Configur
Signed-off-by: Oliver McFadden
---
hw/xfree86/parser/read.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/parser/read.c b/hw/xfree86/parser/read.c
index 1091be5..4e42b24 100644
--- a/hw/xfree86/parser/read.c
+++ b/hw/xfree86/parser/read.c
@@ -219,15
On Mon, 2010-03-15 at 16:23 +0100, ext Keith Packard wrote:
> On Tue, 09 Mar 2010 12:56:33 +0200, Oliver McFadden
> wrote:
>
> > Yeah, okay; my bad then. I will resend the patches individually.
>
> Were you going to post these patches so we can finish up the review
> p
On Mon, 2010-03-08 at 21:44 +0100, ext Ian Romanick wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Peter Hutterer wrote:
>
> > fwiw, I find it a lot easier to review patches that land on the mailing list
> > than a pull request where I have to go off, pull into my tree, review and
>
On Sat, 2010-03-06 at 19:19 +0100, ext Matt Turner wrote:
> On Fri, Mar 5, 2010 at 7:12 AM, Oliver McFadden
> wrote:
> > are available in the git repository at:
> >
> > git://gitorious.org/omcfadde/xserver.git analysis
>
> Do you not have an account on FreeDes
are available in the git repository at:
git://gitorious.org/omcfadde/xserver.git analysis
Oliver McFadden (5):
exa: exaFinishAccess: Overrun of static array "pExaScr->access" of size 6
at position 6 with index variable "i"
fb: fbFinishScreenInit: leaked_stor
On Thu, 2010-03-04 at 18:21 +0100, ext Jesse Barnes wrote:
> We need to track invalid targets as well as 0 targets, so just make it
> unsigned
Minor nit: commit message should say "signed" not "unsigned"
> so our comparisons work like they should.
>
> Reported-by: Kristian Høgsberg
> Signed-off-
On Mon, 2010-03-01 at 11:53 +0100, ext Guillem Jover wrote:
> Hi!
>
> On Mon, 2010-03-01 at 09:42:58 +0200, Oliver McFadden wrote:
> > From: Ylimaki Rami (EXT-Vincit/Tampere)
> > diff --git a/configure.ac b/configure.ac
> > index b9c7574..acedf74 100644
>
From: Ylimaki Rami (EXT-Vincit/Tampere)
There are two noreturn functions in the X server: FatalError and
AbortServer. Having any of those two functions in the middle of a call
stack will prevent unwinding the program properly and stops the
backtrace at those functions in gdb.
The file containing
Hi,
I'm sending this on behalf of Rami as it doesn't seem to have been included into
the tree with the other ARM backtrace patches. It's related to the already
included commits:
5b9a52be7e975e59e0bbc6b43539ecaff96b2ecd
ca364ca82a760d8e5347a6f9f79636c9a5e4e03f
(etc)
Perhaps it was never sent, or
On Fri, 2010-02-26 at 01:53 +0100, ext Peter Hutterer wrote:
> On Thu, Feb 25, 2010 at 11:45:59AM +0100, Julien Cristau wrote:
> > On Thu, Feb 25, 2010 at 12:35:00 +0200, Oliver McFadden wrote:
> >
> > > On Thu, 2010-02-25 at 11:25 +0100, ext Julien Cristau wrote:
> &g
On Fri, 2010-02-26 at 01:48 +0100, ext Peter Hutterer wrote:
> On Thu, Feb 25, 2010 at 10:21:07AM +0200, Oliver McFadden wrote:
> > Previously this was not implemented because it requires the X server has
> > the xf86PostButtonEventP() function which was not released at the time.
On Thu, 2010-02-25 at 11:25 +0100, ext Julien Cristau wrote:
> On Thu, Feb 25, 2010 at 10:21:07 +0200, Oliver McFadden wrote:
>
> > Previously this was not implemented because it requires the X server has
> > the xf86PostButtonEventP() function which was not released at the ti
Previously this was not implemented because it requires the X server has
the xf86PostButtonEventP() function which was not released at the time.
Signed-off-by: Oliver McFadden
---
src/evdev.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/evdev.c b/src
On Thu, 2010-02-25 at 02:01 +0100, ext Peter Hutterer wrote:
> On Wed, Feb 24, 2010 at 11:39:07AM +0200, Oliver McFadden wrote:
> > Because touchscreens only use one button (see EvdevProcessKeyEvent())
> > EvdevMBEmuFilterEvent() never calls EvdevMBEmuEnable(..., FALSE) to
> &
devices (unless overwritten by
Xorg.conf.)
Signed-off-by: Oliver McFadden
---
v3: rebased onto evdev master, and added man page documentation.
man/evdev.man |5 +++--
src/emuMB.c |6 +-
src/evdev.c | 14 --
src/evdev.h | 14 ++
4 files changed, 22
On Wed, 2010-02-24 at 11:16 +0100, ext Julien Cristau wrote:
> On Wed, Feb 24, 2010 at 08:15:31 +0200, Oliver McFadden wrote:
>
> > Unfortunately we're stuck with using Upstart, and in the tradition of
> > trying to
> > keep as close to upstream as possible
devices (unless overwritten by
Xorg.conf.)
Signed-off-by: Oliver McFadden
---
v2: made the if/else explicit (instead of setting to AUTO first, then DISABLED
if the device is a touchscreen.)
src/emuMB.c |6 +-
src/evdev.c | 11 ---
src/evdev.h | 11 +++
3 files changed, 16
devices (unless overwritten by
Xorg.conf.)
Signed-off-by: Oliver McFadden
---
src/emuMB.c |3 +++
src/evdev.c | 11 ---
src/evdev.h | 11 +++
3 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/emuMB.c b/src/emuMB.c
index 199c0d7..14157bf 100644
--- a/src
nts), send us SIGCONT, and move our job
from the SPAWNED to RUNNING status.
Signed-off-by: Oliver McFadden
---
doc/Xserver.man.pre |5 +
include/opaque.h|1 +
os/connection.c |5 +
os/utils.c |5 +
4 files changed, 16 insertions(+), 0 deletions(-)
di
On Wed, 2010-02-24 at 08:49 +0100, ext Aaron Plattner wrote:
> On Tue, Feb 23, 2010 at 10:15:31PM -0800, Oliver McFadden wrote:
> > This is very similar to the RunFromSmartParent option, except we do not
> > send the signal to our parent process, but our own process instead; also
&g
nts), send us SIGCONT, and move our job
from the SPAWNED to RUNNING status.
Signed-off-by: Oliver McFadden
---
Unfortunately we're stuck with using Upstart, and in the tradition of trying to
keep as close to upstream as possible, I'm sending this for review...
According to http://upstart
On Tue, 2010-02-16 at 21:24 +0100, ext Matt Turner wrote:
> It was in the main tree, committed by Oliver, but then it disappeared.
> This was all just a couple days ago.
Yes, I pushed it to the master branch of the X server, but the
development process seems to have changed since my time committin
On Tue, 2010-02-02 at 20:57 +0100, ext Dan Nicholson wrote:
> On Tue, Feb 2, 2010 at 6:43 AM, Oliver McFadden
> wrote:
> > commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this
> > regression; it can cause existing config files to be parsed incorrectly.
> >
&
commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this
regression; it can cause existing config files to be parsed incorrectly.
Acked-by: Julien Cristau
Reviewed-by: Dan Nicholson
Signed-off-by: Oliver McFadden
---
hw/xfree86/parser/scan.c | 16
1 files changed, 8
commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this
regression; it can cause existing config files to be parsed incorrectly.
Signed-off-by: Oliver McFadden
---
hw/xfree86/parser/scan.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/xfree86
On Mon, 2009-12-28 at 11:09 +0100, ext Mikhail Gusarov wrote:
> Twas brillig at 12:02:58 28.12.2009 UTC+02 when oliver.mcfad...@nokia.com did
> gyre and gimble:
>
> OM> + if (newpoints)
> OM> + xfree (newpoints);
>
> Which is equivalent to
>
> if (newpoints)
> if (newpoints)
> free(
Signed-off-by: Oliver McFadden
---
mi/mispans.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mi/mispans.c b/mi/mispans.c
index 5504341..8a46dfa 100644
--- a/mi/mispans.c
+++ b/mi/mispans.c
@@ -460,6 +460,8 @@ void miFillUniqueSpanGroup(DrawablePtr pDraw, GCPtr pGC
freed_arg: Pointer "srcbits" and "mskbits" freed by function "AllocARGBCursor"
Signed-off-by: Oliver McFadden
---
dix/window.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/dix/window.c b/dix/window.c
index caff1cb..be90981 10064
Signed-off-by: Oliver McFadden
---
dix/resource.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/dix/resource.c b/dix/resource.c
index 91d0cfb..71774d1 100644
--- a/dix/resource.c
+++ b/dix/resource.c
@@ -209,7 +209,10 @@ CreateNewResourceType(DeleteType deleteFunc
Hi,
Here are a couple of errors that our internal Coverity runs discovered. They are
in no particular order. There are more, but I haven't written patches for them
yet.
Please note these are **only compile tested** but I think they are okay. Most of
them are on the error paths.
[PATCH 1/4] Cover
Signed-off-by: Oliver McFadden
---
mi/mispans.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/mi/mispans.c b/mi/mispans.c
index 5504341..c9bd025 100644
--- a/mi/mispans.c
+++ b/mi/mispans.c
@@ -460,6 +460,10 @@ void miFillUniqueSpanGroup(DrawablePtr pDraw, GCPtr
alloc_fn: Called allocation function "miRegionCreate"
var_assign: Assigned variable "prgnSrcClip" to storage returned from
"miRegionCreate(&box, 1)"
Signed-off-by: Oliver McFadden
---
mi/mibitblt.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-
On Tue, 2009-12-08 at 06:55 +0100, ext Tomas Carnecky wrote:
> On Dec 8, 2009, at 1:52 AM, Tiago Vignatti wrote:
>
> > Tomas Carnecky wrote:
> >> On Dec 7, 2009, at 10:32 PM, Brian Paul wrote:
> >>> Tomas Carnecky wrote:
> During the past two days I played with the clang static analyzer. Clan
On Tue, 2009-10-13 at 00:40 +0200, ext Peter Hutterer wrote:
> On Mon, Oct 12, 2009 at 04:32:51PM +0300, Oliver McFadden wrote:
> > Originally based on a patch from Daniel Stone, this commit allows for
> > the calibration factors to be set either from Xorg.conf or via HAL.
> >
Originally based on a patch from Daniel Stone, this commit allows for
the calibration factors to be set either from Xorg.conf or via HAL.
Previously the only way was via the properties interface.
---
man/evdev.man |5 +
src/evdev.c | 56
On Mon, 2009-10-12 at 15:11 +0200, ext Julien Cristau wrote:
> On Mon, Oct 12, 2009 at 15:46:28 +0300, Oliver McFadden wrote:
>
> > Originally based on a patch from Daniel Stone, this commit allows for
> > the calibration factors to be set either from Xorg.conf or via HAL.
>
Originally based on a patch from Daniel Stone, this commit allows for
the calibration factors to be set either from Xorg.conf or via HAL.
Previously the only way was via the properties interface.
---
man/evdev.man |4
src/evdev.c | 56 -
Hi Peter,
Ok, I'll make the changes requested as soon as I can (hopefully today)
and send out another patch.
-- Oliver.
On Thu, 2009-10-08 at 05:05 +0200, ext Peter Hutterer wrote:
> On Mon, Aug 03, 2009 at 02:31:02AM +0300, oliver.mcfad...@nokia.com wrote:
> > From: O
From: Oliver McFadden
Originally based on a patch from Daniel Stone, this commit allows for
the calibration factors to be set either from Xorg.conf or via HAL.
Previously the only way was via the properties interface.
---
src/evdev.c | 51
From: Oliver McFadden
This feature is especially useful for touchscreen devices and is only
enabled with an X server which provides the xf86PostButtonEventP helper
function. See X server commit 8da0ff2d5108d10ca7330d428e8610a4a0e3.
---
configure.ac |8
src/evdev.c |8
From: Oliver McFadden
This is similar to commit 1f641d75edba7394201c1c53938215bae696791b.
It provides the same functionality of queuing the (in this case
emulated) events and waiting until an EV_SYN synchronization event is
received before posting them to the server.
This preserves the order
1 - 100 of 112 matches
Mail list logo
