These patches break yacc and lex compatibility mainly for removing the
global state from the parser, which I think is expected given that this
is a library.
This is my first patch to this list, so a few disclaimers:
- I hope it's the right list.
- I couldn't figure out the coding style (there seem
Bison can generate all necessary definitions itself; there is no need
to maintain a hand written file for that.
Signed-off-by: Ran Benita
---
src/xkbcomp/.gitignore |1 +
src/xkbcomp/Makefile.am |4 +-
src/xkbcomp/action.c |1 -
src/xkbcomp/compat.c |1 -
src/xkbcomp
All global state is removed from the parser and scanner.
This makes use of the standard facilities in Bison and Flex for
reentrant/pure scanner/lexer and location tracking.
Signed-off-by: Ran Benita
---
src/xkbcomp/compat.c |3 +-
src/xkbcomp/keytypes.c |3 +-
src/xkbcomp
On Fri, Feb 24, 2012 at 10:16:39AM -0500, Gaetan Nadon wrote:
> On 12-02-23 07:58 PM, Ran Benita wrote:
> > - I couldn't figure out the coding style (there seems to be use of
> > *all* of them...), so I just tried to match the surroundings.
> > - I've been using l
On Fri, Feb 24, 2012 at 06:56:28PM -0500, Gaetan Nadon wrote:
> On 12-02-24 02:25 PM, Ran Benita wrote:
> > On Fri, Feb 24, 2012 at 10:16:39AM -0500, Gaetan Nadon wrote:
> >> On 12-02-23 07:58 PM, Ran Benita wrote:
> >>> - I couldn't figure out the cod
With this series applied libxkbcommon is compiled without warnings on
gcc and clang, using the default CWARNFLAGS.
I had also ran clang-analyzer and fixed all the warnings there.
The patches should be independent so if any of them are problematic
they can be dropped.
Thanks,
Ran
[PATCH libxkbcomm
Signed-off-by: Ran Benita
---
src/xkbcomp/parseutils.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/xkbcomp/parseutils.h b/src/xkbcomp/parseutils.h
index dbaf683..dea25e6 100644
--- a/src/xkbcomp/parseutils.h
+++ b/src/xkbcomp/parseutils.h
@@ -36,17 +36,6 @@ extern int
Signed-off-by: Ran Benita
---
src/xkbcomp/action.c |1 -
src/xkbcomp/compat.c |1 -
src/xkbcomp/expr.c |1 -
src/xkbcomp/geometry.c |1 -
src/xkbcomp/indicators.c |1 -
src/xkbcomp/keycodes.c |1 -
src/xkbcomp/keymap.c |1 -
src/xkbcomp
Other headers include malloc just fine.
Signed-off-by: Ran Benita
---
makekeys/makekeys.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c
index c4142ec..21d70f5 100644
--- a/makekeys/makekeys.c
+++ b/makekeys/makekeys.c
@@ -33,9 +33,6 @@ from
All the functions already accept it as a parameter. This clears -Wshadow
warnings.
Signed-off-by: Ran Benita
---
makekeys/makekeys.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c
index 21d70f5..751b719 100644
--- a/makekeys
The name 'index' is used by the standard library, so use 'ndx' like some
other files.
Signed-off-by: Ran Benita
---
makekeys/makekeys.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c
in
Signed-off-by: Ran Benita
---
src/geom.c |1 -
src/maprules.c |2 --
src/xkbcomp/alias.c|1 -
src/xkbcomp/geometry.c |6 +-
src/xkbcomp/keymap.c |2 +-
5 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/geom.c b/src/geom.c
index
Fix all reported null dereferences from clang-analyzer.
There seems to be one false negative (in file indicators.c), but it is
fixed anyway.
Signed-off-by: Ran Benita
---
src/geom.c |1 +
src/xkb.c|5 ++---
src/xkbcomp/alias.c |2 +-
src/xkbcomp
These are all trivial/obvious fixes which clear a bunch of warnings.
Signed-off-by: Ran Benita
---
src/keysym.c |2 +-
src/maprules.c | 44
src/text.c | 29 +++--
src/xkbcomp
Signed-off-by: Ran Benita
---
src/xkbcomp/geometry.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xkbcomp/geometry.c b/src/xkbcomp/geometry.c
index fb5eef2..18f41e6 100644
--- a/src/xkbcomp/geometry.c
+++ b/src/xkbcomp/geometry.c
@@ -367,7 +367,7 @@ InitRowInfo
Signed-off-by: Ran Benita
---
src/xkbcomp/parseutils.h |8 +---
src/xkbcomp/xkbparse.y |2 ++
src/xkbcomp/xkbscan.l| 17 +
3 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/src/xkbcomp/parseutils.h b/src/xkbcomp/parseutils.h
index c646494
Signed-off-by: Ran Benita
---
src/xkbcomp/geometry.c |8
src/xkbcomp/symbols.c |2 +-
src/xkbcomp/utils.h|2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/xkbcomp/geometry.c b/src/xkbcomp/geometry.c
index 18f41e6..bb3a891 100644
--- a/src/xkbcomp
The yacc implementation can generate all the necessary token
definitions itself; there is no need to maintain a hand written
file for that.
Signed-off-by: Ran Benita
---
Resending this one as suggested by Gaetan Nadon. Should apply cleanly
after the other fix patches. Tested to work both with
On Sat, Feb 25, 2012 at 06:23:48PM +, Daniel Stone wrote:
> > BTW, that was purged from the libX11 copy in March 2009, so it may be worth
> > checking just how far out of sync libxkbcommon has gotten with the code it
> > was copied from and which everyone has been using in the meantime.
>
> In
There should be no diff now between libxkbcommon and libX11 copies of
makekeys, other than some whitespace and the
typedef uint32_t Signature
part.
I tried to break it so as to be easier to review. Please apply after
the other patches, as I made some changes to makekeys there as well.
Ran
[PATCH
e get mismatches upon running X,
and some LSB test failures (xts5).
Use an unsigned 32-bit integer on all platforms. Also,
eliminate the redundant multiple typedefs for the
Signature type.
Signed-off-by: Derek Buitenhuis
Reviewed-by: Daniel Stone
Signed-off-by: Ran B
This matches commit 78a894231ae8ec4959007b6d9b8d2a15d6333a1e from
libX11:
Signed-off-by: Alan Coopersmith
Signed-off-by: Ran Benita
---
makekeys/makekeys.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c
index a25a4a6..fdccaf0
the vendor syms to be manually synchronised with XKeysymDB.
Signed-off-by: Daniel Stone
Reviewed-by: Alan Coopersmith
Signed-off-by: Ran Benita
---
configure.ac | 25
makekeys/Makefile.am |3 ++
makekeys/makekeys.c |
uot;XF86Ungrab" as opposed to "XF86_Ungrab".
Signed-off-by: Ran Benita
---
makekeys/makekeys.c | 174 +--
src/keysym.c| 14 +
test/xkey.sh|2 +-
3 files changed, 60 insertions(+), 130 deletions(-)
diff --git
se we get mismatches upon running X,
and some LSB test failures (xts5).
Use an unsigned 32-bit integer on all platforms.
Signed-off-by: Derek Buitenhuis
Reviewed-by: Daniel Stone
Signed-off-by: Ran Benita
---
v2:
- Remove the 'register' keyword, from a previous
On Sun, Feb 26, 2012 at 03:30:42PM +0100, walter harms wrote:
> Am 25.02.2012 11:13, schrieb Ran Benita:
> > @@ -578,9 +578,13 @@ MakeMultiDefs(XkbRF_MultiDefsPtr mdefs,
> > XkbRF_VarDefsPtr defs)
> > static void
> > FreeMultiDefs(XkbRF_MultiDefsPtr defs)
> >
On Tue, Feb 28, 2012 at 07:04:31PM +, Daniel Stone wrote:
> Hi,
>
> On 28 February 2012 18:27, Ran Benita wrote:
> > Running the following semantic patch:
> >
> > @@
> > expression E;
> > @@
> > - if (E != NULL)
> > - free(E);
>
6 +)
are available in the git repository at:
g...@github.com:bluetech/libxkbcommon.git fixes-cont
for you to fetch changes up to e4b4d6b0510075fe62234f66185bf619c70fc126:
Fix "Could not resolve keysym" errors (2012-03-04 00:04:04 +0200)
-----------
On Sat, Mar 10, 2012 at 02:00:46PM +, Daniel Stone wrote:
> Hi Ran,
>
> On 3 March 2012 22:40, Ran Benita wrote:
> > [I know the normal procedure is to send the patches for review in
> > reasonable chunks to the list, however I won't have time the following
> &
By which one can tell when to switch groups, etc.
Signed-off-by: Ran Benita
---
This would allow me to delete some duplicate code in the application
and would make me a happy camper for a while.
Wasn't sure about a couple of things:
- Should the by_level API be exposed (the _syms one seems
On Mon, Mar 19, 2012 at 04:10:10PM +, Daniel Stone wrote:
> Hi Ran,
>
> On 16 March 2012 17:04, Ran Benita wrote:
> > By which one can tell when to switch groups, etc.
> >
> > Signed-off-by: Ran Benita
> > ---
> > This would allow me to delete some du
There's some unrelated groups of commits here. I've tried to arrange
them such that they can be picked selectively if needed.
The following commits are simple bug fixes and cleanup:
Mention xkb_state_new can return NULL
Properly free xkb_state's
Fix latin8 upper/lower case check
On Tue, Mar 27, 2012 at 02:59:13PM +0100, Daniel Stone wrote:
> Hi Ran,
>
> On 24 March 2012 15:24, Ran Benita wrote:
> > There's some unrelated groups of commits here. I've tried to arrange
> > them such that they can be picked selectively if needed.
>
> G
On Wed, Mar 28, 2012 at 07:07:57PM +0100, Daniel Stone wrote:
> Hi,
>
> On 27 March 2012 14:59, Daniel Stone wrote:
> > In terms of what I have coming up, aside from the context API and vmod
> > merging, I've got a branch that actually adds multiple-keysym support
> > that I just need to fix up a
On Tue, Mar 27, 2012 at 02:27:49PM +0100, Daniel Stone wrote:
> On 24 March 2012 15:03, Ran Benita wrote:
> > - Some way to update the state according to a given led state, i.e. say
> > the app is starting with the Caps Lock led on, I'd like to update the
> > modif
)
Ran Benita (30):
Fairly straightforward fixes, I think they should all be good, but
should be cherry-pickable (hope my rebasing didn't mess that up).
Move AC_USE_SYSTEMS_EXTENSIONS before AM_INIT_AUTOMAKE
Fix compiler warnings
Set xorg-macros CFLAGS correctly
On Mon, Apr 02, 2012 at 12:04:25PM +0100, Daniel Stone wrote:
> Hi,
>
> On 1 April 2012 16:31, Ran Benita wrote:
> > Also, I might as well mention that I rather like the following interface
> > from the libabc demo library (it's public domain):
> > https://git.ke
'fix' there is to just
> do more rounds of expansion, but the upstream-recommended method is
> actually to do it as we're doing it now, believe it or not.
>
> autotools makes me sad sometimes.
Didn't know that; good that you caught it.
> As for the rest -
>
On Wed, May 09, 2012 at 06:20:35PM +0100, Daniel Stone wrote:
> On 9 May 2012 16:13, Ran Benita wrote:
> > On Tue, May 08, 2012 at 05:35:23PM +0100, Daniel Stone wrote:
> >> Thanks a bunch for all your last changes too, I've merged everything
> >> except the DFL
On Wed, May 09, 2012 at 12:10:57PM -0400, Kristian Høgsberg wrote:
> Hi Ran,
Hi.
> Let me just point you to this branch as well:
>
> http://cgit.freedesktop.org/~krh/libxkbcommon/log/?h=keysyms
>
> I've been talking with Daniel about this in IRC, but I thought you
> might want to take a look
This avoids a couple of special cases in the code, and is more
consistent. Since anyone who includes xkbcommon.h also gets
xkbcommon-keysyms.h, and anyone who include xkbcommon-keysyms.h would
want NoSymbol anyway, there's no down side.
Signed-off-by: Ran Benita
---
Note: this probably s
doing (at least
enough to run git diff before git commit). And the defaults should be
fine too.
Signed-off-by: Ran Benita
---
Makefile.am |9 -
configure.ac | 23 ---
2 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 7
for you to fetch changes up to beccc375095c921b8c212b0f992ae88c87ca95ca:
Don't run the benchmark by default (2012-05-20 20:31:19 +0300)
--------
Ran Benita (9):
Fix configure check for xkbparse.c instead of parser.c
Fix a memleak
On Sun, Apr 02, 2017 at 10:27:28PM +0500, Mihail Konev wrote:
> Signed-off-by: Mihail Konev
> ---
> nls/Makefile.am | 18 +++---
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/nls/Makefile.am b/nls/Makefile.am
> index 57665fff4282..c0f0d0c7181f 100644
> --- a/nls
second patch; with that fixed:
Reviewed-by: Ran Benita
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
On Thu, Apr 06, 2017 at 05:37:28PM +0100, Daniel Stone wrote:
> Rather than throwing a fatal error when a keycode definition exceeds the
> declared maximum (i.e. 255), just ignore the definition and continue.
>
> This allows xkeyboard-config to start shipping datasets including high
> keycodes, wh
On Thu, Apr 06, 2017 at 08:14:35PM +0100, Daniel Stone wrote:
> On 6 April 2017 at 19:57, Ran Benita wrote:
> > I always hoped that Wayland systems could switch to a new keycode file,
> > which uses the full evdev key names (xkbcommon no longer has the 4
> > character limit)
On Fri, Apr 07, 2017 at 05:56:56AM +0500, Mihail Konev wrote:
> On Thu, Apr 06, 2017 at 09:37:02PM +0300, Ran Benita wrote:
> > On Sun, Apr 02, 2017 at 10:27:28PM +0500, Mihail Konev wrote:
> > > Signed-off-by: Mihail Konev
> > > ---
> > > nls/Makefile.am |
On Tue, Jan 19, 2016 at 01:16:40AM +0100, Mats Blakstad wrote:
> I've opened this ticket:
> https://bugs.freedesktop.org/show_bug.cgi?id=93660
>
> I need some feedback to be able to upload a final verion!
>
> How should the composer be formatted. Now each composer is added like this:
>
> *
On Mon, Feb 15, 2016 at 07:29:07PM +0100, Mats Blakstad wrote:
> There do not exist any precomposed character for these once.
>
> Does it mean that it is impossible to add these composers for XKB keyboards?
>
> That's really a big pitty!
It is a pity I suppose - Compose is exactly the place wher
On Tue, Feb 23, 2016 at 07:58:04AM -0300, Laércio de Sousa wrote:
> Currently Xephyr doesn't inherit host X server's keymap, which
> may lead to keymap mismatches when typing in a window inside
> Xephyr. If host X server supports XKB extension, this patch
> uses xcb-xkb to apply its keymap in Xephy
On Mon, Nov 23, 2015 at 11:04:10AM -0800, Keith Packard wrote:
>
> One of the many security holes in X is that any application can monitor
> the state of the keyboard device by querying the list of pressed keys on
> a regular basis. Here's a simple patch which makes that request report
> only key
On Thu, Nov 03, 2016 at 01:22:03PM +0100, Mariusz Mazur wrote:
> What I did:
> 1. Switched the overlay key to act as a modifier.
> interpret Overlay1_Enable+AnyOfOrNone(all) {
> -action= LockControls(controls=Overlay1);
> +action= SetControls(controls=Overlay1);
>
> 2. Bound i
resultSyms = into->syms[group];
> -resultActs = into->acts[group];
> -resultWidth = into->numLevels[group];
> -}
> -else
> +if ((from->numLevels[group] > into->numLevels[group])
> + || (from->defs.merge == MergeOverride))
On Thu, Sep 11, 2014 at 01:36:24AM +0300, Ran Benita wrote:
> On Tue, Sep 09, 2014 at 10:37:18PM +0200, Benno Schulenberg wrote:
> >
> > Hi,
> >
> > For many keyboard layouts, starting X produces the following warning:
> >
> > Warning: Type "
On Thu, Sep 11, 2014 at 10:18:52PM +0200, Benno Schulenberg wrote:
> On Thu, Sep 11, 2014, at 13:01, Ran Benita wrote:
> > Actually I'm not so sure. The current behavior of a key-group override
> > is per-symbol, e.g.
> >
> > override key
The files (besides README) were adapted from libX11 as of commit
6101b967b641355dd863fd1ce52c6a7d58bcbe68.
Signed-off-by: Ran Benita
---
.gitignore | 82 ++
COPYING | 942 +++
Makefile.am | 11 +
README | 31
itself, so the
resulting files are the same.
Signed-off-by: Ran Benita
---
Makefile.am | 4
configure.ac| 38 +-
cpprules.in | 30 ++
m4/ax_define_dir.m4 | 49
This set of patches splits the locale data (the nls/ directory and a
couple of related patches) from Xlib to a separate repository,
"xlocale-config" (the insparation is xkeyboard-config which I think has
worked out well). Xlib is made to depend on xlocale-config.
The reason for doing this is to b
Copied (almost) verbatim from libX11 as of commit
6101b967b641355dd863fd1ce52c6a7d58bcbe68.
The added Makefile.am files had extraneous SUBDIRS entries removed.
Signed-off-by: Ran Benita
---
specs/.gitignore| 5 +
specs/Makefile.am | 24 ++
specs/i18n
This is a verbatim copy of the nls/ directory from libX11 as of commit
6101b967b641355dd863fd1ce52c6a7d58bcbe68.
Signed-off-by: Ran Benita
---
nls/.gitignore | 12 +
nls/C/Compose.pre |0
nls/C/XI18N_OBJS|8 +
nls/C
The nls/ directory and the compose and localedb specs were split to a
separate repository, xlocale-config.
The locale directory path (usually /usr/share/X11/locale) is now
obtained from the xlocale-config pkg-config file.
Signed-off-by: Ran Benita
---
Makefile.am| 3
Adapted from libX11 as of commit
6101b967b641355dd863fd1ce52c6a7d58bcbe68.
Signed-off-by: Ran Benita
---
Makefile.am | 2 +-
configure.ac | 11 ++-
docbook.am | 105 +++
3 files changed, 116 insertions(+), 2 deletions(-)
create
Besides the usual stuff, a "xlocaledatadir" variable is added; this is
very useful for programs who wish to use the files without doing
guesswork or requiring explicit configure flags.
Signed-off-by: Ran Benita
---
Makefile.am | 3 +++
configure.ac | 3 ++-
xlocale-co
These specs have moved to a separate repository, xlocale-config.
Signed-off-by: Ran Benita
---
specs/i18n/compose/.gitignore | 2 -
specs/i18n/compose/Makefile.am | 20 -
specs/i18n/compose/compose-chart.pl | 388 --
specs/i18n/compose/docbook-nl.am| 128
It was only used in nls/, which was removed.
Signed-off-by: Ran Benita
---
cpprules.in | 30 --
1 file changed, 30 deletions(-)
delete mode 100644 cpprules.in
diff --git a/cpprules.in b/cpprules.in
deleted file mode 100644
index 03d6701..000
--
2.1.0
The locale configuration has moved to a separate repository,
xlocale-config.
Signed-off-by: Ran Benita
---
nls/.gitignore | 12 -
nls/C/Compose.pre |0
nls/C/XI18N_OBJS|8 -
nls/C/XLC_LOCALE.pre| 59 -
nls
Signed-off-by: Ran Benita
---
build.sh | 1 +
xorg.modules | 13 +
2 files changed, 14 insertions(+)
diff --git a/build.sh b/build.sh
index 6eac65d..7b41112 100755
--- a/build.sh
+++ b/build.sh
@@ -1022,6 +1022,7 @@ build_all_modules() {
build xcb util-keysyms
build
On Sun, Sep 14, 2014 at 11:44:33PM +0300, Ran Benita wrote:
>
> This set of patches splits the locale data (the nls/ directory and a
> couple of related patches) from Xlib to a separate repository,
Oops - this meant to say couple of specs. And the non-prefixed patches
are meant for lib
On Fri, Oct 17, 2014 at 03:39:17PM -0300, Laércio de Sousa wrote:
> Hi there!
>
> I'm currently working on a full XCB backend for xf86-video-nested driver.
> I'm able to translate all Xlib-related code in file xlibclient.c to XCB,
> except some Xkb related parts which force me to maintain a minima
`modifier` in parseline() in imLcPrs.c, which are
eventually matched as `ev->state & modifier_mask == modifier`).
Also explicitly list the accepted modifier names, since they are
not standard (e.g. "Ctrl" instead of "Control").
Signed-off-by: Ran Benita
---
man/
In the spec and the man page the `mods_rtrn` argument is described as
"backfilled with unconsumed modifiers" but actually it is backfilled
with the *consumed* modifiers. This is also mentioned a few lines below
in each case.
Signed-off-by: Ran Benita
---
I made the context big enoug
On Sat, Apr 04, 2015 at 03:17:29AM +0200, Vasil Zlatanov wrote:
> Currently when you hold down two keys at the same time on the keyboard,
> say for instance 'g' and '0' only the second key is repeated, producing
> g000.. or 0ggg... On Microsoft Windows (given the right keyboard) if you
> press 'g'
t).
https://bugs.freedesktop.org/show_bug.cgi?id=69950
Signed-off-by: Ran Benita
---
misc.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/misc.c b/misc.c
index 4990a74..848ed8c 100644
--- a/misc.c
+++ b/misc.c
@@ -82,41 +82,62 @@ ProcessI
On Sat, Oct 26, 2013 at 02:04:55PM -0700, Alan Coopersmith wrote:
> Does anyone know of any reason to waste time on this function? Can we just
> delete it altogther now? (libxkbfile is undocumented, and was originally
> considered private API, but we know software like GNOME has used it in the
>
On Sat, Oct 26, 2013 at 02:09:59PM -0700, Alan Coopersmith wrote:
> Xserver has its own copy of this code now, so we don't need to keep
> an unused copy in libxkbfile too.
Entire series looks good to me and server still compiles and goes
through xkbcomp OK.
You can go further with the first patch
On Fri, Nov 08, 2013 at 05:08:35PM -0800, Alan Coopersmith wrote:
> Fixes build failure with Solaris Studio compilers:
> "src/xkbcomp/ast-build.c", line 492: identifier redeclared: XkbFileCreate
> current : function(..., enum xkb_map_flags)
> previous: function(..., unsigned int) : "src/xkbcomp
On Wed, Nov 06, 2013 at 07:45:39PM -0800, Keith Packard wrote:
> Many system headers have warnings when compiled with this flag.
This was already committed, but how about changing to AC_CC_C99 instead?
pedantic _can_ be useful for XCB imo, e.g. the "enum too big for an int"
thing. Also, the code a
Hi Gaetan,
On Tue, Nov 26, 2013 at 07:02:23PM -0500, Gaetan Nadon wrote:
> On 13-11-26 06:33 PM, Ran Benita wrote:
> > This was already committed, but how about changing to AC_CC_C99 instead?
> Pardon me as I am out of context. The xserver module is configured with
> AC_PROG_C
Some of the hebrew keysyms come in different spellings, but are just
aliases, so the sequences are duplicates. Remove the ones which
keysymdef.h marks 'deprecated'.
Signed-off-by: Ran Benita
---
nls/en_US.UTF-8/Compose.pre | 10 --
1 file changed, 10 deletions(-)
diff -
both names. Remove
the unicode literal ones.
Signed-off-by: Ran Benita
---
nls/en_US.UTF-8/Compose.pre | 20
1 file changed, 20 deletions(-)
diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre
index 7314d7f..5434425 100644
--- a/nls/en_US.UTF-8/Compose.pre
I was playing with en_US.UTF-8 file a bit. These patches fix the issues
I found while constructing the trie. Happily the sequences are all
prefix-free, so there are only some duplicates to remove.
Ran Benita (2):
nls: remove duplicate 'ohorn' and 'uhorn' compose seq
Hi Andreas,
On Thu, Jan 23, 2014 at 09:00:11PM +0100, wettstein...@solnet.ch wrote:
> The goal of the following patches is to make ISOLock work. The most
> severe issues addressed were in the server, where the code used the
> incorrect byte to look for the "affect" flags, and where the ClearLocks
The build doesn't provide any way to define this option. It also refers
to files (imComp.h) and functions (e.g. XimCompInitTables(),
XimCompProcessSym()) which are not found anywhere, and the ordinary
Compose implementation in xim doesn't use any of it.
Signed-off-by: Ran Benita
n the parser and the implementation say:
ESCAPED_CHAR ::= ('\\' | '\"' | OCTAL | HEX )
HEX ::= '\' (x|X) HEX_CHAR [HEX_CHAR]]
HEX_CHAR ::= (0|1|2|3|4|5|6|7|8|9|A|B|C|D|E|F|a|b|c|d|e|f)
So "\0x123a" -> "\x3a".
Signed-off-
mall comments below you might want to address, but:
Reviewed-By: Ran Benita
> Signed-off-by: Andreas Wettstein
> ---
> action.c | 102
> ++-
> 1 file changed, 62 insertions(+), 40 deletions(-)
>
> diff --g
On Thu, Jan 23, 2014 at 08:39:55PM +0100, Andreas Wettstein wrote:
> Output "affect" flags for control locks, modifier locks, and ISOLock. Output
> flag "genKeyEvent" flag for message actions. Do not generate output for any
> of
> these if the flags have their default setting, to avoid problems
On Thu, Jan 23, 2014 at 08:39:49PM +0100, Andreas Wettstein wrote:
> Several fixes to ISOLock:
> - Use the proper byte to access the "affect" flags.
> - When changing a Set/Latch action to a Lock action, also change the
> flags for the action.
> - Respect NoLock/NoUnlock.
> - Add the missing tran
Lines starting with # are considered as preprocessor directives in the
.pre files.
Fixes warnings like:
:3:0: error: invalid preprocessing directive #Khmer
Signed-off-by: Ran Benita
---
nls/km_KH.UTF-8/Compose.pre | 2 +-
nls/sr_CS.UTF-8/Compose.pre | 32
2
On Sat, Feb 15, 2014 at 05:34:16PM +0100, wettstein...@solnet.ch wrote:
> > > +{"neither", (XkbSA_LockNoLock | XkbSA_LockNoUnlock)},
> >
> > You didn't add it, but I do wonder what "neither" is good for, it
> > renders the action rather useless, no?
>
> I added it for consistency to other act
off-by: Andreas Wettstein
Reviewed-By: Ran Benita
> ---
> src/xkbtext.c | 48 ++--
> 1 file changed, 46 insertions(+), 2 deletions(-)
>
> diff --git a/src/xkbtext.c b/src/xkbtext.c
> index b5d4750..bf992e4 100644
> --- a/src/xkbte
On Sat, Feb 15, 2014 at 05:35:29PM +0100, Andreas Wettstein wrote:
> ActionMessage has an optional flag genKeyEvent. This change makes sure this
> flag is printed when it is set.
>
> Signed-off-by: Andreas Wettstein
Reviewed-By: Ran Benita
Ran
> ---
> src/xkbtext.c | 2 ++
>
> Signed-off-by: Andreas Wettstein
Thanks for respinning.
Reviewed-By: Ran Benita
Ran
> ---
> action.c | 52 +---
> 1 file changed, 37 insertions(+), 15 deletions(-)
>
> diff --git a/action.c b/action.c
> index 4623c0c..dd89a
Andreas Wettstein
This duplication with xkbfile really sucks..
Reviewed-By: Ran Benita
> ---
> xkb/xkbtext.c | 48 ++--
> 1 file changed, 46 insertions(+), 2 deletions(-)
>
> diff --git a/xkb/xkbtext.c b/xkb/xkbtext.c
> index fd
On Sat, Feb 15, 2014 at 05:36:35PM +0100, Andreas Wettstein wrote:
> ActionMessage has an optional flag genKeyEvent. This change makes sure this
> flag is printed when it is set.
>
> Signed-off-by: Andreas Wettstein
Reviewed-By: Ran Benita
> ---
> xkb/xkbtext.c | 2 ++
&g
On Sat, Feb 15, 2014 at 05:37:08PM +0100, Andreas Wettstein wrote:
> The XKB protocol specification demands support for these flags.
>
> Signed-off-by: Andreas Wettstein
> ---
> xkb/xkbActions.c | 14 +++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/xkb/xkbActi
On Sat, Feb 15, 2014 at 05:36:51PM +0100, Andreas Wettstein wrote:
> The autorepeat for these actions was not correctly implemented, as the key
> repeat would be mistakenly interpreted as key releases. Rather than fixing
> this, this change simply disables autorepeat for Set/Lock actions, for two
On Sun, Feb 16, 2014 at 07:53:33PM -0500, James Cloos wrote:
> >>>>> "RB" == Ran Benita writes:
>
> RB> But the grammar in the parser and the implementation say:
> RB> ESCAPED_CHAR ::= ('\\' | '\"' | OCTAL | HEX )
> RB&g
#x27;t
lock the ctrls, it actually *toggles* them (I don't really understand
why though).
Anyway, though a bit hard to see, this change covers all bases
correctly according to the spec, and the below hunks are good as well,
so:
Reviewed-By: Ran Benita
Thanks,
Ran
> filte
On Sun, Feb 23, 2014 at 07:58:27AM +0600, An-Najmus Saqib wrote:
> Dear Xorg Volunteers,
>
> I use a third-party software for Bengali typing in Windows named Avro
> Keyboard. It provides a graphical keyboard layout editor (only in
> windows-version, linux version supports only phonetic bengali typ
1 - 100 of 108 matches
Mail list logo
