Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
On Fri, Apr 29, 2016 at 5:31 PM Julien Cristau wrote: > On Fri, Apr 29, 2016 at 15:25:40 +0000, Robert Ancell wrote: > > > On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote: > > > > Your footnotes seem to have gone missing. > > > > > > > Not sure

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
On Fri, Apr 29, 2016 at 4:47 PM Adam Jackson wrote: > On Fri, 2016-04-29 at 11:11 +0200, Robert Ancell wrote: > > This is currently used in Ubuntu to allow X applications and sessions to > run in > > newer versions of Unity 8. For example, this allows applications like &g

Re: [PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
The following email with the patch is just over 100k in size and thus is stuck in the moderation queue.. On Fri, Apr 29, 2016 at 11:11 AM Robert Ancell wrote: > This is currently used in Ubuntu to allow X applications and sessions to > run in > newer versions of Unity 8. For exam

[PATCH xserver] Xmir DDX

2016-04-29 Thread Robert Ancell
used in Ubuntu contains more changes (developed on Launchpad [3]) that are unlikely to be of sufficient quality for proposal upstream. We will propose those changes when they are ready. Thanks, --Robert Robert Ancell (1): XMir DDX configure.ac| 24 + hw/Makefile.am

[PATCH xf86-video-intel] uxa: Add missing const to string to stop compiler warning

2015-10-01 Thread Robert Ancell
--- src/uxa/intel_hwmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/uxa/intel_hwmc.c b/src/uxa/intel_hwmc.c index 829cb8e..7854060 100644 --- a/src/uxa/intel_hwmc.c +++ b/src/uxa/intel_hwmc.c @@ -193,7 +193,7 @@ Bool intel_xvmc_adaptor_init(ScreenPtr pScreen) i

Re: [PATCH] Stop accessing the attribute array using the attribute name enum.

2015-09-29 Thread Robert Ancell
e why the other architectures don't pick this up. --Robert On Wed, Sep 30, 2015 at 5:02 PM Robert Ancell wrote: > The array has only two elements but the clamping code was assuming it > contained > all the elements in order. This means no clamping is now done but at least > it >

[PATCH] Stop accessing the attribute array using the attribute name enum.

2015-09-29 Thread Robert Ancell
The array has only two elements but the clamping code was assuming it contained all the elements in order. This means no clamping is now done but at least it wont read off the end of the array. Signed-off-by: Robert Ancell --- src/smi_video.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 3/3] Remove non-existant dst-x, dst-y fields from CompositeGlyphs* requests

2015-09-09 Thread Robert Ancell
Signed-off-by: Robert Ancell --- renderproto.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/renderproto.txt b/renderproto.txt index 14ff15d..c349e03 100644 --- a/renderproto.txt +++ b/renderproto.txt @@ -986,7 +986,6 @@ CompositeGlyphs32 mask-format

[PATCH] modesetting: Use correct datatypes for return values from glamor_name_from_pixmap and glamor_fd_from_pixmap

2015-07-15 Thread Robert Ancell
glamor_name_from_pixmap and glamor_fd_from_pixmap return CARD16 and CARD32 values via pointers. The current code uses uint16_t and uint32_t which will probably be the same but it's safer to use the datatypes as specified by the function. Signed-off-by: Robert Ancell --- hw/xfree86/dr

[PATCH] randrproto: remove duplicate definition of Atom type

2015-07-12 Thread Robert Ancell
The Atom type was defined a second time with the 1.5 changes. It was already previously defined to be a CARD32. Signed-off-by: Robert Ancell --- randrproto.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/randrproto.h b/randrproto.h index 114a624..48be7aa 100644 --- a/randrproto.h +++ b

[PATCH] xwayland: Fix error strings

2015-05-05 Thread Robert Ancell
Fix missing newlines from error string and fix grammar. Signed-off-by: Robert Ancell --- hw/xwayland/xwayland-glamor.c | 4 ++-- hw/xwayland/xwayland-input.c | 2 +- hw/xwayland/xwayland-output.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/xwayland/xwayland

Re: [PATCH] render: Don't generate invalid pixman format when using a 24bpp framebuffer with a 32bit depth visual.

2014-08-22 Thread Robert Ancell
Thanks for the reviews and finding the right place to fix this. --Robert On Fri, Aug 22, 2014 at 5:20 PM, Takashi Iwai wrote: > At Thu, 21 Aug 2014 20:13:48 -0500, > Keith Packard wrote: >> >> Takashi Iwai writes: >> >> >> > Meanwhile, fbCreatePixmap() has a more check and it creates with 24bpp

Re: [PATCH] fb: Correctly implement CopyArea when using a window with depth 32 and 24bpp.

2014-06-06 Thread Robert Ancell
ml On Fri, Jun 6, 2014 at 11:52 PM, Robert Ancell wrote: > When using the fb backend at 24bpp it allows a visual with 32 bit depth. > When using CopyArea from a 32bpp pixmap to a window with a 32 bit depth it > would > read the ARGB as RGB. > > Fix is to correctly ignore the alph

[PATCH] fb: Correctly implement CopyArea when using a window with depth 32 and 24bpp.

2014-06-06 Thread Robert Ancell
When using the fb backend at 24bpp it allows a visual with 32 bit depth. When using CopyArea from a 32bpp pixmap to a window with a 32 bit depth it would read the ARGB as RGB. Fix is to correctly ignore the alpha channel in the pixmap when copying. --- fb/fbcopy.c | 10 +- 1 file changed,

Re: [PATCH] render: Don't generate invalid pixman format when using a 24bpp framebuffer with a 32bit depth visual.

2014-06-05 Thread Robert Ancell
as to the causes of this are greatly appreciated. Attached is a program that doesn't render on the current master and does with the applied patch. --Robert On Fri, Jun 6, 2014 at 4:36 PM, Robert Ancell wrote: > When using the fb backend at 24bpp it allows a visual with 32 bit depth. >

[PATCH] render: Don't generate invalid pixman format when using a 24bpp framebuffer with a 32bit depth visual.

2014-06-05 Thread Robert Ancell
When using the fb backend at 24bpp it allows a visual with 32 bit depth. This would cause RENDER to try and create an invalid pixman buffer and hit the following assertion when trying to render to it: *** BUG *** In create_bits_image_internal: The expression PIXMAN_FORMAT_BPP (format) >= PIXMAN_F

[PATCH] dri2proto: Fix fields in SwapBuffers

2014-05-25 Thread Robert Ancell
Fix errors in SwapBuffers: - The section in "8. Extension Requests" was missing the target_msc, divisor and remainder fields - The section in "A.2 Protocol Requests" had two entries for SwapBuffers, both incorrect --- dri2proto.txt | 30 ++ 1 file changed, 6 insertion

Re: [PATCH] Fix overflow checking extension versions

2014-05-22 Thread Robert Ancell
4294967295.4294967295. [1] http://cgit.freedesktop.org/xorg/proto/randrproto/tree/randrproto.txt On Fri, May 23, 2014 at 1:05 PM, Keith Packard wrote: > Robert Ancell writes: > >> The easiest way to check for the version of an extension is to send the >> maximum >> possible version num

[PATCH] Fix overflow checking extension versions

2014-05-21 Thread Robert Ancell
The easiest way to check for the version of an extension is to send the maximum possible version numbers in the QueryVersion request. The X server overflows on these as it assumes you will send a reasonable version number. --- include/misc.h | 18 +++--- 1 file changed, 11 insertions(+

[PATCH 2/2] Document QueryFilters

2014-05-20 Thread Robert Ancell
QueryFilters had no documentation. Document it, in particular how to interpret the 'aliases' field. --- renderproto.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/renderproto.txt b/renderproto.txt index 74fb411..14ff15d 100644 --- a/renderproto.txt +++ b/renderproto

[PATCH] Correct QueryPictFormats reply fields.

2014-05-20 Thread Robert Ancell
The QueryPictFormats reply referred to a fallback which does not exist and didn't document the ndepths and nvisuals fields. --- renderproto.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/renderproto.txt b/renderproto.txt index 9f1f231..74fb411 100644 --- a/renderpr

[PATCH] os: Add -displayfd into -help text

2014-04-22 Thread Robert Ancell
Add -displayfd into -help text. It was mentioned in the man page but seem to have been missed from the -help text. --- os/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/os/utils.c b/os/utils.c index 60e828e..1555dbd 100644 --- a/os/utils.c +++ b/os/utils.c @@ -501,6 +501,7 @@ UseMsg(

Re: [PATCH] os: Add -displayfd into -help text

2014-04-22 Thread Robert Ancell
Shall I resend it? I think I have set git send-email up correctly now. On Tue, Apr 22, 2014 at 5:17 PM, Keith Packard wrote: > Robert Ancell writes: > >> ErrorF("-cc intdefault color visual class\n"); >> ErrorF("-nocursor

[PATCH] os: Add -displayfd into -help text

2014-04-06 Thread Robert Ancell
Add -displayfd into -help text. It was mentioned in the man page but seem to have been missed from the -help text. --- os/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/os/utils.c b/os/utils.c index 60e828e..1555dbd 100644 --- a/os/utils.c +++ b/os/utils.c @@ -501,6 +501,7 @@ UseMsg(v

Re: LightDM

2010-08-16 Thread Robert Ancell
On 16 August 2010 18:15, Matthieu Herrb wrote: > Could change the license in favor of the MIT license ? > There are serveral projects (including the BSDs) using X.Org that will > not accept GPLv3 code in their base system. I hadn't considered this, thanks. My preference is to use a copyleft lic

LightDM

2010-08-16 Thread Robert Ancell
that has occurred post XDM. I'm interested in both technical feedback and how I can more closely align this project with freedesktop.org. Thanks, --Robert Ancell [1] https://launchpad.net/lightdm ___ xorg-devel@lists.x.org: X.Org development Arc