Re: [PATCH xserver 1/4] animcur: Use fixed-size screen private

2017-11-12 Thread Robert Morell
(*pScreen->CloseScreen) (pScreen); > free(as); The free() above should be removed as well, otherwise it causes a double-free on screen teardown. Other than that, Reviewed-by: Robert Morell <rmor...@nvidia.com> Tested-by: Robert Morell <rmor...@nvidia.com> for the series. T

[PATCH xts] XStoreColors?: Fix transient display leak

2015-02-05 Thread Robert Morell
On a system with many visuals, leaving the display connections open until test cleanup can cause the test to fail when the server reaches MAX_CLIENTS simultaneous connections. Signed-off-by: Robert Morell rmor...@nvidia.com --- xts5/Xlib7/XStoreColor.m | 10 +- xts5/Xlib7/XStoreColors.m

Re: Large coordinates in the X server

2014-12-12 Thread Robert Morell
On Fri, Dec 12, 2014 at 08:43:33AM -0800, Keith Packard wrote: * PGP Signed by an unknown key Robert Morell rmor...@nvidia.com writes: b) Change the X server's DDXPointRec type from 2xINT16 to 2xINT32; Convert 16-bit values from the protocol to 32-bit values as soon as we get them

Re: Large coordinates in the X server

2014-12-12 Thread Robert Morell
On Fri, Dec 12, 2014 at 04:40:24PM -0800, Keith Packard wrote: * PGP Signed by an unknown key Robert Morell rmor...@nvidia.com writes: Hmm, I guess that depends on whether we're already fetching coordinates directly out of the request fresh off the wire, or copying them

Re: Large coordinates in the X server

2014-12-11 Thread Robert Morell
On Fri, Nov 14, 2014 at 08:29:11AM -0800, Robert Morell wrote: Hi, I have been experimenting with root window sizes that meet the coordinate space limits of the X11 protocol -- 32767 for both width and height. Unsurprisingly, this doesn't work as well as one might hope, even for very

Re: [PATCH v2] Add -iglx +iglx to Xserver.man

2014-11-26 Thread Robert Morell
errors. +This is the default unless +iglx is specified. +.TP 8 +.B +iglx +Allow creating indirect GLX contexts. +.TP 8 .B \-maxbigreqsize \fIsize\fP sets the maximum big request to .I size Reviewed-by: James Jones jajo...@nvidia.com Reviewed-by: Robert Morell rmor

Re: [PATCH] Add -iglx +iglx to Xserver.man

2014-11-25 Thread Robert Morell
that future X.Org server releases may make the -iglx option the default. To re-enable support for indirect GLX on such servers, use the +iglx option. But your text above is still accurate, so other than perhaps softening the OpenGL 1.4 limitation, Reviewed-by: Robert Morell rmor

Re: [PATCH] Add -iglx +iglx to Xserver.man

2014-11-25 Thread Robert Morell
On Tue, Nov 25, 2014 at 11:20:58PM -0800, Alan Coopersmith wrote: On 11/25/14 10:36 PM, Robert Morell wrote: On Tue, Nov 25, 2014 at 07:26:14PM -0800, Alan Coopersmith wrote: Covers the current state after commits 99f0365b1fbdfd9238b9f, d0da0e9c3bb8fe0cd4879, e3aa13b8d63ea2fba6eb4 were all

Large coordinates in the X server

2014-11-14 Thread Robert Morell
Hi, I have been experimenting with root window sizes that meet the coordinate space limits of the X11 protocol -- 32767 for both width and height. Unsurprisingly, this doesn't work as well as one might hope, even for very simple tests. One example is 'xlogo'. With a 32767x40 root window,

[PATCH 3/3] randr: Implement RandR 1.4 request swapping

2014-04-18 Thread Robert Morell
The protocol handlers all have support for swapping variable data and replies, but the top-level dispatch plumbing was missing. Signed-off-by: Robert Morell rmor...@nvidia.com --- randr/rrsdispatch.c | 138 1 file changed, 138 insertions

[PATCH 1/3] randr: Fix crash for NULL swap dispatch procs

2014-04-18 Thread Robert Morell
The previous code was checking the wrong table for function pointers. Signed-off-by: Robert Morell rmor...@nvidia.com --- randr/randr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/randr.c b/randr/randr.c index 3c97714d8e1d..6e3f14b4e704 100644 --- a/randr/randr.c

[PATCH 2/3] randr: Fix size checks for SetProvider* reqs

2014-04-18 Thread Robert Morell
Both xRRSetProviderOutputSourceReq and xRRSetProviderOffloadSinkReq are fixed-size requests, so the length on the wire should match exactly. Signed-off-by: Robert Morell rmor...@nvidia.com --- randr/rrprovider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randr

[PATCH rendercheck] fix compiler warnings

2014-01-20 Thread Robert Morell
From: Matt Craighead mcraigh...@nvidia.com Removed redundant declarations. Removed an unused variable. Fixed the sign of some loop variables. Signed-off-by: Matt Craighead mcraigh...@nvidia.com Signed-off-by: Robert Morell rmor...@nvidia.com --- main.c| 3 --- rendercheck.h | 4

[PATCH] os: Reset input buffer's 'ignoreBytes' field

2013-05-09 Thread Robert Morell
' requests. This fixes that behavior by resetting the ignoreBytes field when putting the ConnectionInput buffer back on the FreeInputs list. Signed-off-by: Robert Morell rmor...@nvidia.com --- os/io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/os/io.c b/os/io.c index 2f091c4..0d980ab

[PATCH RESEND] parser: handle negative numbers properly

2013-04-01 Thread Robert Morell
Numbers beginning with '-' were falling into the DASH category. This also caused a confusing error message, since no terminating NUL character was added to configRBuf -- old garbage in the string would be printed. This fixes the terminating NUL for COMMA as well. Signed-off-by: Robert Morell

Re: [PATCH xf86-video-nv] Include xf86Modes.h to use functions from hw/xfree86/modes/xf86Modes.c.

2013-03-21 Thread Robert Morell
On Thu, Mar 21, 2013 at 08:59:06AM -0700, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com Reviewed-by: Robert Morell rmor...@nvidia.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH xf86-video-savage] Include xf86Modes.h to use functions from hw/xfree86/modes/xf86Modes.c.

2013-03-21 Thread Robert Morell
On Thu, Mar 21, 2013 at 08:59:13AM -0700, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com Reviewed-by: Robert Morell rmor...@nvidia.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH xserver] Define prototypes for hw/xfree86/modes/xf86Modes.c only in xf86Modes.h.

2013-03-21 Thread Robert Morell
|1 + hw/xfree86/utils/cvt/Makefile.am |1 + hw/xfree86/utils/cvt/cvt.c|1 + hw/xfree86/vbe/Makefile.am|1 + hw/xfree86/vbe/vbe.c |1 + 12 files changed, 12 insertions(+), 28 deletions(-) Reviewed-by: Robert Morell rmor

[PATCH] configure.ac: Require inputproto 2.3

2013-03-12 Thread Robert Morell
This picks up support for Xi pointer barriers in the protocol. Signed-off-by: Robert Morell rmor...@nvidia.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6e1ff65..44982b3 100644 --- a/configure.ac +++ b/configure.ac

[PATCH] list.h: Make xorg_list_init inline

2013-03-12 Thread Robert Morell
Otherwise this file is emitted in every unit that includes it. Signed-off-by: Robert Morell rmor...@nvidia.com --- This reduces the size of a debug Xorg binary on my system by just under 1%. include/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/list.h b

Re: [PATCH 1/3] kdrive: fix set but not used warnings

2013-03-05 Thread Robert Morell
On Tue, Mar 05, 2013 at 03:03:34PM -0800, Peter Hutterer wrote: ping - anyone? Reviewed-by: Robert Morell rmor...@nvidia.com for patches 1 and 2. 3 seems to do as you say, but I'm not all that familiar with XI2 grabs. - Robert ___ xorg-devel

[PATCH] parser: handle negative numbers properly

2013-02-21 Thread Robert Morell
Numbers beginning with '-' were falling into the DASH category. This also caused a confusing error message, since no terminating NUL character was added to configRBuf -- old garbage in the string would be printed. This fixes the terminating NUL for COMMA as well. Signed-off-by: Robert Morell

xf86InterpretEDID() and the EDID blob

2011-07-26 Thread Robert Morell
I noticed recently (the hard way) that the data pointed to by the block parameter of xf86InterpretEDID() is simply assigned to xf86MonRc::rawData verbatim, referencing the block of memory passed in directly. It is never freed through the xf86MonRec as far as I can tell, although the xf86MonRec

Re: [PATCH 0/2] RENDER: Fix gradient and solid fill pictures with Xinerama, and misc cleanup

2010-01-29 Thread Robert Morell
If these aren't wrapped, then procs that are wrapped (such as RenderChangePicture) will fail in Xinerama when they see the resource type of a picture created through one of these interfaces is PictureType and not XRT_PICTURE like those allocated via RenderCreatePicture. Signed-off-by: Robert

Re: [PATCH 0/2] RENDER: Fix gradient and solid fill pictures with Xinerama, and misc cleanup

2010-01-29 Thread Robert Morell
If these aren't wrapped, then procs that are wrapped (such as RenderChangePicture) will fail in Xinerama when they see the resource type of a picture created through one of these interfaces is PictureType and not XRT_PICTURE like those allocated via RenderCreatePicture. --- On Fri, Jan 29, 2010

[PATCH 2/2] [RENDER] Add panoramiX wrappers for gradients and solid fills

2010-01-21 Thread Robert Morell
If these aren't wrapped, then procs that are wrapped (such as RenderChangePicture) will fail in Xinerama when they see the resource type of a picture created through one of these interfaces is PictureType and not XRT_PICTURE like those allocated via RenderCreatePicture. Signed-off-by: Robert

[PATCH 0/2] RENDER: Fix gradient and solid fill pictures with Xinerama, and misc cleanup

2010-01-21 Thread Robert Morell
for Xinerama. Robert Morell (2): [RENDER] Fix request size verification [RENDER] Add panoramiX wrappers for gradients and solid fills render/render.c | 141 ++- 1 files changed, 139 insertions(+), 2 deletions

[PATCH 1/2] [RENDER] Fix request size verification

2010-01-21 Thread Robert Morell
Some requests used the wrong types. Signed-off-by: Robert Morell rmor...@nvidia.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- render/render.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/render/render.c b/render/render.c index 77e5e03..575bd9f 100644