Re: glamor-egl, parameter checking

2013-10-08 Thread Seth Arnold
On Tue, Oct 08, 2013 at 04:22:30PM +0800, Zhigang Gong wrote: > This function is to draw lines with at lest two points. So n = 1 is not a > realisitic input. Hello, welcome back from your time off. Thanks so much for giving my comments a look, I appreciate the time you've put into it. Thanks, Se

glamor-egl, parameter checking

2013-09-26 Thread Seth Arnold
Hello, I recently gave glamor-egl a very quick audit, and found some issues that I wanted to run past someone who would know the code better than I do. - _glamor_poly_lines(): - unchecked malloc() return value - if n = 1 is passed to the function, the malloc might allocate zero bytes: