Re: [PATCH 2/2] xfree86: dri2: free variable properly if code fails

2010-06-30 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 29, 2010 at 06:55:02PM +0200, ext Michel Dänzer wrote: On Die, 2010-06-29 at 19:00 +0300, Tiago Vignatti wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Same as the previous patch: I'm not exactly seeing any problem or segfault with this code. I just got

Re: [PATCH 1/2] xfree86: dri2: check for drawable value

2010-06-30 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 29, 2010 at 06:52:18PM +0200, ext Michel Dänzer wrote: On Die, 2010-06-29 at 19:00 +0300, Tiago Vignatti wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- I'm not exactly seeing any problem or segfault with this code. I just got this issue with the static

Re: [PATCH v4 3/3] xfree86: remove board and vendor identifier strings from the configuration path

2010-06-30 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Wed, Jun 30, 2010 at 03:30:03PM +0200, ext Dan Nicholson wrote: On Wed, Jun 30, 2010 at 6:07 AM, Vignatti Tiago (Nokia-D/Helsinki) I'd say to push the first and second of this set to 1.9, given their importance. This third one concerns more clean up, so I'll work a bit more, squash

Re: [PATCH v3 3/3] xfree86: remove board and vendor identifier strings from the configuration path

2010-06-28 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, Jun 24, 2010 at 08:07:07AM +0200, ext Keith Packard wrote: On Wed, 23 Jun 2010 16:24:29 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: ABI break. Doesn't this also break anhy config files that include vendorname or boardname elements? yes, it does. Do you think is it a

Re: [PATCH] XWin: Fix for static libXfont use

2010-06-28 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, Jun 28, 2010 at 01:36:31PM +0200, ext Julien Cristau wrote: On Mon, Jun 28, 2010 at 14:20:51 +0300, Tiago Vignatti wrote: On Mon, Jun 28, 2010 at 12:48:53PM +0200, ext Colin Harrison wrote: Hi, All XWin DDX builds use libXfont built static. The following libXfont patch is

Re: [PATCH v3 1/2] dix: use one single function to register fpe fonts

2010-06-23 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 22, 2010 at 08:30:41PM +0200, ext Keith Packard wrote: On Sat, 19 Jun 2010 14:02:02 +0300, Vignatti Tiago (Nokia-D/Helsinki) tiago.vigna...@nokia.com wrote: ping? Yeah, this all seems reasonable. But, as I'm trying to get release candidates made frequently, and those can't

Re: [PATCH v2] xfree86: configure: remove vendor and card name matching rules

2010-06-22 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Sat, Jun 19, 2010 at 12:05:22PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: Although vendor and board naming are used to create the configure file, the server doesn't actually use it when fetching such file and probing devices. Reported-by: Richard Barnette jrbarne...@chromium.org

Re: Post-RC1 merging criteria (was Re: [PULL] cleanups)

2010-06-22 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Tue, Jun 22, 2010 at 04:21:42AM +0200, ext Keith Packard wrote: On Mon, 21 Jun 2010 16:04:51 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: The problem is that people are creating patches but they got lost somewhere and/or take so many time to go upstream. Am I still

Re: [PATCH v3 1/2] dix: use one single function to register fpe fonts

2010-06-19 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Wed, Jun 16, 2010 at 05:52:23PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: X server doesn't need to understand fpe internals, so use register_fpe_functions from libXfont. It's required to get new version of libXfont, therefore adjust it to be passed to autoconf. Signed-off

Re: [PATCH v3 1/2] dix: use one single function to register fpe fonts

2010-06-19 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Sat, Jun 19, 2010 at 05:34:52PM +0200, ext Dan Nicholson wrote: On Wed, Jun 16, 2010 at 8:52 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: X server doesn't need to understand fpe internals, so use register_fpe_functions from libXfont. It's required to get new version of libXfont,

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, Jun 14, 2010 at 05:48:54PM +0200, ext Kristian Høgsberg wrote: 2010/6/14 Vignatti Tiago (Nokia-D/Helsinki) tiago.vigna...@nokia.com: I think open coded list implementation everywhere is more error prone than just have one single set of basic macros. Isn't it? All the open coded

Re: Performance improvement to vga arbitration

2010-06-14 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi Henry, On Sat, Jun 12, 2010 at 04:38:14AM +0200, ext Henry Zhao wrote: On 06/11/10 04:56, Tiago Vignatti wrote: http://people.freedesktop.org/~vignatti/tmp/0001-xfree86-vgaarb-disable-VGA-decoding-after-POST.patch At this point on the X server, we already POSTed all cards and we

Re: [PATCH] dix: fix NULL pointer dereferenced in memset

2010-06-12 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hey Jamey, On Sat, Jun 12, 2010 at 05:23:09PM +0200, ext Jamey Sharp wrote: On Sat, Jun 12, 2010 at 7:39 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Apparently memset doesn't complain if the memory area is null (addr) and something is being written there. Even though, this patch

Re: [PATCH 1/2 v2] Use one single function to register fpe functions

2010-06-11 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, Jun 11, 2010 at 02:35:23PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: X server doesn't need to understand fpe internals, so let it transparent turning all registration functions in a single one. For that, fill the already existent register_fpe_functions(). Some X servers don't

Re: Input thread on EVoC

2010-06-09 Thread Vignatti Tiago (Nokia-D/Helsinki)
Oi, On Wed, Jun 09, 2010 at 02:37:22AM +0200, ext Fernando Carrijo wrote: Tiago Vignatti tiago.vigna...@nokia.com wrote: it's not that straightforward given, as the guys said already, X event dequeuing is very tied with clients and the server may spend considerable amount of time doing

Re: [PATCHv2 0/6] fbdevhw cleanup and pciaccess free

2010-06-03 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Tue, Jun 01, 2010 at 02:22:29PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: Here's some trivial cleanup of the fbdevhw module. Just like my last patch series I sent to the list, this one also removes PCI related symbols from a given module - fbdevhw in this case - and puts

Re: [PATCH resent 0/5] xfree86: vgaarb: clean up and device hidden

2010-06-03 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Thu, Jun 03, 2010 at 11:29:46AM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Is it just me or are others also utterly confused by Tiago's diffs? Let me explain what I mean: Tiago Vignatti (5): xfree86: vgaarb: change macros by inline functions

Re: [PATCH 4/5] xfree86: vgaarb: fix device decoding interface to send resources type properly

2010-06-03 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, Jun 03, 2010 at 11:42:18AM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Date: Thu, 3 Jun 2010 11:34:13 +0300 Right now, when there is more than one vide card on the machine, we're adopting a pessimistic approach and setting all cards to decode

Re: more MAXSCREENS patches

2010-06-03 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Wed, Jun 02, 2010 at 08:15:30PM +0200, ext Jamey Sharp wrote: So, yes. I think I'd like to see the xfree86 DDX made usable on all platforms that have active maintainers; in parallel, factor out common code between Xvfb/Xfake/dummy and between Xnest/Xephyr/Xdmx; and finally, unify

Re: [PATCH] xfree86: Unbreak autoconfig following 0abf065e38c4

2010-06-02 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, May 27, 2010 at 02:26:23PM +0200, ext Chris Wilson wrote: The move of the PCI device id probing into a separate file neglected to return the number of found devices, and so the PCI devices were being overwritten by the default entries for vesa and fbdev. Signed-off-by: Chris Wilson

Re: [PATCH] Install fbdevhw.so in the correct os-specific path

2010-06-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 01, 2010 at 03:17:26AM +0200, ext Alan Coopersmith wrote: Only if you're ready to say f*** you to people with out of tree drivers, whether closed source like nvidia ati, open source like openchrome Virtual Box, or just plain confused like Poulsbo. I'm not and since my

Re: [PATCHv2 6/6] xfree86: fbdevhw: remove all pci symbols from the module

2010-06-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 01, 2010 at 04:54:26PM +0200, ext Alan Coopersmith wrote: Tiago Vignatti wrote: xf86PciOpenFbDev was created and put inside its proper file. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Mark and Alan: I hope this is okay for you now? I can live with that,

Re: [PATCH 08/14] xfree86: delete useless Primary device is not PCI message

2010-06-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 01, 2010 at 05:30:14PM +0200, ext Daniel Stone wrote: On Tue, Jun 01, 2010 at 05:59:04PM +0300, Tiago Vignatti wrote: It's not PCI? So what?! Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86pciBus.c |6 -- 1 files changed, 0

Re: [PATCH 08/14] xfree86: delete useless Primary device is not PCI message

2010-06-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 01, 2010 at 06:29:28PM +0200, ext Tomas Carnecky wrote: On 6/1/10 4:59 PM, Tiago Vignatti wrote: It's not PCI? So what?! Signed-off-by: Tiago Vignattitiago.vigna...@nokia.com --- hw/xfree86/common/xf86pciBus.c |6 -- 1 files changed, 0 insertions(+), 6

Re: [PATCH 06/14] xfree86: bus: move macros from common PCI header to private file

2010-06-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Tue, Jun 01, 2010 at 05:43:10PM +0200, ext Mark Kettenis wrote: I really, really don't see the point if this diff, and a lot of others you're sending. Yes, this is only used in the int10 module at this moment. But obviously Pci.h is the right place for these macros. It seems to me

Re: [PATCH 12/14] xfree86: IOADDRESS is PCIism and shouldn't be used by common header files

2010-06-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jun 01, 2010 at 05:50:17PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Date: Tue, 1 Jun 2010 17:59:08 +0300 This change does not make it easier to understand the code. Imagine someone looking at it after you apply this diff. What is the meaning

Re: [PATCH] Install fbdevhw.so in the correct os-specific path

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Sun, May 30, 2010 at 11:57:04PM +0200, ext Alan Coopersmith wrote: I also don't know any reason not to move it out of the OS-specific libdir and up to the generic modules directory, now that all modules there use the OS'es actual libc system calls instead of the libcwrappers. exactly.

Re: [PATCH 5/6] xfree86: fbdevhw: remove secondary way to find fb PCI device

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, May 31, 2010 at 03:58:46PM +0200, ext Michel Dänzer wrote: On Mon, 2010-05-31 at 16:16 +0300, Tiago Vignatti wrote: fbdevhw already relies in libpciaccess, which in turn relies in sysfs to probe devices. If sysfs is reporting wrong values then we're doomed anyway. So we totally

Re: [PATCH 0/6] fbdevhw cleanup and pciaccess free

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, May 31, 2010 at 04:29:11PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com [0] I'm wondering if it doesn't make sense for someone to free modules from PCI code? For me it's pretty clear but I'll explain the machiavellian plan anyway in the next

Re: [PATCH 5/6] xfree86: fbdevhw: remove secondary way to find fb PCI device

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, May 31, 2010 at 04:36:51PM +0200, ext Michel Dänzer wrote: On Mon, 2010-05-31 at 17:10 +0300, Vignatti Tiago (Nokia-D/Helsinki) wrote: On Mon, May 31, 2010 at 03:58:46PM +0200, ext Michel Dänzer wrote: On Mon, 2010-05-31 at 16:16 +0300, Tiago Vignatti wrote: fbdevhw already

Re: [PATCH 2/6] xfree86: fbdevhw: remove superfluous debug code

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, May 31, 2010 at 04:24:27PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Date: Mon, 31 May 2010 16:16:52 +0300 Rarely one would want to print all functions of a given file when debugging. If this is the case, then a mix of ctags + cpp + gdb

Re: [PATCH 0/6] fbdevhw cleanup and pciaccess free

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, May 31, 2010 at 05:04:37PM +0200, ext Mark Kettenis wrote: Date: Mon, 31 May 2010 17:42:51 +0300 From: Vignatti Tiago (Nokia-D/Helsinki) tiago.vigna...@nokia.com On Mon, May 31, 2010 at 04:29:11PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com

Re: [PATCH 5/6] xfree86: fbdevhw: remove secondary way to find fb PCI device

2010-05-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, May 31, 2010 at 05:03:56PM +0200, ext Michel Dänzer wrote: sysfs didn't appear in its current form instantly but in evolutionary steps. AFAIR the files above (which with your change are required for the matching to work) were added relatively recently, and it might be possible for

Re: [PATCH] xfree86: Unbreak autoconfig following 0abf065e38c4

2010-05-27 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi Chris, On Wed, May 26, 2010 at 09:44:51PM +0200, ext Chris Wilson wrote: The move of the PCI device id probing into a separate file neglected to return the number of found devices, and so the PCI devices were being overwritten by the default entries for vesa and fbdev. Signed-off-by:

Re: State of the 1.9 release

2010-05-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Thu, May 20, 2010 at 05:02:15PM +0200, ext Keith Packard wrote: git://people.freedesktop.org/~keithp/xserver fix-private-usage I see that you're registering some structures that are used only in xfree86 ddx using dix devPrivates. But for this ddx seems we have a similar mechanism to of

Re: [PATCH 04/11] xfree86: bus: remove superfluous and confused structures in BusRec

2010-05-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 21, 2010 at 04:40:59PM +0200, ext Keith Packard wrote: On Fri, 21 May 2010 14:43:17 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: Although API is break, luckily any drivers right now is using such monster. diff --git a/hw/xfree86/common/xf86str.h

Re: [PATCH 03/11] xfree86: bus: move IOADDRESS definition to a common header file

2010-05-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 21, 2010 at 04:21:26PM +0200, ext Alan Coopersmith wrote: Tiago Vignatti wrote: IOADDRESS type definition encompass more than just pci code, so move it to common. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86str.h |1 +

Re: [PATCH 03/11] xfree86: bus: move IOADDRESS definition to a common header file

2010-05-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 21, 2010 at 04:55:23PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Date: Fri, 21 May 2010 14:43:16 +0300 IOADDRESS type definition encompass more than just pci code, so move it to common. diff --git a/hw/xfree86/os-support/bus/xf86Pci.h

Re: [PATCH resent] configure: introduce --{enable, disable}-fontserver

2010-05-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 21, 2010 at 04:54:01PM +0200, ext Keith Packard wrote: On Wed, 5 May 2010 17:14:41 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: Keith, no one took this one. Care to pull it? I though I had replied suggesting that this should depend on what support was provided in

Re: [PATCH 1/2] xfree86: vgaarb: simplify the arguments passed to lock/unlock

2010-05-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 21, 2010 at 06:43:11PM +0200, ext Keith Packard wrote: On Fri, 21 May 2010 18:48:14 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: Send only screen index instead the whole rec for lock and remove the argument of unlock. nak -- the arbiter presumably needs to run

Re: multi-card breakage

2010-05-19 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi Pierre, On Tue, May 04, 2010 at 10:21:55PM +0200, ext Pierre-Loup A. Griffais wrote: I just reproduced something that sounds like what you're describing with two R520 cards (one X screen per card) and the 'radeon' driver. However, it seems unrelated to my change; that's what the hang

Re: [PATCH 00/10 v2] Clean up and reorganize BUS configuration code

2010-05-07 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 07, 2010 at 02:43:55PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: Tiago Vignatti (10): xfree86: remove unused xf86AccessInit() xfree86: bus: fix Enter/Leave accesses behaviour xfree86: bus: reuse already assigned variable when fb driver claimed xfree86: bus: rework

Re: [PATCH 10/10] xfree86: remove PCI dependency from InitOutput

2010-05-07 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 07, 2010 at 04:39:40PM +0200, ext Adam Jackson wrote: On Fri, 2010-05-07 at 15:44 +0300, Tiago Vignatti wrote: +Bool +xf86CallDriverProbe( DriverPtr drv, Bool detect_only ) +{ +Bool foundScreen = FALSE; + +if ( drv-PciProbe != NULL ) { +if (

Re: [PATCH 08/10] xfree86: bus: remove SetSIGIOForState and simplify the code

2010-05-07 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, May 07, 2010 at 04:32:32PM +0200, ext Adam Jackson wrote: On Fri, 2010-05-07 at 15:44 +0300, Tiago Vignatti wrote: + /* + * This is a good place to block SIGIO during SETUP state. SIGIO should be +* blocked in SETUP state otherwise (u)sleep() might get interrupted +

Re: [PATCH 09/10] xfree86: remove xf86EnableAccess

2010-05-06 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, May 06, 2010 at 09:58:25AM +0200, ext Mark Kettenis wrote: From: Keith Packard kei...@keithp.com Date: Wed, 05 May 2010 20:21:29 -0700 On Wed, 5 May 2010 23:57:00 +0200 (CEST), Mark Kettenis mark.kette...@xs4all.nl wrote: You can probabaly use a version smaller than 9 as

Re: [PULL] MAXSCREENS removal preparation

2010-04-26 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, Apr 26, 2010 at 05:48:54PM +0200, ext Keith Packard wrote: One thing I'm working on in parallel is to fix the devPrivates implementation in the server so that adding a bunch of screen privates won't impact memory usage. Right now, every screen private we add increases the size of

Re: [PATCH 3/2] Track screens' installed colormaps as screen privates.

2010-04-23 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hey Jamey, On Fri, Apr 23, 2010 at 07:02:54AM +0200, ext Jamey Sharp wrote: On Thu, Apr 22, 2010 at 10:42 AM, Vignatti Tiago (Nokia-D/Helsinki) If we get cooked this and target to apply this before 1.9 merge window be closed, so why bother? Even though, I removed this commentary from

Re: [PATCH 3/2] Track screens' installed colormaps as screen privates.

2010-04-22 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, Apr 22, 2010 at 07:07:58PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: On Thu, Apr 22, 2010 at 07:34:04AM +0200, ext Jamey Sharp wrote: mi/micmap.c has the same pattern, except there the miInstalledMaps array is used in the xfree86 DDX, and I guess it's part of the server's ABI

Re: [PATCH v3 3/4] xfree86/dri2: wrap drm bits with macros and change drm_magic type

2010-04-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Wed, Apr 21, 2010 at 03:00:52PM +0200, ext Mark Kettenis wrote: So instead you decide to increase the maintenance burden on everybody else by making the code harder to read and requiring them to remember to wrap new code that depends on libdrm in more #ifdefs. As I said, it's a trade-off.

Re: [PATCH] xfree86: fix not reached code in tty code

2010-04-21 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Wed, Apr 21, 2010 at 12:19:07AM +0200, ext Peter Hutterer wrote: stack the reviewed patches into a for-keith branch, push them to your $HOME on people.freedesktop.org and then send Keith a pull request. what I usually do is 'git request-pull master

Re: [RFC] Make MAXSCREENS run-time configurable

2010-04-06 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, Apr 01, 2010 at 09:47:35PM +0200, ext Kevin E Martin wrote: On Thu, Apr 01, 2010 at 07:19:11PM +0300, Tiago Vignatti wrote: Allows MAXSCREENS to be determined at run time instead of compile time, adding a new -maxscreens command line flag. *** Attention ABI broken everywhere!

Re: [PATCH xextproto] Death to Multibuffer extension

2010-03-31 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Mar 30, 2010 at 06:58:28PM +0200, ext Alan Coopersmith wrote: Isn't removing the headers from xextproto going to break the build of libXext older Xservers? (No, you can't delete functions from libXext - we don't break client library ABI like that. This is why we also no longer

Re: [PATCH] configure: set X render animated cursors optional

2009-09-01 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Tue, Sep 01, 2009 at 05:50:36AM +0200, ext Peter Hutterer wrote: IMO, this is the wrong approach and I was a bit surprised to see this after our latest IRC discussion. There are two parts to animated cursors that affect you. 1. The rendering of a cursor takes time and effort. 2.

Re: [PATCH 1/2] mi: fix cursor warping screens

2009-08-08 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, Aug 07, 2009 at 01:58:41AM +0200, Peter Hutterer wrote: How about the patch attached. It ends up being the same logic but the code looks nicer (even though the patch doesn't). Instead of the fallthrough into the default statement, the default block is moved out of the switch. coolio!

Re: [PATCH 1/2] mi: fix cursor warping screens

2009-08-05 Thread Vignatti Tiago (Nokia-D/Helsinki)
Ooops, I messed the script. Well, the email is mine :) On Wed, Aug 05, 2009 at 08:18:55PM +0200, y...@mail.nokia.com wrote: From: Tiago Vignatti tiago.vigna...@nokia.com The server was processing ET_RawMotion type when the cursor was wrapping to another screen and getting wrong valuator

Re: [PATCH] pciaccess: remove xorg macros dependency

2009-07-16 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Thu, Jul 16, 2009 at 02:03:11PM +0200, ext Julien Cristau wrote: On Thu, Jul 16, 2009 at 14:53:47 +0300, Vignatti Tiago (Nokia-D/Helsinki) wrote: On Thu, Jul 16, 2009 at 01:30:22PM +0200, ext Julien Cristau wrote: why? Why pci access library must rely on X server? Who

Re: [RFC][PATCH 3/6] xfree86: delete devices probe code (-probe and -probeonly options)

2009-07-14 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Tue, Jul 14, 2009 at 07:54:19PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Date: Tue, 14 Jul 2009 20:06:40 +0300 In a near future KMS drivers will do all device's configuration inside the kernel. For those that don't want/need/can't do the mode

Re: [RFC][PATCH 0/6] towards the dietary: removing libpciaccess dependency from Xorg

2009-07-14 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hi, On Tue, Jul 14, 2009 at 08:03:35PM +0200, ext Matthias Hopf wrote: On Jul 14, 09 20:06:37 +0300, Tiago Vignatti wrote: (take a breath; this set comes with radical changes) I'm not completely familiar with the code changed, and looked at it only briefly - and it looked like this removes