On Wed, Jul 04, 2018 at 09:59:18PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add a new Xv port attribute XV_COLOR_RANGE to select the incoming YUV
> quantization range. 0 means limited range (Y: 16-235, Cb/Cr: 16-240),
> 1 means full range (0-255).
>
> Cc: x
+gamma_slots = palette_red_size / crtc->gamma_size;
> +for (i = 0; i < crtc->gamma_size; i++) {
> +value = palette[i * gamma_slots].red;
That's not going to reach the max index of the palette, and it'll not
work correctly when the sizes a
; then never destroy, and then to allow Clients to explicit manage their
> references to DRI2Drawables.
>
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
> ---
> glx/glxdri2.c | 10 ++--
> hw/xfree86/dri2/dri2.c| 136
> ++--
> Link: http://lists.x.org/archives/xorg-devel/2010-November/014783.html
> Link: http://lists.x.org/archives/xorg-devel/2010-November/014782.html
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
> ---
> hw/xfree86/dri2/dri2.c| 57
>
so the wait never completes.
>
> Note Present/xshmfence is also suspectible to this race.
>
> Testcase: dri2-race/manager
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
> ---
> hw/xfree86/dri2/dri2.c | 3 +++
> 1 file changed, 3 insertio
gt; Reported-by: Loïc Yhuel
> Link: http://lists.x.org/archives/xorg-devel/2015-February/045638.html
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
Seems sane.
Reviewed-by: Ville Syrjälä
> ---
> hw/xfree86/dri2/dri2.c | 5 ++---
> 1 file changed, 2 insertions(+), 3
how Windows are handled.
>
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
Hmm. found this old nugget in my inbox. Looks sane enough, and
eliminates duplicated code.
Reviewed-by: Ville Syrjälä
BTW as sna doesn't use xf86xv it doesn't appear to check the drawable
type a
On Sat, Feb 21, 2015 at 10:52:49PM +, Chris Wilson wrote:
> On Sun, Feb 22, 2015 at 12:13:38AM +0200, Ville Syrjälä wrote:
> > On Sat, Feb 21, 2015 at 09:31:07PM +, Chris Wilson wrote:
> > > With the current protocol and implementations, we have to often call
> >
f during the
Maemo days. Pauli fixed tons of problems in the dri2 code but some
of the patches never made it in.
These seem somewhat relevant:
http://lists.x.org/archives/xorg-devel/2010-November/014783.html
http://lists.x.org/archives/xorg-devel/2010-November/014782.html
--
Ville Syrjälä
syrj.
On Thu, Jul 31, 2014 at 08:20:20AM -0700, Keith Packard wrote:
> Ville Syrjälä writes:
>
> > Now that we have mmio flips in the kernel we can start to relax that
> > restriction. That still needs a bit more work in the mmio flip code
> > but I believe some people work
t;
> I'll remove the tiling check.
Now that we have mmio flips in the kernel we can start to relax that
restriction. That still needs a bit more work in the mmio flip code
but I believe some people working on just that.
We could even change the pix
On Thu, Feb 20, 2014 at 08:51:57AM -0800, Aaron Plattner wrote:
> On 02/20/2014 12:47 AM, Ville Syrjälä wrote:
> > On Wed, Feb 19, 2014 at 04:22:19PM -0800, Aaron Plattner wrote:
> >> On 05/31/2013 07:01 AM, ville.syrj...@linux.intel.com wrote:
> >>> From: Ville Syrjä
On Wed, Feb 19, 2014 at 04:22:19PM -0800, Aaron Plattner wrote:
> On 05/31/2013 07:01 AM, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Using just one decimal place for dotclock and refresh rates loses quite
> > a bit of information. When de
ght, mode->vSyncStart, mode->vSyncEnd,
> mode->vTotal,
> mode_refresh (mode));
> }
> @@ -3799,7 +3799,7 @@ main (int argc, char **argv)
> if (rate == rates[i])
> break;
> if (i == nrate) {
> - fpr
to do any
of the work.
>
> I don't mean to dissuade you from trying to "fix" this, but actually
> getting a solution upstream is going to require a lot of messing
> around.
>
> Talk to Matthew Garrett, if you haven't talked to him, then you
> haven't talked to anyone who understands backlights.
>
> Dave.
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
rd VGA register, so everyone should be able to use
it to opt out of VGA memory decoding and hence we'd never need to
disable the entire memory space decoding. That would only leave IO space,
but most hardware has a way to access register via MMIO, so IO space
decode can often be permanently dis
ol(options, OPTION_BACKING_STORE,
> + !noCompositeExtension);
> +#endif
> }
> free(options);
> pScreen->backingStoreSupport = useBS ? WhenMapped : NotUseful;
> --
> 1.8.3.1
>
> ___
> xorg-devel
c);
> pWin->backStorage = NULL;
> --
> 1.8.3.1
>
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
--
Ville Sy
? WhenMapped : NotUseful;
> if (serverGeneration == 1)
> xf86DrvMsg(pScreen->myNum, from, "Backing store %s\n",
> useBS ? "enabled" : "disabled");
> --
> 1.8.3.1
>
> _______
> xorg-
t; switch (event->subtype) {
> case KeyPress:
> case KeyRelease:
> --
> 1.7.7.6
>
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
ime ago, but I suppose it fell
through the cracks. But feel free to go with your version ;)
Reviewed-by: Ville Syrjälä
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
x27;t know the input code very well, so I can't say
whether your patch is he right approach or not. But I wonder if it
would be enough to move the master check to happen inside
DGAProcessKeyboardEvent() and DGAProcessPointerEvent(), after
they've called UpdateDeviceState().
--
Ville Syrjäl
On Sun, Dec 18, 2011 at 06:26:04PM +0200, Ville Syrjälä wrote:
> This is now dead code. The only user was eliminated in
> commit 193ecc8b453b22b3e60248b9354c768dbd405598.
>
> Signed-off-by: Ville Syrjälä
Ping?
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci
From: Rami Ylimäki
If the client is not behaving correctly and swaps buffers before
getting them, Valgrind will complain about uninitialized memory being
used in DRI2InvalidateDrawable.
Signed-off-by: Rami Ylimäki
Reviewed-by: Ville Syrjälä
---
hw/xfree86/dri2/dri2.c |1 +
1 files
While a redirected window is flipped, its pixmap may still be used as
and EGL image and should also get invalidated. When sending invalidate
events for a window, also send the events for its pixmap.
Signed-off-by: Ville Syrjälä
---
glx/glxdri2.c |2 +-
hw/xfree86/dri2/dri2.c
From: Michel Dänzer
Otherwise we might keep stale cached information, e.g. after the driver
performed page flipping.
This is part of the fix for
https://bugs.freedesktop.org/show_bug.cgi?id=35452 .
Signed-off-by: Michel Dänzer
Reviewed-by: Ville Syrjälä
Reviewed-by: Mario Kleiner
---
hw
A bunch of DRI2 invalidate event related patches that fell through the
cracks.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
kinds of hilarity.
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=35452 .
[Original patch by Michel Dänzer ]
[Tree walk optimized version by Keith Packard ]
Signed-off-by: Ville Syrjälä
---
hw/xfree86/dri2/dri2.c | 31 ++-
1 files changed, 30 insertions(
This is now dead code. The only user was eliminated in
commit 193ecc8b453b22b3e60248b9354c768dbd405598.
Signed-off-by: Ville Syrjälä
---
dix/window.c | 33 +++--
include/window.h |5 -
2 files changed, 3 insertions(+), 35 deletions(-)
diff --git a/dix
want to cherry-pick this for 1.11...
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
The following changes since commit c8413362049cee8c30e0a9d67f78f9ebefe8e71f:
Merge remote-tracking branch 'herrb/master' (2011-10-18 07:45:24 -0700)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git composite_borderclip
Ville Syrjala (1):
composite: Upda
draw_x, int
> > draw_y,
> > pix_h = h + (bw<< 1);
> > if (pix_w != pOld->drawable.width || pix_h != pOld->drawable.height)
> > {
> > - pNew = compNewPixmap (pWin, pix_x, pix_y, pix_w, pix_h, FALSE);
> > + pNew = compNewPixmap (pWin, pix_x, pix_y, pix_w, pix_h);
> > if (!pNew)
> > return FALSE;
> > cw->pOldPixmap = pOld;
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Sat, Jul 23, 2011 at 04:00:11PM +0300, Ville Syrjälä wrote:
> On Fri, Jul 22, 2011 at 02:49:54PM -0400, Owen Taylor wrote:
> > On Thu, 2011-07-21 at 00:24 +0300, Ville Syrjälä wrote:
> > > > I did actually have to see it live to figure out what was going on ...
> >
On Fri, Jul 22, 2011 at 02:49:54PM -0400, Owen Taylor wrote:
> On Thu, 2011-07-21 at 00:24 +0300, Ville Syrjälä wrote:
> > > I did actually have to see it live to figure out what was going on ...
> > > but once I saw it, and thought about it a bit, I was able to avoid
On Wed, Jul 20, 2011 at 05:06:24PM -0400, Owen Taylor wrote:
> On Wed, 2011-07-20 at 10:44 -0400, Owen Taylor wrote:
> > On Wed, 2011-07-20 at 02:54 +0300, Ville Syrjälä wrote:
> >
> > > BTW I noticed afterwards that this doesn't help all apps. Evince, for
> >
On Tue, Jul 19, 2011 at 06:01:21PM -0400, Owen Taylor wrote:
> On Fri, 2011-05-06 at 18:19 +0300, ville.syrj...@nokia.com wrote:
> > From: Ville Syrjälä
> >
> > The composite extension spec says that window background painting
> > should be inhibited when the subwindow
uint32_t tiling_flags = 0;
> > int height;
> > + drmmode_flipdata_ptr flipdata;
> > drmmode_flipevtcarrier_ptr flipcarrier;
> >
> > if (info->allowColorTiling) {
> > @@ -1676,6 +1678,12 @@ Bool radeon_do_pageflip(ScrnInfoPtr scrn, st
On Thu, May 05, 2011 at 05:30:23PM +0300, Ville Syrjälä wrote:
> On Thu, May 05, 2011 at 12:28:20PM +0200, Michel Dänzer wrote:
> > On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote:
> > > Buffer exchange assumes that the front buffer pixmap and name
> > > inform
27663-1-git-send-email-ville.syrj...@nokia.com>
Also the DRI2 patches you and Michel bounced around seem to have dropped
through the cracks.
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
___
xorg-devel@lists.x.org: X.Org develo
On Fri, May 06, 2011 at 06:19:34PM +0300, ville.syrj...@nokia.com wrote:
> From: Ville Syrjälä
>
> The composite extension spec says that window background painting
> should be inhibited when the subwindow redirection mode is set to
> manual.
>
> This eliminates the ugly
s its GetBuffers and invalidate events. It's
all the other drawables which have a DRI2 drawable and share the same
pixmap, that get hammered with the unwanted invalidate events.
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Thu, May 05, 2011 at 06:33:11PM +0200, ext Mario Kleiner wrote:
>
> On May 5, 2011, at 6:06 PM, Ville Syrjälä wrote:
>
> > On Thu, May 05, 2011 at 05:09:56PM +0200, Mario Kleiner wrote:
> >> On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote:
> >>
> >>
share their back buffers
> > when page flipping is on.
>
> Is this workaround needed on the Intel driver too? Or is this just a
> driver bo name tracking bug?
I don't have Intel hw for testing, but as the code looks to be simply
copy-pasted from one driver to the other, I&
On Thu, May 05, 2011 at 05:09:56PM +0200, Mario Kleiner wrote:
> On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote:
>
> > On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote:
> >> On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote:
> >>> I came to the
>pScreen->DestroyPixmap)(priv->pixmap);
> > +front->pitch = pixmap->devKind;
> > +front->cpp = pixmap->drawable.bitsPerPixel / 8;
> > +priv->pixmap = pixmap;
> > +
> > +return TRUE;
> > +}
>
> Maybe at least some of this
buffers updated for other windows sharing the same
> pixmap?
As the real front buffers are not handed out to clients, there isn't
that much reason to update them. Making sure the fake front buffer
contain a more recent snapshot of the real front would be one reason
though.
-
+++-
3 files changed, 116 insertions(+), 55 deletions(-)
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
+ (*draw->pScreen->DestroyPixmap)(priv->pixmap);
+ front->pitch = pixmap->devKind;
+ front->cpp = pixmap->drawable.bitsPerPixel / 8;
+ priv->pixmap = pixmap;
+}
+
/* radeon_dri2_frame_event_handler will get called some unknown time in the
* future with these buffers.
it
> message.
Sure, I'll note in in the commit message.
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
The following changes since commit b2997431fd426ab318bc5dfd2cd43956d733ebec:
Send events that were missing from RRSelectInput (2011-04-13 19:04:32 -0700)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git dri2_fixes
Ville Syrjälä (2):
dri2: Handle calloc
On Fri, Mar 25, 2011 at 03:32:06PM +0100, ext Michel Dänzer wrote:
> On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote:
> > On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote:
> > > From: Michel Dänzer
> > >
> > > Without this, when
On Fri, Mar 25, 2011 at 06:10:42AM -0700, ext Jakob Bornecrantz wrote:
> On Mar 25, 2011, at 13:47, Ville Syrjälä wrote:
> > On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote:
> >> From: Michel Dänzer
> >>
> >> Without this, when a composit
pixmaps
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
While a redirected window is flipped, it's pixmap may still be used as
and EGL image and should also get invalidated. When sending invalidate
events for a window, also send the events for it's
clip.
There is at least one issue with the current implementation; It sends
the event to all clients who are interested in the same window. So
if you fire up your vnc screen scraper, your composite manager thinks
it has to redraw the window. I think that at least should be fixed.
--
Ville Sy
still end up in the correct areas. Well,
assuming the drawable serial and scratch GC serial aren't identical.
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
g that should be fixed anyway.
I fear you pretty much have to review every piece of code that checks
the drawable type.
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
owing windows to use the scanout pixmaps as their
backing pixmap? I'm mainly interested in something that would allow
unredirected 32bpp windows on a 16bpp screen.
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Thu, Feb 24, 2011 at 07:17:28PM -0800, ext Keith Packard wrote:
> On Thu, 24 Feb 2011 17:38:53 +0200, Ville Syrjälä
> wrote:
>
> > Ville Syrjälä (4):
> > composite: Call ValidateGC after ChangeGC
> > composite: Initialize borderClip with current values
595673:
test: write some event → XI1 conversion tests. (2011-02-22 08:08:55 +1000)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git composite_validatetree
Ville Syrjälä (4):
composite: Call ValidateGC after ChangeGC
composite: Initialize borderClip with
On Tue, Feb 15, 2011 at 09:18:36AM +0200, Pauli Nieminen wrote:
> On 14/02/11 21:06 +0200, Ville Syrjälä wrote:
> > On Tue, Feb 08, 2011 at 11:42:54PM +0200, ext Pauli wrote:
> > > From: Pauli Nieminen
> > >
> > > If client disconnects and new client
On Thu, Feb 10, 2011 at 06:22:24PM +0200, Pauli Nieminen wrote:
> On 10/02/11 17:40 +0200, Ville Syrjälä wrote:
> > On Tue, Feb 08, 2011 at 11:42:49PM +0200, ext Pauli wrote:
> > > From: Pauli Nieminen
> > >
> > > void
> > > -DRI2WaitMSCComplete(C
v,
> CARD64 target_msc,
> ret = (*ds->ScheduleWaitMSC)(client, pDraw, target_msc, divisor,
> remainder, client);
> if (!ret) {
> pPriv->refcnt--;
> + cleanup_client_event(pEvent);
> + free(pEvent);
> return BadDrawable;
> }
>
wable(pPriv);
>
> +DRI2CopyFrontToFakeFront(pDraw, pPriv);
Looks to me like the ati and intel drivers won't like this change since
they don't exchange the buffer names until the vblank event is received.
I'd say those drivers just need fixing.
> return Success;
> }
>
> --
>
indow' from the caller.
> +
> +if (type == DRAWABLE_WINDOW) {
> for (i = 0; i < count; i++) {
> /* Do not send the real front buffer of a window to the client.
> */
> @@ -267,7 +270,7 @@ send_buffers_reply(ClientPtr client, DRI2DrawablePtr
> pPriv,
>
>
(pPriv, buffers[i]);
> }
>
> free(buffers);
> @@ -684,14 +696,11 @@ DRI2CanExchange(DrawablePtr pDraw)
> }
>
> void
> -DRI2WaitMSCComplete(ClientPtr client, DrawablePtr pDraw, int frame,
> - unsigned int tv_sec, unsi
ets reviewed
> I will create more patches to convert other drivers too.
>
This set looks good to me.
Reviewed-by: Ville Syrjälä
> Pauli Nieminen (6):
> xf86/xv: Remove copy paste code.
> xf86/xv: Remove unused GC pointers
> xf86/xv: Remove unused variable from XvPortRe
e (pDraw, key, fillboxes);
RegionCopy(pPriv->ckeyFilled, clipboxes);
if (fillboxes == ®)
RegionUninit(®);
}
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
> screen while in DGA2 mode.
>
> merged the series, thanks.
>
> fixed up the copy/paste error in 06/11, don't worry about sending another
> patch for that.
Thanks.
Apprently I didn't look at the events too closely on the client
side, and my test app's visual feed
nter data, RegionPtr clipboxes,
> RegionPtr fillboxes);
>
> extern _X_EXPORT Bool
> xf86XVClipVideoHelper(
> diff --git a/hw/xfree86/common/xf86xvpriv.h b/hw/xfree86/common/xf86xvpriv.h
> index 4572218..3f1106d 100644
> --- a/hw/xfree86/common/xf86xvpriv.h
> +++ b/hw/xfree86/common/xf86xvpriv.h
> @@ -68,6 +68,7 @@ typedef struct {
> unsigned char type;
> unsigned int subWindowMode;
> RegionPtr clientClip;
> + RegionPtr ckeyFilled;
> RegionPtr pCompositeClip;
> Bool FreeCompositeClip;
> XvAdaptorRecPrivatePtr AdaptorRec;
> --
> 1.7.0.4
>
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
> xf86XVClipVideoHelper(
> diff --git a/hw/xfree86/common/xf86xvpriv.h b/hw/xfree86/common/xf86xvpriv.h
> index 4572218..563b55a 100644
> --- a/hw/xfree86/common/xf86xvpriv.h
> +++ b/hw/xfree86/common/xf86xvpriv.h
> @@ -72,6 +72,7 @@ typedef struct {
> Bool FreeCompositeClip;
> XvAdaptorRecPrivatePtr AdaptorRec;
> XvStatus isOn;
> + RegionRec exposedAreas;
> int vid_x, vid_y, vid_w, vid_h;
> int drw_x, drw_y, drw_w, drw_h;
> DevUnion DevPriv;
> --
> 1.7.0.4
>
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
boxes,
> RegionPtr fillboxes);
>
> extern _X_EXPORT Bool
> xf86XVClipVideoHelper(
> diff --git a/hw/xfree86/common/xf86xvpriv.h b/hw/xfree86/common/xf86xvpriv.h
> index 4572218..563b55a 100644
> --- a/hw/xfree86/common/xf86xvpriv.h
> +++ b/hw/xfree86/common/xf86xvpriv
The following changes since commit 0dede200c9ac7adbe8b8c16efacc3edc1f183cd9:
Merge remote branch 'vsyrjala/misc_fixes' (2011-01-05 08:51:46 -0800)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git composite_getimage_sourcevalidate_v5
Ville
I can resolve the conflicts.
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Wed, Jan 05, 2011 at 08:34:12AM -0800, ext Keith Packard wrote:
> On Wed, 5 Jan 2011 15:51:36 +0200, ville.syrj...@nokia.com wrote:
> > From: Ville Syrjälä
> >
> > Use the "report after" damage mode for marking the automatically
> > redirected as da
On Wed, Jan 05, 2011 at 04:19:28PM +, ext Daniel Stone wrote:
> On Wed, Jan 05, 2011 at 06:04:05PM +0200, Ville Syrjälä wrote:
> > On Thu, Dec 30, 2010 at 03:49:13PM +0200, Ville Syrjälä wrote:
> > > The following changes since commit
> > > efcb63d0ce43f
On Thu, Dec 30, 2010 at 03:49:13PM +0200, Ville Syrjälä wrote:
> The following changes since commit efcb63d0ce43f96d0ac02b6f4a480dfd2374fc84:
>
> Render: Fix 'comparing between distinct pointer types' warning (2010-12-27
> 09:44:07 -0800)
>
> are available in th
On Tue, Jan 04, 2011 at 05:55:51PM +0200, ville.syrj...@nokia.com wrote:
> From: Ville Syrjälä
>
> When SourceValidate is performed on a window with IncludeInferiors
> sub-window mode, force an immediate update of all the automatically
> redirected windows, so that the current
On Tue, Jan 04, 2011 at 08:16:18AM -0800, ext Keith Packard wrote:
> On Tue, 4 Jan 2011 17:55:53 +0200, ville.syrj...@nokia.com wrote:
> > From: Ville Syrjälä
> >
> > Use CopyArea in compWindowUpdateAutomatic if the window and parent
> > depths match. It appears E
On Mon, Jan 03, 2011 at 09:21:40AM -0800, Keith Packard wrote:
> On Mon, 3 Jan 2011 15:54:54 +0200, Ville Syrjälä
> wrote:
>
> > How about this? Stills leaves the compChildrenUpdate name there
> > though.
>
> Yeah, the structure looks good. I still don't like
r since the root
> > window's 'damagedDescendants' provides the same information.
>
> > Signed-off-by: Ville Syrjälä
>
> This seems like a reasonable optimization to me, reducing the cost of
> having any CompositeRedirectAutomatic windows on the screen.
&g
On Fri, Dec 31, 2010 at 01:42:16PM -0800, ext Keith Packard wrote:
> On Fri, 31 Dec 2010 16:49:37 +0200, ville.syrj...@nokia.com wrote:
> > From: Ville Syrjälä
> >
> > When SourceValidate is performed on a window with IncludeInferiors
> > sub-window mode, force an
r since the root
> > window's 'damagedDescendants' provides the same information.
>
> > Signed-off-by: Ville Syrjälä
>
> This seems like a reasonable optimization to me, reducing the cost of
> having any CompositeRedirectAutomatic windows on the screen.
&g
On Mon, Dec 27, 2010 at 03:24:09PM +0200, ville.syrj...@nokia.com wrote:
> Patch 4/4 was modified to accomodate the review comments. The rest
> remain unchanged.
Were there still open issues with this set?
--
Ville Syrjälä
___
xorg-devel@lists
On Thu, Dec 30, 2010 at 10:34:22AM -0800, ext Keith Packard wrote:
> On Thu, 30 Dec 2010 14:56:19 +0200, Ville Syrjälä
> wrote:
> > On Wed, Dec 29, 2010 at 01:05:02PM -0800, ext Keith Packard wrote:
> > > On Wed, 29 Dec 2010 15:04:29 +0200, ville.syrj...@nokia.com wrote
The following changes since commit efcb63d0ce43f96d0ac02b6f4a480dfd2374fc84:
Render: Fix 'comparing between distinct pointer types' warning (2010-12-27
09:44:07 -0800)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git misc_fixes
Ville Syrjälä (2):
On Wed, Dec 29, 2010 at 01:05:02PM -0800, ext Keith Packard wrote:
> On Wed, 29 Dec 2010 15:04:29 +0200, ville.syrj...@nokia.com wrote:
> > From: Ville Syrjälä
> >
> > Rename compScreenUpdate to compChildrenUpdate, and pass a window as
> > the parameter. This allows
GetImage works. CopyArea is yet to be tested.
Just added a quick CopyArea test to my test app. Without the
SourceValidate patch stale pixels are copied, and with the patch
I get the correct pixels. So seems to work as expected.
--
Ville Syrjälä
___
xorg-de
OCALSTATEDIR
>
> +# This will catch the case where user forgets to set PREFIX
> +# and does not have write permission in the /usr/local default location
> +check_writable_dir $PREFIX PREFIX
Seems like it should check ${DESTDIR}${PREFIX} instead.
--
gt; > + if (pWin == pScreen->root)
> > + cs->damaged = FALSE;
>
> compWindowUpdate walks all the children itself, so you should be able to
> replace the for loop with a simple compWindowUpdate(pWin).
compWindowUpdate would cause pWin contents to be copied to it'
On Mon, Dec 27, 2010 at 11:11:58AM -0800, ext Keith Packard wrote:
> On Mon, 27 Dec 2010 20:45:39 +0200, Ville Syrjälä
> wrote:
>
> > Could be overwritten fully, partially, or not at all, depending on
> > the operation and GC clipping, I suppose? If any part of it gets
>
On Mon, Dec 27, 2010 at 08:45:39PM +0200, Ville Syrjälä wrote:
> On Mon, Dec 27, 2010 at 10:25:17AM -0800, ext Keith Packard wrote:
> > On Mon, 27 Dec 2010 15:27:10 +0200, ville.syrj...@nokia.com wrote:
> > > Instead of trying to identify all parts of the code that have that
>
On Mon, Dec 27, 2010 at 10:45:35AM -0800, ext Keith Packard wrote:
> On Mon, 27 Dec 2010 20:30:06 +0200, Ville Syrjälä
> wrote:
>
> > We're going through this codepath when getting rid of an implicitly
> > redirected window. That is at least one case where the dept
e calls SourceValidate
> sometimes to patch-up the missing calls from CopyArea.)
>
> I'd say a combination of SourceValidate and GetImage wrappers would do
> the trick nicely here.
>
> --
> keith.pack...@intel.com
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
0x00022f88 in DeleteWindow (value=0x3dded0, wid=4194306) at
../../dix/window.c:905
#6 0x00030030 in FreeClientResources (client=0x3eac88) at
../../dix/resource.c:859
#7 0x0007c700 in CloseDownClient (client=0x3eac88) at ../../dix/dispatch.c:3490
#8 0x00073494 in Dispatch () at ../../dix/dispatch.c:417
#9 0x000207ac in main (argc=16, argv=0xaec4cdd4, envp=0xaec4ce18) at
../../dix/main.c:291
(gdb) p pWin->drawable.depth
$5 = 32 ' '
(gdb) p pWin->parent->drawable.depth
$6 = 16 '\020'
(gdb)
--
Ville Syrjälä
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
x, y, w, h, 0, 0);
> > + FreeScratchGC (pGC);
> > + }
> > +}
> > +}
>
> It might be nice to get the Render fallback path for non-matching depths
> here;
AFAICS that shouldn't be needed as unredirecting a non-matching depth
window would always
On Mon, Dec 20, 2010 at 10:34:34AM -0800, ext Keith Packard wrote:
> On Mon, 20 Dec 2010 20:30:34 +0200, Ville Syrjälä
> wrote:
>
> > Yeah. I'm not 100% sold on that myself yet. miValidateTree & co. don't
> > seem to sink in without some conscious effort.
on and the caller should be
> responsible for fetching the pixmap beforehand and freeing afterwards.
OK. I'll adjust the patch accordingly.
> Alternatively, (and I think this is uglier), compCheckRedirect could
> bump the pixmap ref count before
the xv
stuff etc. You can run it, for example, like so:
'xvredirect -F -d -s -b 10`
You can input 'm'/'a'/'u' for manual/automatic/unredirected redirection
for the middle sibling. 'M'/'A'/'U' to do the same for the top level
window. It will p
On Mon, Dec 20, 2010 at 01:04:07PM -0500, ext Adam Jackson wrote:
> On Mon, 2010-12-20 at 18:05 +0200, ville.syrj...@nokia.com wrote:
> > From: Ville Syrjälä
> >
> > Eliminate the internal MapWindow+UnmapWindow cycle around window
> > redirection changes. Instead do t
On Thu, Dec 16, 2010 at 01:50:25PM +0200, ext ville.syrj...@nokia.com wrote:
> From: Ville Syrjälä
>
> Assume that a mode can be used in either landscape or portrait
> orientation. I suppose the correct thing to do would be to collect all
> the supported rotations from the CRTCs t
1 - 100 of 115 matches
Mail list logo
