Re: [V2] modesetting: code refactor for PRIME sync

2018-08-28 Thread jimqu
d two GPUs) on the system. then I found a GTX500, it had only one device node. Did you encounter the same issue? BTW, could you do me a favor to help me push the patch to the master or other proper branch? I do not familiar with the processes that push the patch to Xorg. Thanks JimQu Hi AlexG,

Re: [V2] modesetting: code refactor for PRIME sync

2018-08-28 Thread jimqu
Hi AlexG, What's about new patch? Thanks JimQu 在 2018/8/27 13:37, Jim Qu 写道: The X will be crashed on the system with other DDX driver, such as amdgpu. show the log like: randr: falling back to unsynchronized pixmap sharing (EE) (EE) Backtrace: (EE) 0: /usr/lib/xorg/Xorg (xorg_back

Re: [PATCH] modesetting: code refactor for PRIME sync

2018-08-24 Thread jimqu
t;RequestSharedPixmapNotifyDamage(ppix->master_pixmap)) ABI break. These might make more logical sense, but changing them will require bumping the ABI. Moreover, they follow the precedent of the non-sync {Start/Stop}PixmapTracking, so if we change these, we should probably change those too.

Re: [V2] modesetting: Fix X crash in ms_dirty_update()

2018-08-20 Thread jimqu
Hi AlexG, I just has a question. Did you suppose the output master device(dGPU) is equivalent to master screen, output slave(iGPU) device is equivalent to slave screen in modesetting driver under PRIME(not reverse) case? Thanks JimQu On 2018年08月18日 02:55, Alex Goins wrote: I think this

Re: [V2] modesetting: Fix X crash in ms_dirty_update()

2018-08-20 Thread jimqu
ou fix msRequestSharedPixmapNotifyDamage() as described above, this patch should be good to go, but as it stands, it will likely introduce a regression in modesetting<->modesetting PRIME. Please fix that, then verify that modesetting<->modesetting PRIME (with PRIME Sync) still works. I c

Re: [V2] modesetting: Fix X crash in ms_dirty_update()

2018-08-07 Thread jimqu
Anybody could give a RB? Michel? Thanks JimQu On 2018年08月07日 12:47, jimqu wrote: ping On 2018年08月06日 10:40, Jim Qu wrote: On some Intel iGPU + AMD dGPU platform, when connect extern display from dGPU, X will crash, show the log like: randr: falling back to unsynchronized pixmap

Re: [V2] modesetting: Fix X crash in ms_dirty_update()

2018-08-06 Thread jimqu
ping On 2018年08月06日 10:40, Jim Qu wrote: On some Intel iGPU + AMD dGPU platform, when connect extern display from dGPU, X will crash, show the log like: randr: falling back to unsynchronized pixmap sharing (EE) (EE) Backtrace: (EE) 0: /usr/lib/xorg/Xorg (xorg_backtrace+0x4e) (EE) 1: /usr/l

Re: [PATCH] modesetting: Fix X crash in ms_dirty_update()

2018-08-04 Thread jimqu
about the defer_dirty_update related code, that might only make sense in the slave. The more I look at this PRIME synchronization related code, the more I wonder if it was ever tested with master and slave screens using different drivers... Yeah,  Maybe , the master hook PresentSharedPixmap()

Re: [PATCH] modesetting: Fix X crash in ms_dirty_update()

2018-08-03 Thread jimqu
Sorry, it poped an error when sent the first patch mail, so sent it again. Hi Adam, For urgent issue, I just made the patch first. please help review. Thanks JimQu On 2018年08月03日 21:27, Jim Qu wrote: On some Intel iGPU + AMD dGPU platform, when connect extern display from dGPU, X will crash