Re: [PATCH] glx: swrast can do GLX 1.4 too

2009-10-29 Thread keithp
Excerpts from Adam Jackson's message of Thu Oct 29 11:01:29 -0700 2009: > +screen->base.GLXmajor = 1; > +screen->base.GLXminor = 4; > + Should this define be in a header somewhere? -- keith.pack...@intel.com signature.asc Description: PGP signature

Re: [PATCH] Abstract calls to in/out with IN/OUT macros

2009-11-01 Thread keithp
Excerpts from Matt Turner's message of Sun Nov 01 11:01:20 -0800 2009: > This will allow us to include sys/io.h and use libc's in/out when > available. That's a fine goal, but given the ambiguity between Linux and BSD on the outb argument ordering, I've got some suggestions > #ifdef linux >

Re: [PATCH] Remove lnx_font.c and lnx.h

2009-11-01 Thread keithp
Excerpts from Matt Turner's message of Sun Nov 01 12:22:44 -0800 2009: > I couldn't find any version of the X xserver that ever used lnx_font.c > so let's delete it. I tried contacting its author, Egbert, multiple > times on IRC and email [*] but never got any response. It also hasn't > been seriou

Re: [PATCH] [alpha] Remove unused code, _dense_* functions, iobase stuff

2009-11-01 Thread keithp
Excerpts from Mark Kettenis's message of Sun Nov 01 13:26:11 -0800 2009: > Ah well, if you're not implying that this is now handled by > libpciaccess, and if dense support on Linux still works after this > change, this should be fine. Any chance I could get a 'Test-by:' here? I'm not exactly in a

Re: [PATCH] Abstract calls to in/out with IN/OUT macros

2009-11-01 Thread keithp
Excerpts from Mark Kettenis's message of Sun Nov 01 13:19:04 -0800 2009: > While I sympathise with your attempt to clean up the mess in > compiler.h, this will break at least one driver (xf86-video-i128). A fine example of why we want to merge the drivers into the server :-) In any case, for now

Re: [PATCH] [alpha] Remove unused code, _dense_* functions, iobase stuff

2009-11-01 Thread keithp
Excerpts from Michael Cree's message of Sun Nov 01 15:33:18 -0800 2009: > I'm happy to test this, but it may be a couple of days before I can do > so. Cool! Send a note when you figure out whether you think this is ready for master, and include a a suitable '-by:' tag for git (either Tested-by

Re: [PATCH] Remove lnx_font.c and lnx.h

2009-11-05 Thread keithp
Excerpts from Matt Turner's message of Thu Nov 05 09:38:53 -0800 2009: > So can we kill it? I remember reading about an X developer who > suggested that the way to remove code was to silently break it and see > if anyone complains. :) Yeah, but the key there is to make it look like an accident. I

Re: [PATCH] Remove lnx_font.c and lnx.h

2009-11-05 Thread keithp
Excerpts from Tiago Vignatti's message of Thu Nov 05 19:19:18 -0800 2009: > hummm I've never seen any not-so-much-recently driver doing such console > font saving, specially for multiseat setups. > > Reviewed-by: Tiago Vignatti Thanks, Tiago and Matt. -- keith.pack...@intel.com _

Re: [PATCH] xfree86/modes: Fixed memory leak in xf86InitialConfiguration

2011-03-10 Thread keithp
On Thu, 10 Mar 2011 11:07:35 +0200, Erkki Seppala wrote: > Also, I don't think it can be a CRLF-issue, because the Internet text > message format prohibits lines with CRLF and the mail isn't encoded in > any special way. (In any case, my email agent shows that all messages > have CRLF-terminated

Re: [PULL] Linux and bus subsystem cleanups

2009-11-10 Thread keithp
Excerpts from Adam Jackson's message of Tue Nov 10 11:43:21 -0800 2009: > Adam Jackson (7): > bus: Fix open-coded implementation of xf86MakeNewMapping This leaves vp uninitialized. You need to keep calling getVidMapRec > bus: Change xf86MakeNewMapping prototy

Re: [PULL] Linux and bus subsystem cleanups

2009-11-10 Thread keithp
Excerpts from Adam Jackson's message of Tue Nov 10 14:06:47 -0800 2009: > Slightly easier said than done. sdksyms.sh pretty much wants _every_ > definition in sdk headers to be prefaced with _X_EXPORT, last time I > read it. So it'd need to be in a new header, or we'd need to fix > sdksyms.sh.