Re: [PATCH/libX11] Return name instead of value in XGetIMValues() and XSetIMValues()

2011-10-11 Thread Yann Droneaud
Le lundi 10 octobre 2011 à 14:00 -0700, Jeremy Huddleston a écrit : The src changes look right, but I'm wondering if this is a documentation bug rather than an implementation bug. Returning the value is not really useful to diagnose an error, a program would have to manage a conversion table

Re: [PATCH/libX11] Return name instead of value in XGetIMValues() and XSetIMValues()

2011-10-11 Thread Yann Droneaud
Le lundi 10 octobre 2011 à 14:00 -0700, Jeremy Huddleston a écrit : The src changes look right, but I'm wondering if this is a documentation bug rather than an implementation bug. Is anyone relying on the current (undocumented) behavior? XGetICValues() and XSetICValues() returns the name

Re: [PATCH/libX11] Return name instead of value in XGetIMValues() and XSetIMValues()

2011-10-11 Thread Jeremy Huddleston
Ok, thanks for addressing my concerns. Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 11, 2011, at 06:08, Yann Droneaud wrote: Le lundi 10 octobre 2011 à 14:00 -0700, Jeremy Huddleston a écrit : The src changes look right, but I'm wondering if this is a documentation bug rather

Re: [PATCH/libX11] Return name instead of value in XGetIMValues() and XSetIMValues()

2011-10-10 Thread Jeremy Huddleston
The src changes look right, but I'm wondering if this is a documentation bug rather than an implementation bug. Is anyone relying on the current (undocumented) behavior? On Oct 9, 2011, at 08:56, Yann Droneaud wrote: As stated in man page (XOpenIM) and Xlib documentation (chapter 13.5.3),

[PATCH/libX11] Return name instead of value in XGetIMValues() and XSetIMValues()

2011-10-09 Thread Yann Droneaud
As stated in man page (XOpenIM) and Xlib documentation (chapter 13.5.3), XGetIMValues() and XSetImValues() returns the name of the first argument that could not be obtained. But currently, err = XGetIMValues(im, invalid, arg, NULL); returns arg instead of invalid. This patch fixes