Re: [PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

2013-07-30 Thread Alan Coopersmith
On 07/29/13 12:04 AM, Thomas Klausner wrote: On Sat, Jul 27, 2013 at 11:22:03AM -0700, Alan Coopersmith wrote: On 07/27/13 12:17 AM, Thomas Klausner wrote: No. I just took the patch as committed, but you're right, const for both makes more sense -- attached. @@ -321,11 +321,10 @@

Re: [PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

2013-07-29 Thread Thomas Klausner
On Sat, Jul 27, 2013 at 11:22:03AM -0700, Alan Coopersmith wrote: On 07/27/13 12:17 AM, Thomas Klausner wrote: No. I just took the patch as committed, but you're right, const for both makes more sense -- attached. @@ -321,11 +321,10 @@ WSReadInput(InputInfoPtr·pInfo) } static·void

Re: [PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

2013-07-27 Thread Thomas Klausner
: Thomas Klausner w...@netbsd.org Date: Fri, 26 Jul 2013 21:37:19 +0200 Subject: [PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const. From Izumi Tsutsui tsut...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/bsd_kbd.c | 8 1 file changed, 4 insertions

Re: [PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

2013-07-27 Thread Alan Coopersmith
On 07/27/13 12:17 AM, Thomas Klausner wrote: No. I just took the patch as committed, but you're right, const for both makes more sense -- attached. @@ -321,11 +321,10 @@ WSReadInput(InputInfoPtr·pInfo) } static·void -printWsType(char·*type,·char·*devname)

[PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

2013-07-26 Thread Thomas Klausner
From Izumi Tsutsui tsut...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/bsd_kbd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c index 2959178..8f98c71 100644 --- a/src/bsd_kbd.c +++ b/src/bsd_kbd.c @@ -173,8 +173,8

Re: [PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

2013-07-26 Thread Alan Coopersmith
On 07/26/13 02:24 PM, Thomas Klausner wrote: -printWsType(char *type, char *devname) +printWsType(const char *type, char *name) { -xf86Msg(X_PROBED, %s: Keyboard type: %s\n, devname, type); +xf86Msg(X_PROBED, %s: Keyboard type: %s\n, name, type); } #endif Any particular reason