[PATCH:xf86-video-s3] When checking malloc for success, it helps to use == NULL, instead of =

2016-03-12 Thread Alan Coopersmith
Fixes gcc 5.3 compiler warning: s3_bios.c: In function 'find_bios_string': s3_bios.c:49:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (bios = NULL) ^ [Tested by compiling only, as I have no S3 hardware, but clearly no one else has tested this c

Re: [PATCH:xf86-video-s3] When checking malloc for success, it helps to use == NULL, instead of =

2016-03-14 Thread Adam Jackson
On Sat, 2016-03-12 at 11:02 -0800, Alan Coopersmith wrote: > Fixes gcc 5.3 compiler warning: > s3_bios.c: In function 'find_bios_string': > s3_bios.c:49:2: warning: suggest parentheses around assignment used as > truth value [-Wparentheses] >   if (bios = NULL) > ^ > > [Tested by compiling