Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-24 Thread Thomas Klausner
On Fri, Jul 24, 2015 at 04:04:00AM -0400, Olivier Fourdan wrote: > I posted a comment to your Xpoll patch already: > > http://lists.x.org/archives/xorg-devel/2015-July/046951.html Yes, thanks for your comment. > You may disagree with my comment, just wanted to make sure we considered that. No,

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-24 Thread Olivier Fourdan
Hi - Original Message - > I'm still looking for a reviewer of the corresponding patch in Xpoll.h > itself (xproto). Perhaps patches 2&3 in the series discouraged > reviewers, but patch 1 is needed for this, otherwise the other > re-ordering patches are not sufficient. I posted a comment

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-23 Thread Thomas Klausner
On Wed, Jul 22, 2015 at 03:08:33PM +0100, Emil Velikov wrote: > On 21 July 2015 at 22:18, Thomas Klausner wrote: > > Hi Emil! > > > > On Mon, Jul 20, 2015 at 05:00:43PM +0100, Emil Velikov wrote: > >> On 19 July 2015 at 08:56, Thomas Klausner wrote: > >> > From: Matthew Green > >> > > >> > Move

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-22 Thread Emil Velikov
On 21 July 2015 at 22:18, Thomas Klausner wrote: > Hi Emil! > > On Mon, Jul 20, 2015 at 05:00:43PM +0100, Emil Velikov wrote: >> On 19 July 2015 at 08:56, Thomas Klausner wrote: >> > From: Matthew Green >> > >> > Move X11/Xpoll.h include earlier than sys/select.h to avoid missing >> > out on set

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-21 Thread Thomas Klausner
Hi Emil! On Mon, Jul 20, 2015 at 05:00:43PM +0100, Emil Velikov wrote: > On 19 July 2015 at 08:56, Thomas Klausner wrote: > > From: Matthew Green > > > > Move X11/Xpoll.h include earlier than sys/select.h to avoid missing > > out on setting FD_SETSIZE early enough. > > > Shouldn't there be a com

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-20 Thread Emil Velikov
Hi Thomas, On 19 July 2015 at 08:56, Thomas Klausner wrote: > From: Matthew Green > > Move X11/Xpoll.h include earlier than sys/select.h to avoid missing > out on setting FD_SETSIZE early enough. > Shouldn't there be a comment to prevent the next person from reverting/messing up with the order ?

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-19 Thread Alan Coopersmith
On 07/19/15 12:56 AM, Thomas Klausner wrote: From: Matthew Green Move X11/Xpoll.h include earlier than sys/select.h to avoid missing out on setting FD_SETSIZE early enough. Signed-off-by: Thomas Klausner --- os/connection.c | 2 +- os/io.c | 3 ++- 2 files changed, 3 insertions(+)

[PATCH:xfs 1/2] FD_SETSIZE fixes.

2015-07-19 Thread Thomas Klausner
From: Matthew Green Move X11/Xpoll.h include earlier than sys/select.h to avoid missing out on setting FD_SETSIZE early enough. Signed-off-by: Thomas Klausner --- os/connection.c | 2 +- os/io.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/os/connection.c b/o