[PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Erkki Seppälä
The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch adds a call to free and resetting the private record to miSpriteDeviceCursorCleanup. Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi --- mi/misprite.c |

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 03:42:14PM +0200, Erkki Seppälä wrote: The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch adds a call to free and resetting the private record to miSpriteDeviceCursorCleanup. Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Erkki Seppala
On 09.03.2011 15:57, Daniel Stone wrote: You could get this automatically by having miSpriteDevPrivatesKey allocate sizeof(miCursorInfoRec), rather than doing the allocation and free separately. Thanks for the feedback! I considered this with Rami, but it appeared that it uses the NULLness

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 04:19:06PM +0200, Erkki Seppala wrote: On 09.03.2011 15:57, Daniel Stone wrote: You could get this automatically by having miSpriteDevPrivatesKey allocate sizeof(miCursorInfoRec), rather than doing the allocation and free separately. Thanks for the feedback!