Re: [PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-09 Thread Olivier Fourdan
Hi Daniel, - Original Message - > I'm not a big fan of the Bool -> int -> enum trickery > but I'm not sure if we could afford to have an enum > without breaking API/ABI (although I reckoned most compilers > would use an int for an enum, no?), but if we have no other > choice then, fine. W

Re: [PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-09 Thread Olivier Fourdan
Hi Daniel, - Original Message - > [Accidentally sent the unannotated version - sorry.] > > Hi, > > On 23 November 2015 at 07:51, Olivier Fourdan wrote: > > diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c > > index 5ef444d..2a180f2 100644 > > --- a/hw/xwayland/

Re: [PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-08 Thread Daniel Stone
Hi Olivier, On 8 February 2016 at 16:00, Olivier Fourdan wrote: >> Tested by starting with a single output, manually checking >> screenInfo.screens[0]->root->{winSize,borderSize,borderClip,clipList} >> with gdb, hotplugging an output, verifying the regions again and also >> checking xev receives

Re: [PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-08 Thread Olivier Fourdan
Hi Daniel, - Original Message - > [Accidentally sent the unannotated version - sorry.] > [...] > > Unfortunately this totally breaks output hotplug, regressing the fix > from 216bdbc735. The effect is that if you hotplug an output and move an > XWayland window on to it, it can never recei

[PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-08 Thread Daniel Stone
[Accidentally sent the unannotated version - sorry.] Hi, On 23 November 2015 at 07:51, Olivier Fourdan wrote: > diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c > index 5ef444d..2a180f2 100644 > --- a/hw/xwayland/xwayland-output.c > +++ b/hw/xwayland/xwayland-output.c >

[PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-08 Thread Daniel Stone
216bdbc735 removed the SetRootClip call in the XWayland output-hotplug handler when running rootless (e.g. as a part of Weston/Mutter), since the root window has no storage, so generating exposures will result in writes to invalid memory. Unfortunately, preventing the segfault also breaks sprite c