Re: [PATCH] Allow paths and patterns to be const

2014-01-30 Thread Knut Petersen
On 30.01.2014 10:19, Keith Packard wrote: Knut Petersen writes: Could it be that you did not test if the (rebased) const/pointer patches break xfs again? ;-)) Did you see the three patch series for xfs that I posted yesterday? Ah, no. Thanks. cu, Knut _

Re: [PATCH] Allow paths and patterns to be const

2014-01-30 Thread Keith Packard
Knut Petersen writes: > Could it be that you did not test if the (rebased) const/pointer > patches break xfs again? ;-)) Did you see the three patch series for xfs that I posted yesterday? -- keith.pack...@intel.com pgpDTs8GDjb0e.pgp Description: PGP signature ___

Re: [PATCH] Allow paths and patterns to be const

2014-01-30 Thread Knut Petersen
On 29.01.2014 23:54, Gaetan Nadon wrote: On 13-12-13 02:32 PM, Keith Packard wrote: Signed-off-by: Keith Packard --- font.h | 4 ++-- fontstruct.h | 16 ++-- 2 files changed, 12 insertions(+), 8 deletions(-) I had to rebase it as the changes to "pointer" made it earlier

Re: [PATCH] Allow paths and patterns to be const

2014-01-29 Thread Keith Packard
Gaetan Nadon writes: > I had to rebase it as the changes to "pointer" made it earlier in git. I > included it for anyone who wants to double check. > With this patch, libXfont compiles fine. > > Reviewed-by: Gaetan Nadon Merged. 7f951a3..8ba53a7 master -> master -- keith.pack...@intel.com

Re: [PATCH] Allow paths and patterns to be const

2014-01-29 Thread Gaetan Nadon
On 13-12-13 02:32 PM, Keith Packard wrote: > Signed-off-by: Keith Packard > --- > font.h | 4 ++-- > fontstruct.h | 16 ++-- > 2 files changed, 12 insertions(+), 8 deletions(-) I had to rebase it as the changes to "pointer" made it earlier in git. I included it for anyone who

[PATCH] Allow paths and patterns to be const

2013-12-13 Thread Keith Packard
Signed-off-by: Keith Packard --- font.h | 4 ++-- fontstruct.h | 16 ++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/font.h b/font.h index b71046b..a834655 100644 --- a/font.h +++ b/font.h @@ -140,7 +140,7 @@ extern void EmptyFontPatternCache (

Re: [PATCH] Allow paths and patterns to be const

2013-11-20 Thread Keith Packard
Adam Jackson writes: > Looks like a reasonable change, but it'd be a little unfortunate to > break building older server on newer fontsproto, which is what would > happen if I read you right. Indeed. The X server does things something like: fpe->name = malloc() strncpy(fpe->name

Re: [PATCH] Allow paths and patterns to be const

2013-11-20 Thread Adam Jackson
On Mon, 2013-11-18 at 16:58 -0800, Keith Packard wrote: > Signed-off-by: Keith Packard > --- > > Note that this changes the API to the library; the X server, in > particular, requires changes before this can be merged. Looks like a reasonable change, but it'd be a little unfortunate to break bui

[PATCH] Allow paths and patterns to be const

2013-11-18 Thread Keith Packard
Signed-off-by: Keith Packard --- Note that this changes the API to the library; the X server, in particular, requires changes before this can be merged. font.h | 4 ++-- fontstruct.h | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/font.h b/font.h index