[PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-25 Thread Pauli Nieminen
If client calls DRI2CreateDrawable multiple times for same drawable DRI2 creates multiple references. Multiple references cause DRI2 send multiple invalidate events for same client. Problem is easy to spot from xtrace. For example following filtered snippet from problematic client: 000:<:0b85: 16

Re: [PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-25 Thread Jesse Barnes
On Mon, 25 Oct 2010 16:55:35 +0300 Pauli Nieminen wrote: > If client calls DRI2CreateDrawable multiple times for same drawable > DRI2 creates multiple references. Multiple references cause DRI2 send > multiple invalidate events for same client. I've been burned by the drawable handling code too

Re: [PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-29 Thread Rami Ylimäki
From resource management point of view this patch seems correct to me. Reviewed-by: Rami Ylimäki On 10/25/2010 04:55 PM, Pauli Nieminen wrote: If client calls DRI2CreateDrawable multiple times for same drawable DRI2 creates multiple references. Multiple references cause DRI2 send multiple inv

Re: [PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-29 Thread Kristian Høgsberg
On Mon, Oct 25, 2010 at 9:55 AM, Pauli Nieminen wrote: > If client calls DRI2CreateDrawable multiple times for same drawable > DRI2 creates multiple references. Multiple references cause DRI2 send > multiple invalidate events for same client. Yup, there is a leak, but I think we should implement