Re: [PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Alan Coopersmith
Peter Hutterer wrote: > I'm not quite comfortable with this patch, I don't think it solves the right > issue. the devicePrivate is copied into the MD as well, so that should in > theory work (though I admit much of that code was achieved by > trial-and-error). Looks more like a dangling pointer tha

Re: [PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Peter Hutterer
On Thu, Aug 12, 2010 at 12:09:00AM -0700, Alan Coopersmith wrote: > The pointer drivers that have anything other than a no-op there assume > the device passed to CtrlProc on has their flavor of devicePrivate, > which the Virtual Core Pointer won't. > > Fixes Solaris bug 6950572: > X mouse driver

Re: [PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Daniel Stone
On Thu, Aug 12, 2010 at 12:09:00AM -0700, Alan Coopersmith wrote: > The pointer drivers that have anything other than a no-op there assume > the device passed to CtrlProc on has their flavor of devicePrivate, > which the Virtual Core Pointer won't. > > Fixes Solaris bug 6950572: > X mouse driver

[PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Alan Coopersmith
The pointer drivers that have anything other than a no-op there assume the device passed to CtrlProc on has their flavor of devicePrivate, which the Virtual Core Pointer won't. Fixes Solaris bug 6950572: X mouse driver crashes Xorg during unplug-plug the usb mouse device http://bugs.opensolaris.