[PATCH] Drop valuator mask argument from GetKeyboardEvents

2014-12-15 Thread Peter Hutterer
Nothing was using it and if anyone had they would've gotten a warning and noticed that it doesn't actually work. Drop this, it has been unused for years. Input ABI 22 Signed-off-by: Peter Hutterer --- Jeremy, Jon, can you please build-test this? thanks Xext/xtest.c | 2 +-

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2014-12-16 Thread Daniel Stone
Hi, On 16 December 2014 at 04:43, Peter Hutterer wrote: > > @@ -1157,18 +1139,6 @@ GetKeyboardEvents(InternalEvent *events, > DeviceIntPtr pDev, int type, > set_key_up(pDev, key_code, KEY_POSTED); > } > > -clipValuators(pDev, &mask); > - > -set_valuators(pDev, event, &mask);

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2014-12-16 Thread Jeremy Huddleston Sequoia
I should be able to take a look over the winter break next week. --Jeremy > On Dec 15, 2014, at 20:43, Peter Hutterer wrote: > > Nothing was using it and if anyone had they would've gotten a warning and > noticed that it doesn't actually work. Drop this, it has been unused for > years. > > In

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2014-12-16 Thread Peter Hutterer
On Tue, Dec 16, 2014 at 08:15:31AM +, Daniel Stone wrote: > Hi, > > On 16 December 2014 at 04:43, Peter Hutterer > wrote: > > > > @@ -1157,18 +1139,6 @@ GetKeyboardEvents(InternalEvent *events, > > DeviceIntPtr pDev, int type, > > set_key_up(pDev, key_code, KEY_POSTED); > > } >

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2014-12-25 Thread Keith Packard
Peter Hutterer writes: > Nothing was using it and if anyone had they would've gotten a warning and > noticed that it doesn't actually work. Drop this, it has been unused for > years. > > Input ABI 22 Seems reasonable to fix the API for this, but the patch will need to wait until after 1.17 is r

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2015-01-28 Thread Jon TURNEY
On 16/12/2014 04:43, Peter Hutterer wrote: Nothing was using it and if anyone had they would've gotten a warning and noticed that it doesn't actually work. Drop this, it has been unused for years. Input ABI 22 Signed-off-by: Peter Hutterer --- Jeremy, Jon, can you please build-test this? thank

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2015-01-28 Thread Daniel Stone
Hi, On 17 December 2014 at 02:33, Peter Hutterer wrote: > On Tue, Dec 16, 2014 at 08:15:31AM +, Daniel Stone wrote: >> Are you sure this is right? Won't this change it from returning root_[xy] >> with current MD pointer co-ordinates to nothing/rubbish? > > no, this actually works, albeit most