[PATCH] Fix misc.h changes from d206d52f657c to work with Sun compilers

2011-09-22 Thread Alan Coopersmith
Studio 12.0 and later have builtin support for __builtin_constant_p and if you try to define a function with that name, they issue an error: ../include/misc.h, line 271: syntax error before or at: __builtin_constant_p For older versions, the fallback definition needs to specify it returns an int,

Re: [PATCH] Fix misc.h changes from d206d52f657c to work with Sun compilers

2011-09-22 Thread Matt Turner
On Thu, Sep 22, 2011 at 8:31 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Studio 12.0 and later have builtin support for __builtin_constant_p and if you try to define a function with that name, they issue an error: ../include/misc.h, line 271: syntax error before or at:

Re: [PATCH] Fix misc.h changes from d206d52f657c to work with Sun compilers

2011-09-22 Thread Jeremy Huddleston
Ack, this is gonna conflict with the patch I just sent. I'll roll this into mine and send a new one in a sec. On Sep 22, 2011, at 18:59, Matt Turner wrote: On Thu, Sep 22, 2011 at 8:31 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Studio 12.0 and later have builtin support for

Re: [PATCH] Fix misc.h changes from d206d52f657c to work with Sun compilers

2011-09-22 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net Seems like there ought to be a better way than listing which compilers support it, though. I considered an autoconf test to check whether __builtin_constant_p is defined, but that doesn't tell you which compiler is pulling in misc.h each time it's used.