this patch removes a bunch of redundant null checks for Xfree()
Signed-off-by: Harms
---
modules/im/ximcp/imCallbk.c| 6 +--
modules/im/ximcp/imDefIc.c | 7 ++-
modules/im/ximcp/imDefIm.c | 6 +--
modules/im/ximcp/imDefLkup.c | 13 +++---
modules/im/ximcp/imInt.c
remove more redundant NULL checks
note that _XkbFree() is realy Xfree()
Signed-off-by: Harms
---
src/GetHints.c | 2 +-
src/xkb/XKBAlloc.c | 3 +-
src/xkb/XKBExtDev.c | 6 ++--
src/xkb/XKBGeom.c | 11 +++---
src/xkb/XKBMAlloc.c | 99 +++
On 06/ 6/14 01:53 PM, walter harms wrote:
this patch removes a bunch of redundant null checks for Xfree()
Signed-off-by: Harms
Reviewed-by: Alan Coopersmith
and pushed to git master:
To ssh://git.freedesktop.org/git/xorg/lib/libX11
0b7fd7d..d81fed4 master -> master
--
Le samedi 07 juin 2014 à 11:54 +0200, walter harms a écrit :
> remove more redundant NULL checks
> note that _XkbFree() is realy Xfree()
A couple of notes:
1) Please tell me you used Coccinelle's spatch to create that patch!
2) Any reason not to replace XKBlibint.h's macros with their POSIX
equiv
Am 09.06.2014 01:07, schrieb Rémi Cardona:
> Le samedi 07 juin 2014 à 11:54 +0200, walter harms a écrit :
>> remove more redundant NULL checks
>> note that _XkbFree() is realy Xfree()
>
> A couple of notes:
>
> 1) Please tell me you used Coccinelle's spatch to create that patch!
i used smatch
>
Le lundi 09 juin 2014 à 07:58 +0200, walter harms a écrit :
> ntl i am not familiar with git and i feared i could not get
> them our properly.
> feel free to use indent.
If your patches cause more work for the maintainers, they won't be
applied. It's your responsibility to properly indent the code
On Sat, Jun 07, 2014 at 11:54:34AM +0200, walter harms wrote:
>
> remove more redundant NULL checks
> note that _XkbFree() is realy Xfree()
>
> Signed-off-by: Harms
pushed, with whitespace fixes and a typo fixed. Next time please:
* make sure the whitespaces match what is used in surrounding co
Am 18.06.2014 00:29, schrieb Peter Hutterer:
> On Sat, Jun 07, 2014 at 11:54:34AM +0200, walter harms wrote:
>>
>> remove more redundant NULL checks
>> note that _XkbFree() is realy Xfree()
>>
>> Signed-off-by: Harms
>
> pushed, with whitespace fixes and a typo fixed. Next time please:
> * make