Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-12-07 Thread Barry Scott
On Friday 08 October 2010 17:25:12 Matthias Hopf wrote: This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces with gdb. On errors it falls back to the generic method. Signed-off-by: Matthias Hopf mh...@suse.de --- This is a very useful patch, thanks for developing it.

Re: [PATCH] Use external tool for creating backtraces on crashes if available. (v2)

2010-11-15 Thread Jon TURNEY
On 08/10/2010 21:43, Alan Coopersmith wrote: Matthias Hopf wrote: This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces with gdb. On errors it falls back to the generic method. There's already similar code in the backtrace.c file in the # ifdef HAVE_PSTACK case, where

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-19 Thread Keith Packard
On Fri, 8 Oct 2010 18:25:12 +0200, Matthias Hopf mh...@suse.de wrote: +if (! (f = fdopen (fd, r))) { + ErrorF (xorg_backtrace_gdb internal error 2\n); + close (fd); + return 1; +} +status = 0; +while (fgets (buf, 256, f)) { + status++; + ErrorF(%s,

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-19 Thread Matthias Hopf
On Oct 19, 10 09:36:30 -0700, Keith Packard wrote: On Fri, 8 Oct 2010 18:25:12 +0200, Matthias Hopf mh...@suse.de wrote: +if (! (f = fdopen (fd, r))) { + ErrorF (xorg_backtrace_gdb internal error 2\n); + close (fd); + return 1; +} +status = 0; +while (fgets

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-11 Thread Matthias Hopf
On Oct 08, 10 16:21:05 -0700, Jeremy Huddleston wrote: On Oct 8, 2010, at 09:25, Matthias Hopf wrote: +#define XORG_BACKTRACE /usr/bin/xorg-backtrace Why hardcode /usr/bin instead of bindir? Because it was a first version :-) Good point, actually. Thanks! Matthias -- Matthias Hopf

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-11 Thread Matthias Hopf
On Oct 08, 10 13:43:38 -0700, Alan Coopersmith wrote: Matthias Hopf wrote: This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces with gdb. On errors it falls back to the generic method. There's already similar code in the backtrace.c file in the # ifdef HAVE_PSTACK

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-11 Thread Pat Kane
On Mon, Oct 11, 2010 at 4:50 AM, Matthias Hopf mh...@suse.de wrote: What do you think - would it make sense to call gdb on solaris if it is installed, or always pstack? My Solaris preference is to call stack dumpers in this order[1]: mdb, gdb, adb, pstack it would be nice if the script

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-11 Thread Matthias Hopf
On Oct 11, 10 06:20:10 -0500, Pat Kane wrote: On Mon, Oct 11, 2010 at 4:50 AM, Matthias Hopf mh...@suse.de wrote: What do you think - would it make sense to call gdb on solaris if it is installed, or always pstack? My Solaris preference is to call stack dumpers in this order[1]:

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-11 Thread Alan Coopersmith
Matthias Hopf wrote: On Oct 08, 10 13:43:38 -0700, Alan Coopersmith wrote: Matthias Hopf wrote: This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces with gdb. On errors it falls back to the generic method. There's already similar code in the backtrace.c file in the #

[PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-08 Thread Matthias Hopf
This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces with gdb. On errors it falls back to the generic method. Signed-off-by: Matthias Hopf mh...@suse.de --- os/backtrace.c | 82 1 files changed, 82 insertions(+),

[PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-08 Thread Matthias Hopf
$version = 1.0; $timeout = 5; @pkgs= ( xorg-x11-server, xorg-x11-driver-video, xorg-x11-driver-input, libpixman-1-0, libpciaccess0 ); $xtracmds= /etc/X11/xorg-backtrace-cmds; $pid=$ARGV[0]; if ($pid == 0) { print Usage: $0 pid\n; exit 1; } if (! -e /usr/bin/gdb) {

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-08 Thread Alan Coopersmith
Matthias Hopf wrote: This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces with gdb. On errors it falls back to the generic method. There's already similar code in the backtrace.c file in the # ifdef HAVE_PSTACK case, where we fork the external pstack process on Solaris

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-08 Thread Jeremy Huddleston
On Oct 8, 2010, at 09:25, Matthias Hopf wrote: +#define XORG_BACKTRACE /usr/bin/xorg-backtrace Why hardcode /usr/bin instead of bindir? ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: