Re: [PATCH] VGA arbiter: No need for arbitration around CreateGC.

2010-07-14 Thread Jamey Sharp
On Wed, Jul 14, 2010 at 7:44 AM, Vignatti Tiago (Nokia-MS/Helsinki) wrote: > On Wed, Jul 14, 2010 at 04:25:39PM +0200, ext Jamey Sharp wrote: >> First, I don't understand this use of signed-off-by. Did you mean >> reviewed-by? > > So I considered myself involved in the development of the patch (g

Re: [PATCH] VGA arbiter: No need for arbitration around CreateGC.

2010-07-14 Thread Vignatti Tiago (Nokia-MS/Helsinki)
Hey Jamey! On Wed, Jul 14, 2010 at 04:25:39PM +0200, ext Jamey Sharp wrote: > On Wed, Jul 14, 2010 at 6:25 AM, Vignatti Tiago (Nokia-MS/Helsinki) > wrote: > > On Wed, Jul 14, 2010 at 03:19:11PM +0200, Vignatti Tiago > > (Nokia-MS/Helsinki) wrote: > >> as discussed already in private: > >> > >>  

Re: [PATCH] VGA arbiter: No need for arbitration around CreateGC.

2010-07-14 Thread Jamey Sharp
Thanks for reviewing! (And thanks to Alex and Jeremy for this round of reviews too!) I don't quite understand your comments on this patch, though, Tiago. On Wed, Jul 14, 2010 at 6:25 AM, Vignatti Tiago (Nokia-MS/Helsinki) wrote: > On Wed, Jul 14, 2010 at 03:19:11PM +0200, Vignatti Tiago (Nokia-M

Re: [PATCH] VGA arbiter: No need for arbitration around CreateGC.

2010-07-14 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Wed, Jul 14, 2010 at 03:19:11PM +0200, Vignatti Tiago (Nokia-MS/Helsinki) wrote: > On Wed, Jul 14, 2010 at 12:35:12AM +0200, ext Jamey Sharp wrote: > > None of XAA, EXA, or UXA do any hardware access during CreateGC, so they > > don't need VGA arbitration. I haven't found any open source driver

Re: [PATCH] VGA arbiter: No need for arbitration around CreateGC.

2010-07-14 Thread Tiago Vignatti
On Wed, Jul 14, 2010 at 12:35:12AM +0200, ext Jamey Sharp wrote: > None of XAA, EXA, or UXA do any hardware access during CreateGC, so they > don't need VGA arbitration. I haven't found any open source drivers that > hook CreateGC, so they're safe. I'd be surprised if any driver directly > hooks Cr

[PATCH] VGA arbiter: No need for arbitration around CreateGC.

2010-07-13 Thread Jamey Sharp
None of XAA, EXA, or UXA do any hardware access during CreateGC, so they don't need VGA arbitration. I haven't found any open source drivers that hook CreateGC, so they're safe. I'd be surprised if any driver directly hooks CreateGC and does hardware access from it and needs VGA arbitration. Signe