Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-10-04 Thread Keith Packard
Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. As suggested by Gaeton, I've also removed --enable-maintainer-mode from autogen.sh Merged 262679d..4bf3eac master - master

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-10-02 Thread Julien Cristau
On Sun, Sep 30, 2012 at 16:45:17 -0400, Gaetan Nadon wrote: On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The historical background is that mode

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-10-02 Thread Dan Nicholson
LOn Oct 2, 2012 1:09 PM, Julien Cristau jcris...@debian.org wrote: On Sun, Sep 30, 2012 at 16:45:17 -0400, Gaetan Nadon wrote: On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable])

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-10-02 Thread Gaetan Nadon
On 12-10-02 04:09 PM, Julien Cristau wrote: On Sun, Sep 30, 2012 at 16:45:17 -0400, Gaetan Nadon wrote: On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-10-01 Thread Gaetan Nadon
On 12-09-27 05:12 PM, Adam Jackson wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-30 Thread Gaetan Nadon
On 12-09-29 04:37 PM, Dan Nicholson wrote: Some distros may prefer maintainer mode. A way to appease everyone is: AM_MAINTAINER_MODE([enable]) Oh, yeah. That would be the best. The historical background is that mode was added as a CVS tarball timestamp loss workaround before the git

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-29 Thread Chase Douglas
On Thu, Sep 27, 2012 at 2:12 PM, Adam Jackson a...@redhat.com wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-29 Thread Julien Cristau
On Fri, Sep 28, 2012 at 08:59:47 -0700, Dan Nicholson wrote: It's more correct for downstream in a sense. You don't accidentally get the autotools pulled in during your tarball build if you patched something. There are ways to accomplish that (touch) without maintainer mode, though. I recall

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-29 Thread Dan Nicholson
On Sep 29, 2012 11:19 AM, Chase Douglas chase.doug...@ubuntu.com wrote: On Thu, Sep 27, 2012 at 2:12 PM, Adam Jackson a...@redhat.com wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-28 Thread Adam Jackson
On 9/27/12 7:13 PM, Keith Packard wrote: Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. At one point, I'm almost certain that not having AM_MAINTAINER_MODE meant that you *never* got

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-28 Thread Dan Nicholson
On Sep 28, 2012 7:45 AM, Adam Jackson a...@redhat.com wrote: On 9/27/12 7:13 PM, Keith Packard wrote: Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. At one point, I'm almost

[PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-27 Thread Adam Jackson
All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac3bf26..b37e608 100644 ---

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-27 Thread Eric Anholt
Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-27 Thread Keith Packard
Adam Jackson a...@redhat.com writes: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. At one point, I'm almost certain that not having AM_MAINTAINER_MODE meant that you *never* got correct behaviour. When did that change? --

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-27 Thread Peter Hutterer
On Thu, Sep 27, 2012 at 05:12:19PM -0400, Adam Jackson wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH] configure: Stop using AM_MAINTAINER_MODE

2012-09-27 Thread Alex Deucher
On Thu, Sep 27, 2012 at 5:12 PM, Adam Jackson a...@redhat.com wrote: All this does is make it so editing configure.ac or Makefile.am doesn't rebuild the makefiles. Which is just stupid. YES PLEASE! Reviewed-by: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Adam Jackson