[PATCH] dix: Clear any existing selections before initializing privates

2013-12-30 Thread Andrew Eikum
If there is a selection left over from a previous execution of the main loop, and that selection has privates allocated for it, the X server will crash. This is because dixResetPrivates() resets the privates refcounts to zero without accounting for the reference held by the selection object. When t

Re: [PATCH] dix: Clear any existing selections before initializing privates

2014-02-03 Thread Adam Jackson
On Mon, 2013-12-30 at 09:15 -0600, Andrew Eikum wrote: > If there is a selection left over from a previous execution of the > main loop, and that selection has privates allocated for it, the X > server will crash. This is because dixResetPrivates() resets the > privates refcounts to zero without ac

Re: [PATCH] dix: Clear any existing selections before initializing privates

2014-02-14 Thread Andrew Eikum
On Mon, Feb 03, 2014 at 04:16:54PM -0500, Adam Jackson wrote: > On Mon, 2013-12-30 at 09:15 -0600, Andrew Eikum wrote: > > To fix this, we should delete any existing selections before calling > > dixResetPrivates(). This will properly release the selection's > > privates and avoid the crash. > > R

Re: [PATCH] dix: Clear any existing selections before initializing privates

2014-03-04 Thread Andrew Eikum
On Fri, Feb 14, 2014 at 09:41:12AM -0600, Andrew Eikum wrote: > On Mon, Feb 03, 2014 at 04:16:54PM -0500, Adam Jackson wrote: > > On Mon, 2013-12-30 at 09:15 -0600, Andrew Eikum wrote: > > > To fix this, we should delete any existing selections before calling > > > dixResetPrivates(). This will pro

Re: [PATCH] dix: Clear any existing selections before initializing privates

2014-03-06 Thread Keith Packard
Andrew Eikum writes: > Hi, we're less than a month out from the end of the 1.16 merge > window[1]. Thanks for the reminder, and sorry for not getting it merged earlier! da08316..78e508c master -> master -- keith.pack...@intel.com pgpiR6_F7UBnb.pgp Description: PGP signature _