Re: [PATCH] fb: reorder Bresenham error correction to avoid overshoot.

2012-08-14 Thread Keith Packard
Matt Turner writes: > From: Simon Schubert <2...@0x2c.org> > > When fbBresSolid draws a line, it can happen that after the last > pixel, the Bresenham error term overflows, and fbBresSolid paints > another pixel before adjusting the error term. > > However, if this happens on the last pixel (len=

Re: [PATCH] fb: reorder Bresenham error correction to avoid overshoot.

2012-08-14 Thread Matt Turner
On Mon, Aug 13, 2012 at 1:57 PM, Keith Packard wrote: > Matt Turner writes: > >> From: Simon Schubert <2...@0x2c.org> >> >> When fbBresSolid draws a line, it can happen that after the last >> pixel, the Bresenham error term overflows, and fbBresSolid paints >> another pixel before adjusting the e

Re: [PATCH] fb: reorder Bresenham error correction to avoid overshoot.

2012-08-13 Thread Keith Packard
Matt Turner writes: > From: Simon Schubert <2...@0x2c.org> > > When fbBresSolid draws a line, it can happen that after the last > pixel, the Bresenham error term overflows, and fbBresSolid paints > another pixel before adjusting the error term. > > However, if this happens on the last pixel (len=

Re: [PATCH] fb: reorder Bresenham error correction to avoid overshoot.

2012-08-13 Thread Mitch Davis
On Mon, Aug 13, 2012 at 12:40 AM, Matt Turner wrote: > > Mitch, can I get a Tested-by tag? Well including that patch certainly stopped the crashes for me at the time. So for that reason I'm happy to say: Tested-by: Mitch Davis However I have to say that that I'm no longer running that patch:

Re: [PATCH] fb: reorder Bresenham error correction to avoid overshoot.

2012-08-13 Thread Simon Schubert
Looking good! Signed-off-by: Simon Schubert <2...@0x2c.or> thanks, simon On 08/12/2012 06:40 PM, Matt Turner wrote: From: Simon Schubert <2...@0x2c.org> When fbBresSolid draws a line, it can happen that after the last pixel, the Bresenham error term overflows, and fbBresSolid paints another

[PATCH] fb: reorder Bresenham error correction to avoid overshoot.

2012-08-12 Thread Matt Turner
From: Simon Schubert <2...@0x2c.org> When fbBresSolid draws a line, it can happen that after the last pixel, the Bresenham error term overflows, and fbBresSolid paints another pixel before adjusting the error term. However, if this happens on the last pixel (len=0), this extra pixel might oversho

[PATCH] fb: reorder Bresenham error correction to avoid overshoot. #24274

2012-01-31 Thread Simon Schubert
When fbBresSolid draws a line, it can happen that after the last pixel, the Bresenham error term overflows, and fbBresSolid paints another pixel before adjusting the error term. However, if this happens on the last pixel (len=0), this extra pixel might overshoot the boundary, and, in rare cases,