Re: [PATCH] fix a sign problem with valuator data.

2010-10-17 Thread Peter Hutterer
On Fri, Oct 15, 2010 at 11:45:07AM -0400, Chase Douglas wrote: > On Thu, 2010-10-14 at 15:09 -0400, Joe Shaw wrote: > > From: Joe Shaw > > > > Without this patch, any negative valuator value is wrong when returned > > from XQueryDeviceState(). This is a regression from at least xserver > > 1.4.

Re: [PATCH] fix a sign problem with valuator data.

2010-10-15 Thread Chase Douglas
On Thu, 2010-10-14 at 15:09 -0400, Joe Shaw wrote: > From: Joe Shaw > > Without this patch, any negative valuator value is wrong when returned > from XQueryDeviceState(). This is a regression from at least xserver > 1.4. > > Valuator data is set in dix/getevents.c:set_valuators() by copying > s

[PATCH] fix a sign problem with valuator data.

2010-10-14 Thread Joe Shaw
From: Joe Shaw Without this patch, any negative valuator value is wrong when returned from XQueryDeviceState(). This is a regression from at least xserver 1.4. Valuator data is set in dix/getevents.c:set_valuators() by copying signed int values into an unsigned int field DeviceEvent.valuators.d