Re: [PATCH] libXt: util: don't link makestrs with target cflags

2012-11-21 Thread Jon TURNEY
On 19/11/2012 22:46, Thomas Petazzoni wrote: Hello, Anyone for this basic libXt patch? Thanks, Thomas On Fri, 16 Nov 2012 10:41:06 +0100, Thomas Petazzoni wrote: The line: AM_CFLAGS = $(XT_CFLAGS) in util/Makefile.am is wrong because it adds target cflags to the compilation of

Re: [PATCH] libXt: util: don't link makestrs with target cflags

2012-11-21 Thread Thomas Petazzoni
Dear Jon TURNEY, On Wed, 21 Nov 2012 14:19:53 +, Jon TURNEY wrote: It was useful in including string.h, and hence preventing a load of warnings :-), so perhaps you could include that instead. I'm not sure I totally buy your reasoning, as X11/Xos.h might be doing something necessary on

Re: [PATCH] libXt: util: don't link makestrs with target cflags

2012-11-19 Thread Thomas Petazzoni
Hello, Anyone for this basic libXt patch? Thanks, Thomas On Fri, 16 Nov 2012 10:41:06 +0100, Thomas Petazzoni wrote: The line: AM_CFLAGS = $(XT_CFLAGS) in util/Makefile.am is wrong because it adds target cflags to the compilation of makestrs, which is built for the build machine, which

[PATCH] libXt: util: don't link makestrs with target cflags

2012-11-16 Thread Thomas Petazzoni
The line: AM_CFLAGS = $(XT_CFLAGS) in util/Makefile.am is wrong because it adds target cflags to the compilation of makestrs, which is built for the build machine, which leads to build failures when cross-compiling. We also remove the inclusion of X11/Xos.h from makestrs.c, because it was the