[PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-17 Thread Jeremy Huddleston
https://bugs.freedesktop.org/show_bug.cgi?id=1837 Signed-off-by: Jeremy Huddleston --- hw/xfree86/common/xf86PciInfo.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86PciInfo.h b/hw/xfree86/common/xf86PciInfo.h index 356c7db..2825ece 100644 --- a/h

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-17 Thread Jeremy Huddleston
So, what's the point of having all these in common? Why don't they just live in the drivers? It seems silly to have these defined in the server's SDK rather than the driver that will consume them, since it means the driver will need to do #ifndef PCI_CHIP_GD7556 #define PCI_CHIP_GD7556 0x004C

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-29 Thread Tormod Volden
On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston wrote: > So, what's the point of having all these in common?  Why don't they just live > in the drivers?  It seems silly to have these defined in the server's SDK > rather than the driver that will consume them, since it means the driver will

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-29 Thread Jeremy Huddleston
On Oct 29, 2011, at 14:01, Tormod Volden wrote: > On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston > wrote: >> So, what's the point of having all these in common? Why don't they just >> live in the drivers? It seems silly to have these defined in the server's >> SDK rather than the drive

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-29 Thread Tormod Volden
On Sun, Oct 30, 2011 at 12:12 AM, Jeremy Huddleston wrote: > > On Oct 29, 2011, at 14:01, Tormod Volden wrote: > >> On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston >> wrote: >>> So, what's the point of having all these in common?  Why don't they just >>> live in the drivers?  It seems silly