Re: [PATCH] test: [v2] Validate server log reading more carefully in signal-logging test

2014-04-18 Thread Keith Packard
Jamey Sharp writes: > Reviewed-by: Jamey Sharp I've merged the series: 3119aae..c701124 master -> master -- keith.pack...@intel.com pgpyCUQg_dO_F.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lis

Re: [PATCH] test: [v2] Validate server log reading more carefully in signal-logging test

2014-04-18 Thread Jamey Sharp
Reviewed-by: Jamey Sharp Jamey On Fri, Apr 18, 2014 at 4:19 PM, Keith Packard wrote: > Check return value from fgets and strchr instead of assuming they > worked. > > [v2] > > Don't do any necessary work inside the assert call. > Also make sure the return value was long enough. > > Signed-off-b

[PATCH] test: [v2] Validate server log reading more carefully in signal-logging test

2014-04-18 Thread Keith Packard
Check return value from fgets and strchr instead of assuming they worked. [v2] Don't do any necessary work inside the assert call. Also make sure the return value was long enough. Signed-off-by: Keith Packard --- Responding to IRC review comments from Jamey test/signal-logging.c | 11 +++