Re: [PATCH] xkb: Do not use base group as an array index.

2012-12-20 Thread Peter Hutterer
On Thu, Dec 20, 2012 at 11:47:32AM +0100, Andreas Wettstein wrote: > > is there some sort of test-case that triggers this issue reliable? > > I found it when I tried: > > key { > type= "ONE_LEVEL", > symbols[Group1]= [ NoSymbol ], > actions[Group1]= [ LatchGroup(group=-1

Re: [PATCH] xkb: Do not use base group as an array index.

2012-12-20 Thread Andreas Wettstein
> is there some sort of test-case that triggers this issue reliable? I found it when I tried: key { type= "ONE_LEVEL", symbols[Group1]= [ NoSymbol ], actions[Group1]= [ LatchGroup(group=-1, clearLocks) ] }; and then hit F7. Using SetGroup(group=-1) should "work" equall

Re: [PATCH] xkb: Do not use base group as an array index.

2012-12-19 Thread Peter Hutterer
On Wed, Dec 19, 2012 at 06:13:21PM +0100, Andreas Wettstein wrote: > The base group is not brought into range and, therefore, using it as an array > index crashed the X server. Also, at this place, we should ignore locked > groups, but not latched groups. Therefore, use sum of base and latched >

[PATCH] xkb: Do not use base group as an array index.

2012-12-19 Thread Andreas Wettstein
The base group is not brought into range and, therefore, using it as an array index crashed the X server. Also, at this place, we should ignore locked groups, but not latched groups. Therefore, use sum of base and latched groups, brought into range. Signed-off-by: Andreas Wettstein --- xkb/xkb