Re: [PATCH 09/15] glamor: Unifdef the picture-format-to-format-and-type functions.

2014-02-14 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: There's no way these should be in a header file, but I'll leave that cleanup until later. I don't understand this comment; did you flip the order of 08/15 and 09/15 at some point and not rewrite it? Yep.

Re: [PATCH 09/15] glamor: Unifdef the picture-format-to-format-and-type functions.

2014-02-07 Thread Keith Packard
Eric Anholt e...@anholt.net writes: There's no way these should be in a header file, but I'll leave that cleanup until later. I don't understand this comment; did you flip the order of 08/15 and 09/15 at some point and not rewrite it? The change it self is: Reviewed-by: Keith Packard

[PATCH 09/15] glamor: Unifdef the picture-format-to-format-and-type functions.

2014-02-03 Thread Eric Anholt
There's no way these should be in a header file, but I'll leave that cleanup until later. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 50 +- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git