[PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-25 Thread Pauli Nieminen
DDX driver may implement schedule swap without GetMSC. In that case we can't call GetMSC in DRI2SwapBuffers. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de CC: Keith Packard kei...@keithp.com CC: Kristian Høgsberg

Re: [PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-25 Thread Jesse Barnes
On Mon, 25 Oct 2010 17:13:57 +0300 Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: DDX driver may implement schedule swap without GetMSC. In that case we can't call GetMSC in DRI2SwapBuffers. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com Reviewed-by: Mario Kleiner

Re: [PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-13 Thread Mario Kleiner
On Oct 7, 2010, at 10:06 AM, Pauli Nieminen wrote: On 07/10/10 00:42 +0200, ext Mario Kleiner wrote: On Oct 6, 2010, at 1:05 PM, Pauli Nieminen wrote: DDX driver may implement schedule swap without GetMSC. In that case we can't call GetMSC in DRI2SwapBuffers. I don't think this check is

Re: [PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-13 Thread Mario Kleiner
You can add a... Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de to your patch if you like. As far as i can see, such a driver would be limited to simple glXSwapBuffers() calls though if it doesn't know its own Oops, of course i meant a Reviewed-by: Mario Kleiner

Re: [PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-07 Thread Pauli Nieminen
On 07/10/10 00:42 +0200, ext Mario Kleiner wrote: On Oct 6, 2010, at 1:05 PM, Pauli Nieminen wrote: DDX driver may implement schedule swap without GetMSC. In that case we can't call GetMSC in DRI2SwapBuffers. I don't think this check is neccessary. Afaik if the ds-GetMSC entry point

[PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-06 Thread Pauli Nieminen
DDX driver may implement schedule swap without GetMSC. In that case we can't call GetMSC in DRI2SwapBuffers. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- hw/xfree86/dri2/dri2.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/2] DRI2: Avoid call to NULL pointer

2010-10-06 Thread Mario Kleiner
On Oct 6, 2010, at 1:05 PM, Pauli Nieminen wrote: DDX driver may implement schedule swap without GetMSC. In that case we can't call GetMSC in DRI2SwapBuffers. I don't think this check is neccessary. Afaik if the ds-GetMSC entry point isn't defined then ds-ScheduleSwap isn't defined either,