Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > Keith agrees that no unflip is necessary at all for per-window flips. > Just set the flip pixmap as the window pixmap when flipping, and be done > with it. Yup. Make sure it's set for the whole tree and things should 'just work'. -- -keith

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-07 12:35 AM, Roman Gilg wrote: > On Fri, Feb 2, 2018 at 5:11 PM, Michel Dänzer wrote: >> Taking a step back, do we even need to keep around the original pixmap >> and unflip to it at all? I had a chat on IRC about this with Keith a >> while ago, see the attached log

Re: [PATCH 14/19] present: Add window flip mode

Roman Gilg writes: > An unflip might happen at any time when the window is reconfigured and > the check_flip_window function returns false. Then we need again a > pixmap for the window to paint to. Yup, no different than any existing resize operation today. > This is indeed

Re: [PATCH 14/19] present: Add window flip mode

On Fri, Feb 2, 2018 at 5:11 PM, Michel Dänzer wrote: > Taking a step back, do we even need to keep around the original pixmap > and unflip to it at all? I had a chat on IRC about this with Keith a > while ago, see the attached log excerpt. > > Keith's main concern is that the

Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > In the vast majority of cases, it'll be the application's own window > anyway, so even accidents won't affect anything else. :) Agreed. Thanks for taking time to help me understand this. -- -keith signature.asc Description: PGP signature

Re: [PATCH 14/19] present: Add window flip mode

On Tue, 2018-02-06 at 12:21 +0100, Michel Dänzer wrote: > On 2018-02-05 09:08 PM, Adam Jackson wrote: > > On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > > > > > > > The inability to queue a presentation to the next MSC is more of a > > > > > step > > > > > back compared to the status

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-05 09:08 PM, Adam Jackson wrote: > On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > The inability to queue a presentation to the next MSC is more of a step back compared to the status quo. >>> >>> I'm about to go write up some ideas I'm working on that will make it

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-05 08:09 PM, Keith Packard wrote: > Michel Dänzer writes: > >> Ignoring the Security extension, the client has the same control over >> the contents of another application's window *using* the X protocol, >> doesn't it? > > Yeah, good point -- it could easily call

Re: [PATCH 14/19] present: Add window flip mode

On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > > > The inability to queue a presentation to the next MSC is more of a step > > > back compared to the status quo. > > > > I'm about to go write up some ideas I'm working on that will make it > > possible to more regularly display

Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > The motivation for this work is fullscreen applications with Xwayland. I think this could be equally useful for windowed applications as well as it should allow them to avoid the copy to the window pixmap and (perhaps) land in an overlay in whatever

Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > Ignoring the Security extension, the client has the same control over > the contents of another application's window *using* the X protocol, > doesn't it? Yeah, good point -- it could easily call DRI3BufferFromPixmap for the window pixmap and have

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-02 11:11 PM, Keith Packard wrote: > Michel Dänzer writes: > >> But this seems irrelevant for per-window flips. In this case, the window >> pixmap isn't used for anything else after flipping, so having direct >> access to the pixmap doesn't allow the client to do

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-02 09:56 PM, Keith Packard wrote: > Michel Dänzer writes: > >> On 2018-02-02 10:42 AM, Roman Gilg wrote: >>> It's because of what you made me aware of in the previous patch set: >>> the window original pixmap needs to have the updated content from the >>> flip

Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > Taking a step back, do we even need to keep around the original pixmap > and unflip to it at all? I had a chat on IRC about this with Keith a > while ago, see the attached log excerpt. I guess the question is whether the special access granted by the

Re: [PATCH 14/19] present: Add window flip mode

Michel Dänzer writes: > On 2018-02-02 10:42 AM, Roman Gilg wrote: >> It's because of what you made me aware of in the previous patch set: >> the window original pixmap needs to have the updated content from the >> flip Pixmap, otherwise for example screenshot applications

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-02 12:08 PM, Michel Dänzer wrote: > On 2018-02-02 10:42 AM, Roman Gilg wrote: > >> I also tried to not copy, but set the window pixmap to the flip >> pixmap. The problem I encountered here, is that the window original >> pixmap can be controlled by the client. > > How? > > >> And

Re: [PATCH 14/19] present: Add window flip mode

On 2018-02-02 10:42 AM, Roman Gilg wrote: > It's because of what you made me aware of in the previous patch set: > the window original pixmap needs to have the updated content from the > flip Pixmap, otherwise for example screenshot applications won't work > anymore. I tested it with xwd. FWIW,

Re: [PATCH 14/19] present: Add window flip mode

It's because of what you made me aware of in the previous patch set: the window original pixmap needs to have the updated content from the flip Pixmap, otherwise for example screenshot applications won't work anymore. I tested it with xwd. I also tried to not copy, but set the window pixmap to

Re: [PATCH 14/19] present: Add window flip mode

On 2018-01-29 02:34 PM, Roman Gilg wrote: > In contrast to screen flip mode this mode currently: > * supports flips per windows (these windows need to have the same size > as their parent windows with the same pixmap), > * always copies back to the original pixmap instead of pure flips, while >

[PATCH 14/19] present: Add window flip mode

In contrast to screen flip mode this mode currently: * supports flips per windows (these windows need to have the same size as their parent windows with the same pixmap), * always copies back to the original pixmap instead of pure flips, while giving the driver the flip pixmap provided by the