Re: [PATCH 2/2] [libX11] xcms/cmsProp: don't deal with uninitialized values, fail instead

2011-02-09 Thread Alan Coopersmith
On 02/ 4/11 01:43 AM, Erkki Seppälä wrote: Properly handle the return value of XGetWindowProperty by considering if after the loop as well. Using freed pointer prop_ret There were numerous things wrong in how this function interacted with XGetWindowProperty. None of the local variables

[PATCH 2/2] [libX11] xcms/cmsProp: don't deal with uninitialized values, fail instead

2011-02-04 Thread Erkki Seppälä
Properly handle the return value of XGetWindowProperty by considering if after the loop as well. Using freed pointer prop_ret There were numerous things wrong in how this function interacted with XGetWindowProperty. None of the local variables were initialized and remained that way if the call