Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Michel Dänzer
On 04.03.2015 07:07, Alex Deucher wrote: > On Tue, Mar 3, 2015 at 3:50 PM, Tormod Volden wrote: >> On Tue, Mar 3, 2015 at 9:21 PM, Alex Deucher wrote: >>> On Tue, Mar 3, 2015 at 2:21 PM, Tormod Volden wrote: On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: > About patch 1, since mgaDo

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Alex Deucher
On Tue, Mar 3, 2015 at 3:50 PM, Tormod Volden wrote: > On Tue, Mar 3, 2015 at 9:21 PM, Alex Deucher wrote: >> On Tue, Mar 3, 2015 at 2:21 PM, Tormod Volden wrote: >>> On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: About patch 1, since mgaDownloadFromScreen doesn't do anything fancier >>

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Tormod Volden
On Tue, Mar 3, 2015 at 9:21 PM, Alex Deucher wrote: > On Tue, Mar 3, 2015 at 2:21 PM, Tormod Volden wrote: >> On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: >>> About patch 1, since mgaDownloadFromScreen doesn't do anything fancier >>> than memcpy, you can just remove it altogether and leave

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Alex Deucher
On Tue, Mar 3, 2015 at 2:21 PM, Tormod Volden wrote: > On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: >> On 03.03.2015 05:01, Tormod Volden wrote: >>> mgaDownloadFromScreen(PixmapPtr pSrc, int x, int y, int w, int h, >>>char *dst, int dst_pitch) >>> { >>> +if (!

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Tormod Volden
On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: > On 03.03.2015 05:01, Tormod Volden wrote: >> mgaDownloadFromScreen(PixmapPtr pSrc, int x, int y, int w, int h, >>char *dst, int dst_pitch) >> { >> +if (!pSrc) >> + return FALSE; >> + >> PMGA(pSrc); >> >>

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-02 Thread Michel Dänzer
On 03.03.2015 05:01, Tormod Volden wrote: > From: Tormod Volden > > Thanks to Connor Behan for the suggestion. > > Signed-off-by: Tormod Volden > --- > > Also not tested on hardware. > > Tormod > > src/mga_exa.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mga_exa.c b

[PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-02 Thread Tormod Volden
From: Tormod Volden Thanks to Connor Behan for the suggestion. Signed-off-by: Tormod Volden --- Also not tested on hardware. Tormod src/mga_exa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mga_exa.c b/src/mga_exa.c index 24a7328..cb17ad8 100644 --- a/src/mga_exa.c +++ b/s