[PATCH 28/32] [libx11] Comparing array against NULL is not useful "&xkb->server->vmods != NULL"

2011-01-27 Thread Erkki Seppälä
Removed superfluous comparison. Signed-off-by: Erkki Seppälä --- src/xkb/XKBMisc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c index fc5ae5f..4aa1f73 100644 --- a/src/xkb/XKBMisc.c +++ b/src/xkb/XKBMisc.c @@ -619,7 +619,7 @@ Key

Re: [PATCH 28/32] [libx11] Comparing array against NULL is not useful "&xkb->server->vmods != NULL"

2011-01-27 Thread walter harms
Am 27.01.2011 08:54, schrieb Erkki Seppälä: > Removed superfluous comparison. > > Signed-off-by: Erkki Seppälä > --- > src/xkb/XKBMisc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c > index fc5ae5f..4aa1f73 100644 > --- a

Re: [PATCH 28/32] [libx11] Comparing array against NULL is not useful "&xkb->server->vmods != NULL"

2011-01-27 Thread Dirk Wallenstein
On Thu, Jan 27, 2011 at 10:50:19AM +0100, walter harms wrote: > > > Am 27.01.2011 08:54, schrieb Erkki Seppälä: > > Removed superfluous comparison. > > > > Signed-off-by: Erkki Seppälä > > --- > > src/xkb/XKBMisc.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff -

Re: [PATCH 28/32] [libx11] Comparing array against NULL is not useful "&xkb->server->vmods != NULL"

2011-01-27 Thread Alan Coopersmith
On 01/27/11 01:50 AM, walter harms wrote: >> diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c >> index fc5ae5f..4aa1f73 100644 >> --- a/src/xkb/XKBMisc.c > I am not an expert on X11 coding style: It's XKB - the style doesn't match the rest of X11, nor anything you ever want to see again. Clea