Re: [PATCH 29/37] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print as gnu_printf. Fix resulting warnings.

2013-11-18 Thread Ian Romanick
On 11/17/2013 12:01 AM, Keith Packard wrote: > Signed-off-by: Keith Packard With Alan's suggestion, this patch is Reviewed-by: Ian Romanick > --- > hw/xfree86/dri/dri.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/hw/xfree86/dri/dr

Re: [PATCH 29/37] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print as gnu_printf. Fix resulting warnings.

2013-11-17 Thread Keith Packard
Alan Coopersmith writes: > Why not use _X_ATTRIBUTE_PRINTF from like all the existing > uses in the X server code? It already has the right compiler/version checks > built in. Thanks! Will switch. -- keith.pack...@intel.com pgpqvWqXdvi8A.pgp Description: PGP signature

Re: [PATCH 29/37] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print as gnu_printf. Fix resulting warnings.

2013-11-17 Thread Alan Coopersmith
On 11/17/13 12:01 AM, Keith Packard wrote: Signed-off-by: Keith Packard --- hw/xfree86/dri/dri.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c index 6292e87..959288d 100644 --- a/hw/xfree86/dri/

[PATCH 29/37] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print as gnu_printf. Fix resulting warnings.

2013-11-17 Thread Keith Packard
Signed-off-by: Keith Packard --- hw/xfree86/dri/dri.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c index 6292e87..959288d 100644 --- a/hw/xfree86/dri/dri.c +++ b/hw/xfree86/dri/dri.c @@ -100,6 +100