Re: [PATCH 32/32] [libx11] Cannot reach dead statement return NULL;

2011-01-28 Thread Erkki Seppala
On 27.01.2011 10:30, Alan Coopersmith wrote: prop-name= (char *)_XkbAlloc(strlen(name)+1); -if (!name) - return NULL; strcpy(prop-name,name); prop-value= (char *)_XkbAlloc(strlen(value)+1); if (!value) { Looks like that should instead be checking if

[PATCH 32/32] [libx11] Cannot reach dead statement return NULL;

2011-01-27 Thread Erkki Seppälä
Removed superfluous check for NULL. name == NULL is already checked at the function entry. Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi --- src/xkb/XKBGAlloc.c |2 -- 1 files changed, 0 insertions(+), 2

Re: [PATCH 32/32] [libx11] Cannot reach dead statement return NULL;

2011-01-27 Thread Alan Coopersmith
On 01/26/11 11:54 PM, Erkki Seppälä wrote: Removed superfluous check for NULL. name == NULL is already checked at the function entry. Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi ---

Re: [PATCH 32/32] [libx11] Cannot reach dead statement return NULL;

2011-01-27 Thread walter harms
Am 27.01.2011 08:54, schrieb Erkki Seppälä: Removed superfluous check for NULL. name == NULL is already checked at the function entry. Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi ---