Re: [PATCH 8/8] modesetting: Use GBM for buffer allocations if Glamor supports it.

2014-12-09 Thread Michel Dänzer
On 10.12.2014 09:55, Kenneth Graunke wrote: > For performance, Glamor wants to render to tiled buffers, not linear > ones. Using GBM allows us to pick the 3D driver's preferred tiling > modes. IMO that's just a bonus of this change. :) The main point is that dumb BOs are not suitable for hardware

Re: [PATCH 8/8] modesetting: Use GBM for buffer allocations if Glamor supports it.

2014-12-09 Thread Dave Airlie
On 10 December 2014 at 10:55, Kenneth Graunke wrote: > For performance, Glamor wants to render to tiled buffers, not linear > ones. Using GBM allows us to pick the 3D driver's preferred tiling > modes. I think this would be a lot cleaner as +#ifdef GLAMOR_HAS_GBM +struct gbm_device *gbm; +#

[PATCH 8/8] modesetting: Use GBM for buffer allocations if Glamor supports it.

2014-12-09 Thread Kenneth Graunke
For performance, Glamor wants to render to tiled buffers, not linear ones. Using GBM allows us to pick the 3D driver's preferred tiling modes. Signed-off-by: Kenneth Graunke --- hw/xfree86/drivers/modesetting/driver.c | 20 +++-- hw/xfree86/drivers/modesetting/drmmode_display.c | 5