[PATCH app-sessreg] Add AC_GNU_SOURCE which provides needed WTMPX_FILE define

2010-02-03 Thread Gaetan Nadon
The WTMPX_FILE is only defined under __USE_GNU conditional compilation. Autoconf provides AC_GNU_SOURCE which is a subset of AC_USE_SYSTEM_EXTENSIONS. It must be expanded before any other macros that uses the compiler. To reduce the risk of being misplaced, the statements have been grouped (mostly

Re: [PATCH app-sessreg] Add AC_GNU_SOURCE which provides needed WTMPX_FILE define

2010-02-03 Thread Jeremy Huddleston
No adverse effects on darwin (non-GNU) Tested-by (on darwin): Jeremy Huddleston On Feb 3, 2010, at 11:28, Gaetan Nadon wrote: The WTMPX_FILE is only defined under __USE_GNU conditional compilation. Autoconf provides AC_GNU_SOURCE which is a subset of AC_USE_SYSTEM_EXTENSIONS. It must be expa

Re: [PATCH app-sessreg] Add AC_GNU_SOURCE which provides needed WTMPX_FILE define

2010-02-03 Thread Alan Coopersmith
Any reason to not just use AC_USE_SYSTEM_EXTENSIONS? I'm not aware of any problems we've hit in the other modules that are using that. -alan- Gaetan Nadon wrote: > The WTMPX_FILE is only defined under __USE_GNU conditional > compilation. Autoconf provides AC_GNU_SOURCE which is a subset o

Re: [PATCH app-sessreg] Add AC_GNU_SOURCE which provides needed WTMPX_FILE define

2010-02-03 Thread Gaetan Nadon
On Wed, 2010-02-03 at 12:26 -0800, Alan Coopersmith wrote: > Any reason to not just use AC_USE_SYSTEM_EXTENSIONS? > I'm not aware of any problems we've hit in the other > modules that are using that. > > -alan- > No special reasons, other than being cautious about just using the minimum a