[PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-23 Thread Egbert Eich
From: Egbert Eich copy_front() calls sna_pixmap_force_to_gpu() which may fail. If we pretend to have been successful and continue the caller sna_mode_resize() may finish successfully pretending a mode change has succeeded which might leave a mode behind which is unusable. This patch makes copy_fr

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-23 Thread Chris Wilson
On Wed, Sep 24, 2014 at 08:17:59AM +0200, Egbert Eich wrote: > From: Egbert Eich > > copy_front() calls sna_pixmap_force_to_gpu() which may fail. If we pretend > to have been successful and continue the caller sna_mode_resize() may finish > successfully pretending a mode change has succeeded whic

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
Chris Wilson writes: > On Wed, Sep 24, 2014 at 08:17:59AM +0200, Egbert Eich wrote: > > From: Egbert Eich > > > > copy_front() calls sna_pixmap_force_to_gpu() which may fail. If we pretend > > to have been successful and continue the caller sna_mode_resize() may > > finish > > successfull

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > Here is the test scenario: > > Pineview Chipset, start a bare X server (without the other patch applied > to the driver), start xterm on it. > > On my system 'xrandr -q' gives: > > Screen 0: minimum 8 x 8, current 1366 x 768, maximum

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
Chris Wilson writes: > On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > > > > For panning one needs to be able to draw into the screen pixmap outside > > of the area exposed by the crtc. > > Note that the screen pixmap still exists and is drawn into by the > clients. What sh

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: > Chris Wilson writes: > > On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > > > > > > For panning one needs to be able to draw into the screen pixmap outside > > > of the area exposed by the crtc. > > > > Note that

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: > Chris Wilson writes: > > On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > > > > > > For panning one needs to be able to draw into the screen pixmap outside > > > of the area exposed by the crtc. > > > > Note that

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Egbert Eich
Chris Wilson writes: > On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: > > Chris Wilson writes: > > > On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > > > > > > > > For panning one needs to be able to draw into the screen pixmap > > outside > > > > of the ar

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-25 Thread Egbert Eich
Chris Wilson writes: > On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: > > Chris Wilson writes: > > > On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > > > > > > > > For panning one needs to be able to draw into the screen pixmap > > outside > > > > of the ar

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-25 Thread Chris Wilson
On Thu, Sep 25, 2014 at 03:16:23PM +0200, Egbert Eich wrote: > Chris Wilson writes: > > On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: > > > Chris Wilson writes: > > > > On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: > > > > > > > > > > For panning one needs to

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-25 Thread Chris Wilson
On Thu, Sep 25, 2014 at 04:10:26PM +0100, Chris Wilson wrote: > On Thu, Sep 25, 2014 at 03:16:23PM +0200, Egbert Eich wrote: > > Chris Wilson writes: > > > On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: > > > > Chris Wilson writes: > > > > > On Wed, Sep 24, 2014 at 12:34:29PM +020

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-26 Thread Egbert Eich
Hi Chris, Chris Wilson writes: > > Also realised that even this should be fixed up as a last resort by > falling back to the shadow CRTC allocation. That band-aid should be > working again. > > Hopefully > > commit 9f7c1a4c4f2a6352263c36e75a984ed4095adbc0 > Author: Chris Wilson > Da

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-26 Thread Chris Wilson
On Fri, Sep 26, 2014 at 06:05:07PM +0200, Egbert Eich wrote: > > Hi Chris, > > Chris Wilson writes: > > > > Also realised that even this should be fixed up as a last resort by > > falling back to the shadow CRTC allocation. That band-aid should be > > working again. > > > > Hopefully > >

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-26 Thread Chris Wilson
On Fri, Sep 26, 2014 at 06:05:07PM +0200, Egbert Eich wrote: > From: Egbert Eich > Date: Fri, 26 Sep 2014 17:57:55 +0200 > Subject: [PATCH driver/intel] In sna_create_screen_resources() don't make > sna_pixmap_force_to_gpu() mandatory > > Signed-off-by: Egbert Eich Pushed a slight variation,