Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-03-07 Thread Aaron Plattner
On 02/21/2017 08:16 AM, Arthur Huillet wrote: > With Jamey's review and Julien's questions answered, would someone > please push that change to libX11, unless there are objections to the > patch? > > Thank you $ git push upstream HEAD:master Counting objects: 4, done. Delta compression using up

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-21 Thread Arthur Huillet
With Jamey's review and Julien's questions answered, would someone please push that change to libX11, unless there are objections to the patch? Thank you -- A. Huillet On 2017-02-02 9:45, Arthur Huillet wrote: On Thu, 2 Feb 2017 09:05:03 +0100 Julien Cristau wrote: On

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-02 Thread Arthur Huillet
On Thu, 2 Feb 2017 09:05:03 +0100 Julien Cristau wrote: > On Wed, Feb 1, 2017 at 15:02:41 +0100, arthur.huil...@free.fr wrote: > > > It is legal for an application to make Xlib calls during _fini, and that is > > useful for an OpenGL driver to avoid resource leaks on the

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-02 Thread Julien Cristau
On Wed, Feb 1, 2017 at 15:02:41 +0100, arthur.huil...@free.fr wrote: > It is legal for an application to make Xlib calls during _fini, and that is > useful for an OpenGL driver to avoid resource leaks on the X server side, for > example in the dlopen/dlclose case. However, the driver can not

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Arthur Huillet
On Wed, 1 Feb 2017 12:23:30 -0800 Jamey Sharp wrote: > On Feb 1, 2017 9:23 AM, "Arthur Huillet" wrote: > > On Wed, 1 Feb 2017 09:12:47 -0800 > Jamey Sharp wrote: > > I'm a little confused by the notes in the commit message about

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Jamey Sharp
On Feb 1, 2017 9:23 AM, "Arthur Huillet" wrote: On Wed, 1 Feb 2017 09:12:47 -0800 Jamey Sharp wrote: > I'm a little confused by the notes in the commit message about whether this > is legal. I don't know why it should be considered legal to use a

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Arthur Huillet
Hi Jamey, On Wed, 1 Feb 2017 09:12:47 -0800 Jamey Sharp wrote: > I don't love this either, but it's Xlib; there's little there to love. ;-) > I don't see anything fundamentally wrong with this approach. Thanks. > I'm a little confused by the notes in the commit message

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread Jamey Sharp
I don't love this either, but it's Xlib; there's little there to love. ;-) I don't see anything fundamentally wrong with this approach. I'm a little confused by the notes in the commit message about whether this is legal. I don't know why it should be considered legal to use a Display from a

[PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

2017-02-01 Thread arthur . huillet
From: Arthur Huillet _XReply isn't reentrant, and it can lead to deadlocks when the default error handler is called: _XDefaultError calls exit(1). It is called indirectly by _XReply when a X protocol error comes in that isn't filtered/handled by an extension or the