Re: [PATCH libX11] include: Add GetReqSized() for request buffers of specific size

2011-10-17 Thread Jamey Sharp
On Mon, Oct 17, 2011 at 09:19:02AM +1000, Peter Hutterer wrote: On Fri, Oct 14, 2011 at 06:42:02PM +0200, Jamey Sharp wrote: The GetReq family of macros is so evil. I'm not going to go so far as to NAK this patch or anything, but please consider whether you can implement this as a proper

Re: [PATCH libX11] include: Add GetReqSized() for request buffers of specific size

2011-10-16 Thread Peter Hutterer
On Fri, Oct 14, 2011 at 06:42:02PM +0200, Jamey Sharp wrote: The GetReq family of macros is so evil. I'm not going to go so far as to NAK this patch or anything, but please consider whether you can implement this as a proper function or something. Perhaps: void *XGetReq(CARD8 reqType, size_t

Re: [PATCH libX11] include: Add GetReqSized() for request buffers of specific size

2011-10-14 Thread Chase Douglas
On 10/13/2011 10:17 PM, Peter Hutterer wrote: Some XI2 requests change in size over different versions and libXi would need to hack around GetReq and GetReqExtra. Add a new GetReqSized so the library can explicitly specify the size of the request in 4-byte units. Signed-off-by: Peter

Re: [PATCH libX11] include: Add GetReqSized() for request buffers of specific size

2011-10-14 Thread Jamey Sharp
The GetReq family of macros is so evil. I'm not going to go so far as to NAK this patch or anything, but please consider whether you can implement this as a proper function or something. Perhaps: void *XGetReq(CARD8 reqType, size_t sz); (I think the other macros could be re-implemented on top of

[PATCH libX11] include: Add GetReqSized() for request buffers of specific size

2011-10-13 Thread Peter Hutterer
Some XI2 requests change in size over different versions and libXi would need to hack around GetReq and GetReqExtra. Add a new GetReqSized so the library can explicitly specify the size of the request in 4-byte units. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Instead of hacking