[PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/properties.c |2 +- src/synapticsstr.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/properties.c

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Cyril Brulebois
Daniel Stone dan...@fooishbar.org (04/01/2012): Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. Signed-off-by: Daniel Stone dan...@fooishbar.org Reminds me of 1325553573-13476-1-git-send-email-peter.hutte...@who-t.net:

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Hi, On 4 January 2012 17:30, Cyril Brulebois k...@debian.org wrote: Daniel Stone dan...@fooishbar.org (04/01/2012): Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. Signed-off-by: Daniel Stone dan...@fooishbar.org Reminds me of

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Hi, For the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel On 3 January 2012 00:44, Peter Hutterer peter.hutte...@who-t.net wrote: synaptics.c: In function 'SynapticsPreInit': synaptics.c:731:18: warning: assignment discards 'const' qualifier from pointer target type

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Mark Kettenis
X-Original-To: xorg-devel@lists.x.org From: Daniel Stone dan...@fooishbar.org Date: Wed, 4 Jan 2012 17:02:30 + Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. If Daniel Kurtz's analysis of the problem is right, and I believe it is,

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Hi, On 4 January 2012 18:55, Mark Kettenis mark.kette...@xs4all.nl wrote: X-Original-To: xorg-devel@lists.x.org From: Daniel Stone dan...@fooishbar.org Date: Wed,  4 Jan 2012 17:02:30 + Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code.

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Mark Kettenis
Date: Wed, 4 Jan 2012 19:01:31 + From: Daniel Stone Hi, If Daniel Kurtz's analysis of the problem is right, and I believe it is, then this diff is just as wrong as the previous diff from Peter. It also means that the real culprit is Peter's change to constify

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Peter Hutterer
On Wed, Jan 04, 2012 at 08:41:25PM +0100, Mark Kettenis wrote: Date: Wed, 4 Jan 2012 19:01:31 + From: Daniel Stone Hi, If Daniel Kurtz's analysis of the problem is right, and I believe it is, then this diff is just as wrong as the previous diff from Peter. It also means

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Chase Douglas
On 01/04/2012 02:40 PM, Peter Hutterer wrote: On Wed, Jan 04, 2012 at 08:41:25PM +0100, Mark Kettenis wrote: Date: Wed, 4 Jan 2012 19:01:31 + From: Daniel Stone Hi, If Daniel Kurtz's analysis of the problem is right, and I believe it is, then this diff is just as wrong as the previous

[PATCH synaptics] Constify priv-device

2012-01-02 Thread Peter Hutterer
synaptics.c: In function 'SynapticsPreInit': synaptics.c:731:18: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/properties.c |2 +- src/synapticsstr.h |2 +- 2 files changed, 2