[PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-03-08 Thread Julian Pidancet
Some instructions are not emulated correctly by x86emu when they are prefixed by the 0x66 opcode. I've identified problems in the emulation of these intructions: ret, enter, leave, iret and some forms of call. Most of the time, the problem is that these instructions should push or pop 32-bit value

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-03-08 Thread Guillem Jover
On Fri, 2012-03-09 at 00:02:55 +, Julian Pidancet wrote: > Some instructions are not emulated correctly by x86emu when they > are prefixed by the 0x66 opcode. > I've identified problems in the emulation of these intructions: ret, > enter, leave, iret and some forms of call. > > Most of the tim

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-03-15 Thread Julian Pidancet
On Fri, Mar 9, 2012 at 2:08 AM, Guillem Jover wrote: > On Fri, 2012-03-09 at 00:02:55 +, Julian Pidancet wrote: >> Some instructions are not emulated correctly by x86emu when they >> are prefixed by the 0x66 opcode. >> I've identified problems in the emulation of these intructions: ret, >> ent

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-03-15 Thread Julian Pidancet
On Thu, Mar 15, 2012 at 10:39 PM, Julian Pidancet wrote: > On Fri, Mar 9, 2012 at 2:08 AM, Guillem Jover wrote: >> On Fri, 2012-03-09 at 00:02:55 +, Julian Pidancet wrote: >>> Some instructions are not emulated correctly by x86emu when they >>> are prefixed by the 0x66 opcode. >>> I've identi

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-04-01 Thread Julian Pidancet
On Thu, Mar 15, 2012 at 10:45 PM, Julian Pidancet wrote: > On Thu, Mar 15, 2012 at 10:39 PM, Julian Pidancet > wrote: >> On Fri, Mar 9, 2012 at 2:08 AM, Guillem Jover wrote: >>> On Fri, 2012-03-09 at 00:02:55 +, Julian Pidancet wrote: Some instructions are not emulated correctly by x86e

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-04-01 Thread Michael Tokarev
What is the outcome of this patch? I mean, does it actually fix something visible, instead of a potential problem? [] >>> Anyone interested in this ? Is there a maintainer for x86emu ? The >>> MAINTAINERS file in xorg-docs doesn't mention anything about it. >> >> CCed: Adam Jackson >> >> Adam, yo

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-04-02 Thread Julian Pidancet
On Mon, Apr 2, 2012 at 6:51 AM, Michael Tokarev wrote: > What is the outcome of this patch?  I mean, does it actually fix > something visible, instead of a potential problem? > x86emu in it's current state is unable to emulate correctly 16bit code that has been produced by GCC. This patch is an a