Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Maarten Lankhorst
Hey, Op 19-03-13 11:27, Chris Wilson schreef: > On Tue, Mar 19, 2013 at 11:02:14AM +0100, Maarten Lankhorst wrote: >> Hey, >> >> Op 19-03-13 10:21, Chris Wilson schreef: >>> On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: Update: Squashes a couple commits to avoid potential

Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Dave Airlie
> > Because of the delayed fput in recent kernels, it is possible for plymouth to > exit and not drop master right away. > It's put onto a workqueue to be freed slightly later. Xorg-server starts in > the meantime, opens a fd, but because the fd > hasn't been closed by plymouth yet, it didn't get

Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Maarten Lankhorst
Op 19-03-13 12:10, Dave Airlie schreef: >> Because of the delayed fput in recent kernels, it is possible for plymouth >> to exit and not drop master right away. >> It's put onto a workqueue to be freed slightly later. Xorg-server starts in >> the meantime, opens a fd, but because the fd >> hasn't

Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Chris Wilson
On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote: > The drmSetMaster call is needed, but the spinning is really just waiting for > the workqueue to run. > > bryce's patch never worked, it just caused it to try drmsetinterfaceversion > for a few seconds before timing out. That ca

Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-20 Thread Maarten Lankhorst
Hey, Op 19-03-13 22:13, Chris Wilson schreef: > On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote: >> The drmSetMaster call is needed, but the spinning is really just waiting for >> the workqueue to run. >> >> bryce's patch never worked, it just caused it to try drmsetinterfacever

Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-20 Thread Maarten Lankhorst
Op 20-03-13 09:40, Maarten Lankhorst schreef: > Hey, > > Op 19-03-13 22:13, Chris Wilson schreef: >> On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote: >>> The drmSetMaster call is needed, but the spinning is really just waiting >>> for the workqueue to run. >>> >>> bryce's patch n

Re: [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-20 Thread Chris Wilson
On Wed, Mar 20, 2013 at 09:40:04AM +0100, Maarten Lankhorst wrote: > Is the drmSetInterfaceVersion call really needed here? If I look at > DRM_IOCTL_GET_UNIQUE, > I don't see any requirement of drm master or anything, so it looks to me like > for this specific race > the drmSetInterfaceVersion ca