Re: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol

2013-06-11 Thread Alan Coopersmith
On 06/ 9/13 10:00 AM, Julien Cristau wrote: The padding is *before* the rate field, so the rate is placed on a 32bit boundary. This change adds explicit padding between height and rate, and removes extraneous padding after the rate field, which the server never sent and xlib never read. This ch

Re: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol

2013-06-11 Thread Daniel Martin
On 10 June 2013 11:55, Julien Cristau wrote: > On Mon, Jun 10, 2013 at 11:41:00 +0200, Daniel Martin wrote: > >> On 9 June 2013 19:00, Julien Cristau wrote: >> > The padding is *before* the rate field, so the rate is placed on a 32bit >> > boundary. This change adds explicit padding between heig

Re: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol

2013-06-10 Thread Kevin Ryde
Julien Cristau writes: > > Both it and libXv use sz_xvEncodingInfo, which is ok. Am I right code is always supposed to use the "sz_" constants, not sizeof? Not that that would be an excuse to break anything. If in doubt I suppose could put the intended pad before, but leave the pad at the end a

Re: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol

2013-06-10 Thread Julien Cristau
On Mon, Jun 10, 2013 at 11:41:00 +0200, Daniel Martin wrote: > On 9 June 2013 19:00, Julien Cristau wrote: > > The padding is *before* the rate field, so the rate is placed on a 32bit > > boundary. This change adds explicit padding between height and rate, > > and removes extraneous padding afte

Re: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol

2013-06-10 Thread Daniel Martin
On 9 June 2013 19:00, Julien Cristau wrote: > The padding is *before* the rate field, so the rate is placed on a 32bit > boundary. This change adds explicit padding between height and rate, > and removes extraneous padding after the rate field, which the server > never sent and xlib never read. >

[PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol

2013-06-09 Thread Julien Cristau
The padding is *before* the rate field, so the rate is placed on a 32bit boundary. This change adds explicit padding between height and rate, and removes extraneous padding after the rate field, which the server never sent and xlib never read. This changes sizeof(xvEncodingInfo). Hopefully that'