Re: [PATCH xquartz 02/10] randr: Correct a miscall of abs() to instead call fabs()

2015-10-16 Thread Keith Packard
Alan Coopersmith writes: > Long long ago, the xserver's include/misc.h had: > #define abs(a) ((a) > 0 ? (a) : -(a)) > which worked for code like this, but git history says that was removed in > XFree86 4.3.0.1 (commit d568221710959cf in the current xserver git repo) > and we've just been sloppy e

Re: [PATCH xquartz 02/10] randr: Correct a miscall of abs() to instead call fabs()

2015-10-14 Thread Alan Coopersmith
Long long ago, the xserver's include/misc.h had: #define abs(a) ((a) > 0 ? (a) : -(a)) which worked for code like this, but git history says that was removed in XFree86 4.3.0.1 (commit d568221710959cf in the current xserver git repo) and we've just been sloppy ever since. Reviewed-by: Alan Cooper

[PATCH xquartz 02/10] randr: Correct a miscall of abs() to instead call fabs()

2015-10-14 Thread Jeremy Huddleston Sequoia
rrtransform.c:124:22: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value,Semantic Issue] if ((v = abs(f_transform->m[j][i])) > max) ^ rrtransform.c:124:22: note: use function 'fabs' instead [Semantic