Re: [PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

2015-10-15 Thread walter harms
some nitpicking ... man 3 difftime i pretty sure it will cause a fundamental change ... just my 2 cents re, wh Am 15.10.2015 00:13, schrieb Jeremy Huddleston Sequoia: > xdmauth.c:230:13: warning: absolute value function 'abs' given an argument of > type 'long' but has parameter of > type >

Re: [PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

2015-10-15 Thread Jeremy Huddleston Sequoia
Can you elaborate on your concern? Are you suggesting using difftime() instead of fabs()? I agree that would probably be a good idea, but I don't see why this change would look scary to you. --Jeremy > On Oct 15, 2015, at 06:47, walter harms wrote: > > some nitpicking ... >

[PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

2015-10-14 Thread Jeremy Huddleston Sequoia
xdmauth.c:230:13: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value,Semantic Issue] if (abs(now - client->time) > TwentyFiveMinutes) { ^ xdmauth.c:230:13: note:

Re: [PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

2015-10-14 Thread Alan Coopersmith
On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: xdmauth.c:230:13: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value,Semantic Issue] if (abs(now - client->time) >